Received: by 2002:ac0:bc90:0:0:0:0:0 with SMTP id a16csp4673587img; Tue, 26 Mar 2019 14:21:40 -0700 (PDT) X-Google-Smtp-Source: APXvYqy3PAXBq+0y4mGtdjZz/BzZjrKeZJtYwtZ/BGZC9wZ/qcOnd0OH2rE2p8mbojOnyuFYCfep X-Received: by 2002:a65:538e:: with SMTP id x14mr30234922pgq.79.1553635300215; Tue, 26 Mar 2019 14:21:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553635300; cv=none; d=google.com; s=arc-20160816; b=F/E8oDF0Gzf8FY/tk5AMooJKUBbUJM1hdnOavYmaZEDaj9QqXR25uJQ1vqcRjaTUEz Hw8mWLhWCizM16jMNJXiHrs9HJKHkAXszPdpyJ2os8vLMjiDDQa3OWvRNnETi3Uz/eI6 VL/twMRT2a6vbluqT1ko3+VEfPq9d4d0OFhT9BNI3QbgE7nwnLK5e2MNiav+qaNEoBHr TiqOF/uLX0sUhcsu14Lfjar/J+QUptiHXH2LO4+nKS20HKEQJ4Ne/bLECbQNNtt/fpmQ Xhrfasf/L7IEpr4wH0pS5+rUKfeFUz8eqYaOuobnRuOnWNZi6+U23jtKsUwmhSZnyXzo 7oNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :message-id:in-reply-to:subject:cc:to:from:date; bh=Zs7g0r5KbYhHQSUf/Ua8JSv/ggVqM2qeY2EpQueE7gM=; b=mDjY61j3Ek4jMJ6EoleMngd3yA2lI7SLO82ce72zwc8f6+ro/ADZ981wQIeadhThFL IUv/xnJ6DEEM+MA5dwnKO6Z0aKwqYFk5dsHXhp1hUMF8XE1cF8iAfEP2q5OY7jRoyBiZ CVaXyE2BPkqPTknUPaVjIS9IHttVPc9dT18INRubMlDZaXev7GCmvBO1Zvgb/Poz2XC0 lhlTBpC0Ma3sFZybpRH4NVkY0OjKsbgEQyfE+kf3Hjd6bS1KOG6zZuS76rDiNm0expSL X5BK7Ccxh9RpgTQPYeWju8O3Sw8tJZu2doboBRw6vXF3O8fpGYT7er6LiX7xHs4r8NtI feiw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id bj1si17098227plb.15.2019.03.26.14.21.24; Tue, 26 Mar 2019 14:21:40 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732201AbfCZVTa (ORCPT + 99 others); Tue, 26 Mar 2019 17:19:30 -0400 Received: from Galois.linutronix.de ([146.0.238.70]:49442 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727145AbfCZVT3 (ORCPT ); Tue, 26 Mar 2019 17:19:29 -0400 Received: from p5492e2fc.dip0.t-ipconnect.de ([84.146.226.252] helo=nanos) by Galois.linutronix.de with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1h8tSr-0006XE-Fg; Tue, 26 Mar 2019 22:18:33 +0100 Date: Tue, 26 Mar 2019 22:18:32 +0100 (CET) From: Thomas Gleixner To: Ricardo Neri cc: Ingo Molnar , Borislav Petkov , Ashok Raj , Andi Kleen , Peter Zijlstra , "Ravi V. Shankar" , x86@kernel.org, linux-kernel@vger.kernel.org, Ricardo Neri , "H. Peter Anvin" , Tony Luck , Don Zickus , Nicholas Piggin , Michael Ellerman , Frederic Weisbecker , Babu Moger , "David S. Miller" , Benjamin Herrenschmidt , Paul Mackerras , Mathieu Desnoyers , Masami Hiramatsu , Andrew Morton , Philippe Ombredanne , Colin Ian King , "Luis R. Rodriguez" , sparclinux@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Subject: Re: [RFC PATCH v2 08/14] watchdog/hardlockup: Decouple the hardlockup detector from perf In-Reply-To: <1551283518-18922-9-git-send-email-ricardo.neri-calderon@linux.intel.com> Message-ID: References: <1551283518-18922-1-git-send-email-ricardo.neri-calderon@linux.intel.com> <1551283518-18922-9-git-send-email-ricardo.neri-calderon@linux.intel.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 27 Feb 2019, Ricardo Neri wrote: > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Detect hard lockups on a system > + * > + * Copyright (C) Intel Corporation 2019 > + * > + * Note: All of this code comes from the original perf-specific hardlockup > + * detector. And because you copied it from there without modification this becomes automatically Copyrighted by Intel? May I recommend that you talk to your legal departement about this. Aside of that there is really no value in creating yet another file. The code in question can simply wrapped into a large #ifdef PERF in the old file. Thanks, tglx