Received: by 2002:ac0:bc90:0:0:0:0:0 with SMTP id a16csp4711160img; Tue, 26 Mar 2019 15:19:59 -0700 (PDT) X-Google-Smtp-Source: APXvYqx7BVpjiPLU6+05n7Aq5XGqrcaSlOVHedG6yzK+HGf15Xn1I+x43HTIR3spEZ/RGQ8hw3Bu X-Received: by 2002:a63:707:: with SMTP id 7mr9835948pgh.390.1553638799270; Tue, 26 Mar 2019 15:19:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553638799; cv=none; d=google.com; s=arc-20160816; b=Ul/m0Db15iSu/xkkHGffgYmfiYVx9zKj+8WR221Wr0TyiIlo/oZvRK4W/AthiiT2Sw 8bdmevCM24PLz/LXul2FMxA7IUDa4b7XptbNL3oAn4jzYatGI1a1H9rt03TwiKwx0O+Z nMgvaV+woMAtUC6IE3flsJhZN8J8V8jTYuyOInDl/weGDF/+rHS8E/FYzQUM/rMxxfzQ v1Mk3/A4QmgIX2ZxDbqIYuQfc7cTyX6r1YDzbPcYewxMCPhG54jvkgKK435DPAee/voL FMBEZe4erLlDZn1PYHjXaghta2+TwpJmPPwiLjQeIQkSWov63pn92ouG6tfnuSwHvXGM niqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=MZ85C1pBI3vP3tPCk5KHX2EfsqJtFpHVbJrgQ1KRDZw=; b=oBTU8HZtipMd8V/PjUwLuClkSqQ8jmRpbsStIZeXGWgl67vb0ga2gPn6k1xJY7sgUX sPgDQrgZX6UFyHXgxiphWRLMZcjHpyvOmxevLhueP9j2ZpWrFlkqnudp1ikxZuAtD7G4 um/S9r3O3VL7AZXYxkgsAuICOFz1G4D5XsmXmj2CaWZLl2y4oy9tx8IwEVOYvLRi3BP7 YHI7CPgS/6NfBfhsICeLfVjVUTpcE+q/IM+QpC0j3FKCJQr08fok+Y06VLsrwoiKk/6o sdvrJF3W1ZdAXQG7QIXNu9ffB6Bvw1GzNymUypx3ujQPrkt518OeA7rqdWijTmwJf2wd 2TBQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 37si4657326pgz.512.2019.03.26.15.19.43; Tue, 26 Mar 2019 15:19:59 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731718AbfCZWS3 (ORCPT + 99 others); Tue, 26 Mar 2019 18:18:29 -0400 Received: from mga01.intel.com ([192.55.52.88]:55268 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727422AbfCZWS3 (ORCPT ); Tue, 26 Mar 2019 18:18:29 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Mar 2019 15:18:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,274,1549958400"; d="scan'208";a="145482959" Received: from tassilo.jf.intel.com (HELO tassilo.localdomain) ([10.7.201.137]) by orsmga002.jf.intel.com with ESMTP; 26 Mar 2019 15:18:28 -0700 Received: by tassilo.localdomain (Postfix, from userid 1000) id AC4753015ED; Tue, 26 Mar 2019 15:18:28 -0700 (PDT) From: Andi Kleen To: acme@kernel.org Cc: jolsa@kernel.org, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Andi Kleen Subject: [PATCH 1/4] perf, tools: Revert checks for duration_time Date: Tue, 26 Mar 2019 15:18:20 -0700 Message-Id: <20190326221823.11518-2-andi@firstfloor.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190326221823.11518-1-andi@firstfloor.org> References: <20190326221823.11518-1-andi@firstfloor.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Andi Kleen This reverts e864c5ca145e perf stat: Hide internal duration_time counter but doing it manually since the code has now moved to a different file. The next patch will properly implement duration_time as a full event, so no need to hide it anymore. Signed-off-by: Andi Kleen --- tools/perf/util/stat-display.c | 18 ------------------ 1 file changed, 18 deletions(-) diff --git a/tools/perf/util/stat-display.c b/tools/perf/util/stat-display.c index 6d043c78f3c2..3324f23c7efc 100644 --- a/tools/perf/util/stat-display.c +++ b/tools/perf/util/stat-display.c @@ -18,11 +18,6 @@ #define CNTR_NOT_SUPPORTED "" #define CNTR_NOT_COUNTED "" -static bool is_duration_time(struct perf_evsel *evsel) -{ - return !strcmp(evsel->name, "duration_time"); -} - static void print_running(struct perf_stat_config *config, u64 run, u64 ena) { @@ -628,9 +623,6 @@ static void print_aggr(struct perf_stat_config *config, ad.id = id = config->aggr_map->map[s]; first = true; evlist__for_each_entry(evlist, counter) { - if (is_duration_time(counter)) - continue; - ad.val = ad.ena = ad.run = 0; ad.nr = 0; if (!collect_data(config, counter, aggr_cb, &ad)) @@ -848,8 +840,6 @@ static void print_no_aggr_metric(struct perf_stat_config *config, if (prefix) fputs(prefix, config->output); evlist__for_each_entry(evlist, counter) { - if (is_duration_time(counter)) - continue; if (first) { aggr_printout(config, counter, cpu, 0); first = false; @@ -906,8 +896,6 @@ static void print_metric_headers(struct perf_stat_config *config, /* Print metrics headers only */ evlist__for_each_entry(evlist, counter) { - if (is_duration_time(counter)) - continue; os.evsel = counter; out.ctx = &os; out.print_metric = print_metric_header; @@ -1136,15 +1124,11 @@ perf_evlist__print_counters(struct perf_evlist *evlist, break; case AGGR_THREAD: evlist__for_each_entry(evlist, counter) { - if (is_duration_time(counter)) - continue; print_aggr_thread(config, _target, counter, prefix); } break; case AGGR_GLOBAL: evlist__for_each_entry(evlist, counter) { - if (is_duration_time(counter)) - continue; print_counter_aggr(config, counter, prefix); } if (metric_only) @@ -1155,8 +1139,6 @@ perf_evlist__print_counters(struct perf_evlist *evlist, print_no_aggr_metric(config, evlist, prefix); else { evlist__for_each_entry(evlist, counter) { - if (is_duration_time(counter)) - continue; print_counter(config, counter, prefix); } } -- 2.20.1