Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190325195303.GA20629@hari-Inspiron-1545>
In-Reply-To: <20190325195303.GA20629@hari-Inspiron-1545>
From:   Roopa Prabhu <roopa@cumulusnetworks.com>
Date:   Tue, 26 Mar 2019 17:19:48 -0700
Message-ID: <CAJieiUgwikFOcgyk-zht+Z_D8rqjpbcVGVFunzv=nNoxVrKcvg@mail.gmail.com>
Subject: Re: [PATCH] trace: events: fix error directive in argument list
To:     Hariprasad Kelam <hariprasad.kelam@gmail.com>
Cc:     rostedt@goodmis.org, mingo@redhat.com,
        David Miller <davem@davemloft.net>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Mar 25, 2019 at 12:53 PM Hariprasad Kelam
<hariprasad.kelam@gmail.com> wrote:
>
> This patch fixes below spare errors.
>
> Sparse error:
> make C=2 CF=-D__CHECK_ENDIAN__ M=net/core
> ./include/trace/events/neigh.h:73:1: error: directive in argument list
> ./include/trace/events/neigh.h:78:1: error: directive in argument list
> ./include/trace/events/neigh.h:150:1: error: directive in argument list
> ./include/trace/events/neigh.h:155:1: error: directive in argument list
>
> Changes below two lines to signle line to avoid sparse error
>  #if IS_ENABLED(CONFIG_IPV6)
>                if (n->tbl->family == AF_INET6) {
> to if (IS_ENABLED(CONFIG_IPV6) && n->tbl->family == AF_INET6)
>
> and removes reassigning pin6 pointer when IPV6 is enabled
>
> Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com>

Acked-by: Roopa Prabhu <roopa@cumulusnetworks.com>

Thanks!