Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <1553602391-11926-1-git-send-email-laoar.shao@gmail.com>
 <1553602391-11926-4-git-send-email-laoar.shao@gmail.com> <20190326151815.GI4102@linux.ibm.com>
 <20190326112958.2668a4a1@gandalf.local.home>
In-Reply-To: <20190326112958.2668a4a1@gandalf.local.home>
From:   Yafang Shao <laoar.shao@gmail.com>
Date:   Wed, 27 Mar 2019 09:17:45 +0800
Message-ID: <CALOAHbCZ7Bppb8q5=b=QG4g+uZu4EdKQZcME346OJPiCPsQngA@mail.gmail.com>
Subject: Re: [PATCH v2 3/3] rcu: validate arguments for rcu tracepoints
To:     Steven Rostedt <rostedt@goodmis.org>
Cc:     "Paul E. McKenney" <paulmck@linux.ibm.com>, mingo@redhat.com,
        Peter Zijlstra <peterz@infradead.org>, josh@joshtriplett.org,
        Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
        jiangshanlai@gmail.com, joel@joelfernandes.org,
        LKML <linux-kernel@vger.kernel.org>, shaoyafang@didiglobal.com
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Mar 26, 2019 at 11:30 PM Steven Rostedt <rostedt@goodmis.org> wrote:
>
> On Tue, 26 Mar 2019 08:18:15 -0700
> "Paul E. McKenney" <paulmck@linux.ibm.com> wrote:
>
> > On Tue, Mar 26, 2019 at 08:13:11PM +0800, Yafang Shao wrote:
> > > When CONFIG_RCU_TRACE is not set, all these tracepoints are defined as
> > > do-nothing macro.
> > > We'd better make those inline functions that take proper arguments.
> > >
> > > As RCU_TRACE() is defined as do-nothing marco as well when
> > > CONFIG_RCU_TRACE is not set, so we can clean it up.
> >
> > How about this for the commit log?
> >
> >       Unless the CONFIG_RCU_TRACE kconfig option is set, almost all
> >       of RCU's tracepoints are defined as empty macros.  It would
> >       be better if these tracepoints could instead be empty inline
> >       functions with proper arguments and type checking.  It would
> >       also be good to get rid of the RCU_TRACE() macro, which
> >       compiles its argument in CONFIG_RCU_TRACE=y kernels and
> >       omits them otherwise.
> >
> >       This commit therefore creates a TRACE_EVENT_RCU macro that
> >       is defined as TRACE_EVENT in CONFIG_RCU_TRACE=y kernels and
> >       as the new TRACE_EVENT_NOP otherwise, which allows the
> >       empty macros and the RCU_TRACE() macro to be eliminated.
> >
> > With that:
> >
> > Reviewed-by: Paul E. McKenney <paulmck@linux.ibm.com>
>
> Yafang,
>
> If you are OK with the above changes, I'll take this patch with the
> updated change log.
>

Hi Steve,

This new changelog is OK by me.
Pls. take it.

Thanks
Yafang