Received: by 2002:ac0:bc90:0:0:0:0:0 with SMTP id a16csp4844339img; Tue, 26 Mar 2019 18:49:47 -0700 (PDT) X-Google-Smtp-Source: APXvYqxhXAEK5qVfBAiZojJfAbz68WDtW6fokbQITUM39GtN67JHKsGkoQcSvFVsVVYiFegMbORA X-Received: by 2002:a17:902:784c:: with SMTP id e12mr34456263pln.117.1553651386896; Tue, 26 Mar 2019 18:49:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553651386; cv=none; d=google.com; s=arc-20160816; b=DU8zMZo/Oz7F60Xqp7W+nBQJVUkCzGFb3f5sBAoNFo3s1bGEUjWITEycKPBPQX07HC 1Rgd3Gr9ord01tSJYkUF6boldyiFV9yk8CCwwciNsMZ+cY4lkWbpq2/Jxj2dTpd93Cyc 3/F+LwIr/4UmfTFT7wZNw5LnPi8JmY0JCAw2sn8GlsJeMUO0la76s7URd7vjC1uIIN6C EJtMdQ8t9q6HkMsAo6hti9rdLTQByBbK9XclbgYh/XCb1U+iAqMfJfhhwwbswg5qCVMr ZsicQFftBFuuEICutHpiMZhsKEKpe5qHSdh4xtIy+7w+waV5s5kSG1xWJdcvQouMGhmq tcsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:dkim-signature:dkim-filter:from; bh=jKJAI4BVg7Agjkv6HfZrBiBPJ9+GI2U7E3AkTvssGmA=; b=qAoRyDalEhqpsheasmfdw6V5J1qN+6L2tA3sXAYGWSs371qY35RnLrvZjXaUX/tzSp 37lYvovfVQo0Jz6yxQJjichnGcp2If2zLyt8H8DxTZ6uQP7VoOoqmdX9mhJQCVOl+oC/ r7L9uv4VbE1PSO73YtfknnBC8r3zDrOkVtLSig9BJhKzXv71k6tyyC9PYalGbMVC4469 C0TKj43d/ncAt4P61cqF2tUp8qMLDGzpK5QQjlWxxWaxbA8hvCMpsgmj1PDzO39LBmSb F/Jk1X4aq3Yc4U036fS1qM5/5kBqMV8jsdkTKwrCu/nqWVb1JOpG+EcouyRicNjvqhe6 ZufQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@innovation.ch header.s=default header.b=R1p1fRuc; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=innovation.ch Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x6si881664pga.310.2019.03.26.18.49.19; Tue, 26 Mar 2019 18:49:46 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@innovation.ch header.s=default header.b=R1p1fRuc; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=innovation.ch Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732559AbfC0BsS (ORCPT + 99 others); Tue, 26 Mar 2019 21:48:18 -0400 Received: from chill.innovation.ch ([216.218.245.220]:48314 "EHLO chill.innovation.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731934AbfC0BsR (ORCPT ); Tue, 26 Mar 2019 21:48:17 -0400 Received: from localhost (localhost [127.0.0.1]) by chill.innovation.ch (Postfix) with ESMTP id 3862464013F; Tue, 26 Mar 2019 18:48:17 -0700 (PDT) X-Virus-Scanned: amavisd-new at Received: from chill.innovation.ch ([127.0.0.1]) by localhost (chill.innovation.ch [127.0.0.1]) (amavisd-new, port 10024) with LMTP id G_IDRkml_2Eo; Tue, 26 Mar 2019 18:48:15 -0700 (PDT) From: =?UTF-8?q?Ronald=20Tschal=C3=A4r?= DKIM-Filter: OpenDKIM Filter v2.10.3 chill.innovation.ch DBB6E640114 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=innovation.ch; s=default; t=1553651295; bh=jKJAI4BVg7Agjkv6HfZrBiBPJ9+GI2U7E3AkTvssGmA=; h=From:To:Cc:Subject:Date:From; b=R1p1fRucG2nLlZZHzhy4Ovm2Fb98NXzo3HKFfhJzXL+H5oOBuJa1w8nZhv/RRUFnn DxNHoHJHTbgRKa6HW07gR8K94caP+h9GzRBqm/77+BhTginGSeOR8XLwnld8xw9A6i DB1gK15N5hTtop7/yS8z6b5g4VKuOExtEIFy9vZbfrwpvpHv8dis16s9hHC8+vdSD8 r5wHhqpeMlpahP+Kbti29pEmjHlHTrSGKuCJeznC8DJBi4cdMP5Y8MBMGdq8O7ZAEL uzcruqePoCh7xWTdnzE1wymP3pRad9GD7CJOp5bAC2nJIZTcAwWWiNOkOz0O22xoDF WeH/fsSmJmNsA== To: Dmitry Torokhov , Henrik Rydberg , Andy Shevchenko , Sergey Senozhatsky , Steven Rostedt , Greg Kroah-Hartman , "Rafael J. Wysocki" Cc: Lukas Wunner , Federico Lorenzi , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 0/4] Add Apple SPI keyboard and trackpad driver Date: Tue, 26 Mar 2019 18:48:03 -0700 Message-Id: <20190327014807.7472-1-ronald@innovation.ch> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This changeset adds a driver for the SPI keyboard and trackpad on recent MacBook's and MacBook Pro's. The driver has seen a fair amount of use over the last 2 years (basically anybody running linux on these machines), with only relatively small changes in the last year or so. For those interested, the driver development has been hosted at https://github.com/cb22/macbook12-spi-driver/ (as well as my clone at https://github.com/roadrunner2/macbook12-spi-driver/). The first patch is just a placeholder for now and is provided in case somebody wants to compile the driver while it's being reviewed here; the real patch has been submitted to dri-devel and is being discussed there, with the intent/hope that I can get an Ack and permission to merge it through the input subsystem tree here as part of this patch series. The second and third patches add a new dev_print_hex_dump() helper as the dev_xxx() analog of print_hex_dump(). The fourth patch finally contains the new applespi driver. Changes in v3: Applied all feedback from review by Andy Shevchenko, including: - move dev_print_hex_dump() to driver core - clean up keyboard modifier bits testing/modifying - remove DEV() macro - minor style issues The full set of changes to applespi can be viewed at https://github.com/roadrunner2/macbook12-spi-driver/ as individual commits f832caa..3a6262e in the upstreaming-review branch. Ronald Tschalär (4): drm/bridge: sil_sii8620: depend on INPUT instead of selecting it. lib/hexdump.c: factor out generic hexdump formatting for reuse. driver core: add dev_print_hex_dump() logging function. Input: add Apple SPI keyboard and trackpad driver. drivers/base/core.c | 43 + drivers/gpu/drm/bridge/Kconfig | 2 +- drivers/input/keyboard/Kconfig | 15 + drivers/input/keyboard/Makefile | 1 + drivers/input/keyboard/applespi.c | 1988 +++++++++++++++++++++++++++++ include/linux/device.h | 15 + include/linux/printk.h | 12 + lib/hexdump.c | 95 +- 8 files changed, 2146 insertions(+), 25 deletions(-) create mode 100644 drivers/input/keyboard/applespi.c -- 2.20.1