Received: by 2002:ac0:bc90:0:0:0:0:0 with SMTP id a16csp4935036img; Tue, 26 Mar 2019 21:31:34 -0700 (PDT) X-Google-Smtp-Source: APXvYqxNSwM1Bb4i+eCmQLUezLdDcgPp2aufjkQG/hAe32SHpCpP8V71QjFf0Hw+6qhbxs6Mk16Y X-Received: by 2002:a17:902:8e82:: with SMTP id bg2mr35300471plb.217.1553661094675; Tue, 26 Mar 2019 21:31:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553661094; cv=none; d=google.com; s=arc-20160816; b=GCDLFI0d2rVU9dQhmDUXA8Mjwn5gVwlEgH5hMQIDM+W0rmC6RVF5sCmFaFPaFh3rei Aa51e8cPFbXboKm2ZmQWTnkzSuQvD52b277tNyN9Bc5kOkj/eCVQ8G+BY4Gn4R4rhZSP cplS5OuFrygQHi/T4YJ8xGXja3ehbb3QFLsJRSyETwVZQVFRF/bIGFDPfaxmuJaJ+IHJ ONw6D0T+VviXTsiHPoJwvDKH+YNdKgNGgaFma9dacDAqV7cZrFqyh42Hs3ziwsoBH31p Dad51d9/5lGw5hojAVLzWuKGI8U63szY+zi6G7cbhYlQ300bRyhvjJrrxTAkHxeO7Br1 nYlA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:organization:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=NAD9wf358rQO7P2xPYBLtFNYXQw63pg9wMOaY3pEyxY=; b=0w9KWRb7Rc0Six6XEbImOW/zaO/rXyhGXgxIXOyY9ASsJ34dDJL3x2Up7Q96bqIbgL V8ipJBB9whf7kiRHdGkUeSZVb5H8eSSco8uTCX/wiqzDFdzi+Gg4HVgWbEWcqfJwxotd 8H6ZXz39/U/Y2faUrLye4UKA4E8scYJDpKQhMm30DHZvXNijRlpLfAc8VKsyIitnrW/Z fgf5Zdl5juALJbE8wCjt4kqjf2izBE/5SGmv3k6t/TfDWGPP3avmgF2heA/uhI9DfAbq IxBpxuRywAsx5D5MxXGZ9L6Kr4S9Wy6YKJHMAS2zOg24RskLNc4fuEZES7ROm/KY8v5D vPNg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i93si13317672plb.189.2019.03.26.21.30.44; Tue, 26 Mar 2019 21:31:34 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725916AbfC0E3A (ORCPT + 99 others); Wed, 27 Mar 2019 00:29:00 -0400 Received: from mga18.intel.com ([134.134.136.126]:44646 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725763AbfC0E3A (ORCPT ); Wed, 27 Mar 2019 00:29:00 -0400 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Mar 2019 21:28:59 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,275,1549958400"; d="scan'208";a="286204597" Received: from yannluen-mobl.ccr.corp.intel.com (HELO localhost) ([10.249.254.205]) by orsmga004.jf.intel.com with ESMTP; 26 Mar 2019 21:28:55 -0700 Date: Wed, 27 Mar 2019 06:28:54 +0200 From: Jarkko Sakkinen To: Tadeusz Struk Cc: grawity@gmail.com, James.Bottomley@HansenPartnership.com, linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH RESEND v3] tpm: fix an invalid condition in tpm_common_poll Message-ID: <20190327042854.GA15397@linux.intel.com> References: <155326553839.17270.7997105682830234546.stgit@tstruk-mobl1.jf.intel.com> <20190322155917.GA6987@linux.intel.com> <20190325140954.GA13699@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 26, 2019 at 08:58:28AM -0700, Tadeusz Struk wrote: > Hi Jarkko, > On 3/25/19 7:09 AM, Jarkko Sakkinen wrote: > > It is still missing the comment I asked to add. Otherwise, it is good. > > > > Sorry, I didn't see your email with the suggestion earlier. > To be honest I'm not sure if this comment adds much value, or if it is > even correct. The poll doesn't "succeed" or "fail". It just returns > a mask indicating if there is any data to read or if the user can write. > > Isn't the commit message + 'git blame' enough to remember why it was > done this way? Comments in the code have also their time and place especially when doing code reviews. Usually I like to have something in a site where there has been a race even if it was for fairly trivial reason. If you want to refine the comment to be more to the point, that is perfectly fine. /Jarkko