Received: by 2002:ac0:bc90:0:0:0:0:0 with SMTP id a16csp5010054img; Tue, 26 Mar 2019 23:37:43 -0700 (PDT) X-Google-Smtp-Source: APXvYqxTiLqaaiG2D/NtF405LMZALDW9g1lsnAnc2nISOzDsq0KjNi1pjzFrgW7xK6Ft8tU7wnkt X-Received: by 2002:a17:902:7e4b:: with SMTP id a11mr35175663pln.219.1553668663468; Tue, 26 Mar 2019 23:37:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553668663; cv=none; d=google.com; s=arc-20160816; b=IIY84ocxV+BeCR4scnMruiTK0qeX+M8IlbVNh4vQ2J/5FRCQnh6Bhc2fBwy0Ysx/uO K1MGW6ft+pzD4MWd0jOYlzkySHo6X+ME/XoxAkFtXi4B/QL7/5JmP0qQQG3agZ+f9DhI TjtBdTW1IuS6eMeClvzK7VHAnRP4WCTnfAcZl/Ag3VC4e0IoaFpqxaSHK9cNtVWiFnxT mhyPnum9jNt8Q155Myo1/eFbFKMWJ3jSmTgtyB+LM3bSr258/wA3s/S0NAl1EDJsEbzn 6VVquHaN1bjBxH9+pe0blYe8sQSpZJN1rrpcBtgiukg1ZWTpBQo3Tf0l18JsQw8HZEN/ RCSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=IGSgYnXou/RBGvA6mnIJIA4AjlVL5IMIKpxYYCYDXUY=; b=0V/QT8yRPtjNl9YOoccxf8rpweb/bOOdviCt1FaZreq/1NufG7D197BcrdHS4b3HTI erMyTfdkw5+O+NGfsunZrMOXyRwWTKA+MzAabkqXWYYvmdSoPIi7NXX2ro/SVF0y2+7a 8hVWNU27ITtFsF5JQwJPITYlVXNp3wvFefr+7Bydyjp9HlQ3VStDiCkdkid2qP9nnK0N cDMT/17XmdiiFn4ERKi/is3bQJ7cViNlZqRp5LIB0gxhV+AEZL5QjzuNQXeM9IkDsD4z oqEYYz7X147EmjjcWww4JMiB5jVgrhB9AYUxhT3WON3k1RncgcXJeyh3KqIS/CqTC4Zu NumA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g75si18075580pfg.49.2019.03.26.23.37.28; Tue, 26 Mar 2019 23:37:43 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733281AbfC0Ggp (ORCPT + 99 others); Wed, 27 Mar 2019 02:36:45 -0400 Received: from relay11.mail.gandi.net ([217.70.178.231]:46149 "EHLO relay11.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726208AbfC0Ggn (ORCPT ); Wed, 27 Mar 2019 02:36:43 -0400 Received: from alex.numericable.fr (127.19.86.79.rev.sfr.net [79.86.19.127]) (Authenticated sender: alex@ghiti.fr) by relay11.mail.gandi.net (Postfix) with ESMTPSA id 78482100003; Wed, 27 Mar 2019 06:36:28 +0000 (UTC) From: Alexandre Ghiti To: aneesh.kumar@linux.ibm.com, mpe@ellerman.id.au, Andrew Morton , Vlastimil Babka , Catalin Marinas , Will Deacon , Benjamin Herrenschmidt , Paul Mackerras , Martin Schwidefsky , Heiko Carstens , Yoshinori Sato , Rich Felker , "David S . Miller" , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H . Peter Anvin" , x86@kernel.org, Dave Hansen , Andy Lutomirski , Peter Zijlstra , Mike Kravetz , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-mm@kvack.org Cc: Alexandre Ghiti Subject: [PATCH v8 0/4] Fix free/allocation of runtime gigantic pages Date: Wed, 27 Mar 2019 02:36:22 -0400 Message-Id: <20190327063626.18421-1-alex@ghiti.fr> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This series fixes sh and sparc that did not advertise their gigantic page support and then were not able to allocate and free those pages at runtime. It renames MEMORY_ISOLATION && COMPACTION || CMA condition into the more accurate CONTIG_ALLOC, since it allows the definition of alloc_contig_range function. Finally, it then fixes the wrong definition of ARCH_HAS_GIGANTIC_PAGE config that, without MEMORY_ISOLATION && COMPACTION || CMA defined, did not allow architectures to free boottime allocated gigantic pages although unrelated. Changes in v8: This (hopefully last) version is rebased against v5.1-rc2 so that it takes into account https://patchwork.ozlabs.org/patch/1047003/. This version: - factorizes gigantic_page_runtime_supported such as suggested by Christophe. - fix checkpath warning regarding the use of 'extern' - fix s390 build that does not include asm-generic/hugetlb.h And note that I did not add the reviewed-by and acked-by received in v6 since the patch differs a little. Changes in v7: I thought gigantic page support was settled at compile time, but Aneesh and Michael have just come up with a patch proving me wrong for powerpc: https://patchwork.ozlabs.org/patch/1047003/. So this version: - reintroduces gigantic_page_supported renamed into gigantic_page_runtime_supported - reintroduces gigantic page page support corresponding checks (not everywhere though: set_max_huge_pages check was redundant with __nr_hugepages_store_common) - introduces the possibility for arch to override this function by using asm-generic/hugetlb.h current semantics although Aneesh proposed something else. Changes in v6: - Remove unnecessary goto since the fallthrough path does the same and is the 'normal' behaviour, as suggested by Dave Hensen - Be more explicit in comment in set_max_huge_page: we return an error if alloc_contig_range is not defined and the user tries to allocate a gigantic page (we keep the same behaviour as before this patch), but we now let her free boottime gigantic page, as suggested by Dave Hensen - Add Acked-by, thanks. Changes in v5: - Fix bug in previous version thanks to Mike Kravetz - Fix block comments that did not respect coding style thanks to Dave Hensen - Define ARCH_HAS_GIGANTIC_PAGE only for sparc64 as advised by David Miller - Factorize "def_bool" and "depends on" thanks to Vlastimil Babka Changes in v4 as suggested by Dave Hensen: - Split previous version into small patches - Do not compile alloc_gigantic** functions for architectures that do not support those pages - Define correct ARCH_HAS_GIGANTIC_PAGE in all arch that support them to avoid useless runtime check - Add comment in set_max_huge_pages to explain that freeing is possible even without CONTIG_ALLOC defined - Remove gigantic_page_supported function across all archs Changes in v3 as suggested by Vlastimil Babka and Dave Hansen: - config definition was wrong and is now in mm/Kconfig - COMPACTION_CORE was renamed in CONTIG_ALLOC Changes in v2 as suggested by Vlastimil Babka: - Get rid of ARCH_HAS_GIGANTIC_PAGE - Get rid of architecture specific gigantic_page_supported - Factorize CMA or (MEMORY_ISOLATION && COMPACTION) into COMPACTION_CORE Alexandre Ghiti (4): sh: Advertise gigantic page support sparc: Advertise gigantic page support mm: Simplify MEMORY_ISOLATION && COMPACTION || CMA into CONTIG_ALLOC hugetlb: allow to free gigantic pages regardless of the configuration arch/arm64/Kconfig | 2 +- arch/arm64/include/asm/hugetlb.h | 4 -- arch/powerpc/include/asm/book3s/64/hugetlb.h | 5 +- arch/powerpc/platforms/Kconfig.cputype | 2 +- arch/s390/Kconfig | 2 +- arch/s390/include/asm/hugetlb.h | 8 +-- arch/sh/Kconfig | 1 + arch/sparc/Kconfig | 1 + arch/x86/Kconfig | 2 +- arch/x86/include/asm/hugetlb.h | 4 -- arch/x86/mm/hugetlbpage.c | 2 +- include/asm-generic/hugetlb.h | 7 +++ include/linux/gfp.h | 4 +- mm/Kconfig | 3 ++ mm/hugetlb.c | 54 ++++++++++++++------ mm/page_alloc.c | 7 ++- 16 files changed, 67 insertions(+), 41 deletions(-) -- 2.20.1