Received: by 2002:ac0:bc90:0:0:0:0:0 with SMTP id a16csp5014757img; Tue, 26 Mar 2019 23:45:00 -0700 (PDT) X-Google-Smtp-Source: APXvYqyWIyjtcDWSdi6tPtv9SHNZ3jJA7M0c3MkUZdRqxpWPCV4dx7GFw3lh9lMonyMbg8L6CL1j X-Received: by 2002:a63:78a:: with SMTP id 132mr25506751pgh.196.1553669100156; Tue, 26 Mar 2019 23:45:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553669100; cv=none; d=google.com; s=arc-20160816; b=iYIMfSNYaN5NWp0u6Lk/ZaTT2RLvPCuqfnw4t494OElFMM0IWogZIPTb3lenQX2TaR 6K31gfGY0O6u8kcozHSVkb8buZZbuION0krdl6DhCY8y9wRAU2+ZOdA4GPcFOh1IQ3z8 v6iljhdF0/Pao55tEdp1ZKvw2VeJDRb3hhsSBGKRkGCYSf6i5c6Mo+IEfuAjGxkG5aXu lIzIKCsdWSG6ewAGhlBWEAQxRdcTgIvu4J5DMOU/Z+aYYjZoB9U5mkX+FN1C3C2g4i/r rTUx/TMRW0PPca7CiQNHQSd58PeRNf5X4n8qW9Csa9JF3ctMbmu8JKpEPU1wDj3mX7uv /H+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature; bh=Jy7F2QSsf5OTfixtg/4VNXIPeW3wBP1cuuaUxSIcMMA=; b=l6VDxWekd7nw5b3SDuVnXYSKTdRik2T3ONMIXBQK0EEX5JeV3dWMOqk17arQQsO7nj i3hmoxqaMxrGWkSBuPKNVZyaXcSKVwElu656BDEfMjf1bYEa6lf4/vQbvS2Y1XAKm5h1 pGcYGGzMgbGqioSL2YEpZcw1m/o/iAUmYKiymQVvjgMOPZaVOHU59w68vjaviTA5ozG9 +u55u/ldYj5q8VErzZlXobI6t3rN3gMJF+hMtBWJDDxW4N2fy4e+LXujrKnQgTBkmISt Yw553rZXXhSkvh5PSfXptVukqzEllMauPYFXPtcK0j75Ix2CmazdIXn0Yqn0dDpwhaVQ MzWQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=pvitqHl4; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a13si15173905pgh.139.2019.03.26.23.44.45; Tue, 26 Mar 2019 23:45:00 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=pvitqHl4; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387520AbfC0GnC (ORCPT + 99 others); Wed, 27 Mar 2019 02:43:02 -0400 Received: from mail-pf1-f196.google.com ([209.85.210.196]:36594 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726214AbfC0GnA (ORCPT ); Wed, 27 Mar 2019 02:43:00 -0400 Received: by mail-pf1-f196.google.com with SMTP id p10so9268285pff.3; Tue, 26 Mar 2019 23:43:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=Jy7F2QSsf5OTfixtg/4VNXIPeW3wBP1cuuaUxSIcMMA=; b=pvitqHl4Wz4/M52ef9EPVvoUKyFldCtAyYXHPqLkOPa7Cm9AKJcaCZTpzNFi/0WgEC 4UEzFFsQO1no14cCUsLzjWjG9dAREb+PZVOw8TycPf/llHtecYio9Ef6xqPwLtQWVlgl KikSBKb8aGIXYgNABQuG8h98qBAHA/6+7Fg1yq9uhqbqSAVgJ1dPpMX7uLzIMNJS0iVg 103fCgY9SuEBFnT/go6msGkhB6OLEVm+UytBoOhIWIHjr3N+dUnYBOhWk23ObMOy8XWX YVj1mGZyrjE5v6a3UL9NO5iPszGF4bqcPYWy+6Sm5YQJIy9CWnmN4sIEpj96BjjpMUoW PurQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=Jy7F2QSsf5OTfixtg/4VNXIPeW3wBP1cuuaUxSIcMMA=; b=i1KXnvQsXG9jbHNTNCk5tuY/b9K33ouRbjHz9CZcfK5M/dwb6nfwWvaY43/L4DTbmr eJ9Z2okUDNUECdsRfiFNRJYl3PXHtmiUyaB0W9FxHXZsp0TAd5DbcqChd0qxnMGiX0Pe MpsuLwr86XIsmaT3D3vBoCv555GwJ+7JuA1Mt/FI3T3EkonZFarYsPVmOV3sQ/f7SxPH dJap/PXEesw/hQbcykV32ayWBfiJaIDICZTOcw0siCE9I7m9vxEKvppOFvwfjLOWXEd2 8EPwdUuqpk57SGEcjvx+H2Nhpo9JFzhaU0/T9vFRzAHsG/ld+UgfwsUtqlmDL7ZctBa6 1hqw== X-Gm-Message-State: APjAAAXIXJqKnaZcb5HD/UbLmQaZx3WejMunzR/0Kv/STLw0Cu8TisyC pizYAAYXjkpnvVrpfbDpWdxQyh1q X-Received: by 2002:a63:6bc6:: with SMTP id g189mr33157008pgc.427.1553668980149; Tue, 26 Mar 2019 23:43:00 -0700 (PDT) Received: from localhost (59-120-186-245.HINET-IP.hinet.net. [59.120.186.245]) by smtp.gmail.com with ESMTPSA id q62sm25737760pga.32.2019.03.26.23.42.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 26 Mar 2019 23:42:59 -0700 (PDT) From: "Ji-Ze Hong (Peter Hong)" X-Google-Original-From: "Ji-Ze Hong (Peter Hong)" To: peter_hong@fintek.com.tw, wim@linux-watchdog.org, linux@roeck-us.net Cc: linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org, "Ji-Ze Hong (Peter Hong)" Subject: [PATCH V2 1/2] watchdog: f71808e_wdt: separate declaration and assignment Date: Wed, 27 Mar 2019 14:42:50 +0800 Message-Id: <1553668971-18801-1-git-send-email-hpeter+linux_kernel@gmail.com> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Separate declaration and assignment in watchdog_start() Signed-off-by: Ji-Ze Hong (Peter Hong) --- drivers/watchdog/f71808e_wdt.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/watchdog/f71808e_wdt.c b/drivers/watchdog/f71808e_wdt.c index 9a1c761258ce..bd2ced9f39f4 100644 --- a/drivers/watchdog/f71808e_wdt.c +++ b/drivers/watchdog/f71808e_wdt.c @@ -338,8 +338,10 @@ static int f71862fg_pin_configure(unsigned short ioaddr) static int watchdog_start(void) { + int err; + /* Make sure we don't die as soon as the watchdog is enabled below */ - int err = watchdog_keepalive(); + err = watchdog_keepalive(); if (err) return err; -- 2.7.4