Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 0799360850
Subject: Re: [PATCH] ARM: socfpga: Fix object reference leaks in
 socfpga_setup_ocram_self_refresh
To:     Huang Zijiang <huang.zijiang@zte.com.cn>, dinguyen@kernel.org
Cc:     linux@armlinux.org.uk, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org, wang.yi59@zte.com.cn
References: <1553644422-42950-1-git-send-email-huang.zijiang@zte.com.cn>
From:   Mukesh Ojha <mojha@codeaurora.org>
Message-ID: <36c310f4-e22d-42bb-4d8d-c1e41306ede2@codeaurora.org>
Date:   Wed, 27 Mar 2019 12:47:26 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.6.0
MIME-Version: 1.0
In-Reply-To: <1553644422-42950-1-git-send-email-huang.zijiang@zte.com.cn>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 3/27/2019 5:23 AM, Huang Zijiang wrote:
> The of_find_device_by_node() takes a reference to the underlying device
> structure, we should release that reference.
>
> Signed-off-by: Huang Zijiang <huang.zijiang@zte.com.cn>
> ---
>   arch/arm/mach-socfpga/pm.c | 5 ++++-
>   1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-socfpga/pm.c b/arch/arm/mach-socfpga/pm.c
> index d486678..8d7ca14 100644
> --- a/arch/arm/mach-socfpga/pm.c
> +++ b/arch/arm/mach-socfpga/pm.c
> @@ -53,7 +53,7 @@ static int socfpga_setup_ocram_self_refresh(void)
>   	if (!pdev) {
>   		pr_warn("%s: failed to find ocram device!\n", __func__);
>   		ret = -ENODEV;
> -		goto put_node;
> +		goto fail;
>   	}
>   
>   	ocram_pool = gen_pool_get(&pdev->dev, NULL);
> @@ -94,6 +94,9 @@ static int socfpga_setup_ocram_self_refresh(void)
>   
>   put_node:
>   	of_node_put(np);
> +	put_device(&np->dev);
> +fail:
> +	of_node_put(np);


of_node_put is called twice for put_node label.

Thanks,
Mukesh


>   
>   	return ret;
>   }