Received: by 2002:ac0:bc90:0:0:0:0:0 with SMTP id a16csp5105920img;
        Wed, 27 Mar 2019 02:06:52 -0700 (PDT)
X-Google-Smtp-Source: APXvYqxvGlsI9wS/A6zPfiszbLyK+ihfAbhcNcIGkejoS/OjSgeA2Se49bfgZGmgUA/gLBcCQwQa
X-Received: by 2002:a17:902:6b81:: with SMTP id p1mr36273176plk.106.1553677611915;
        Wed, 27 Mar 2019 02:06:51 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1553677611; cv=none;
        d=google.com; s=arc-20160816;
        b=QkA9TQmuJ+DbK+y9L8L3/TcLB7P6NiaWTktys/zSxgTFfyjNoxu7qQ5WcQDdVW0+PO
         t4uXNyQa+qWTNWjS74HnGvbG9WKXvRh8V/XL1o0wJNDvEMVGb93H9attk0jD86sT+YIW
         XJcCZp6/TQC+Jfl1JJcsG7MFZ1DlN0p2yJ1Ah5yMYAXcBW0aapXtpuC1kv1IEIy1rCqr
         laNMIhDA5b7exZgKzpiqiVq/aUxJDRqPmnNcmuHSeuzj6gd5MNIJ392tuQgfi1i9ncXy
         zJgY+qNklb7k6NzP0/TvpCULtY5ZPI1uu6HwarnNBfVVzcYFyUMyDeIcrVp01rkB7hhU
         KKDA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:user-agent:in-reply-to
         :content-disposition:mime-version:references:message-id:subject:cc
         :to:from:date:dkim-signature;
        bh=9PChJgtM34ZbomqEZ8kyVfA1Pp+gvOK2R0JJ23U5L5Y=;
        b=bYSMRawXZu3qH58eGTwgWXiRNnEDo4B9kuvCcPCz3lBLs/WNZAO6EVqa3Fx7q7pTBY
         B5jqlbpm69UTJGYCKxX7/QpEkhVsbk8a7IEOVH3ZkPrf+FlTq3rCRuztcX/M9wrjaNIU
         VR7PbA2Cv66sznuoWanNr0G6256WlrLbBLkr1JCZWlh0OI14eWUIvq05WsSFHMbz/E/g
         BJsMAZtY9ryBB8lbUXzMqA8ISqUtUUoPo7n3FOsLtsByQqx9r3Xj62LZQWigQ49LzaqD
         GGANBaCwAbz9n8ovv8JVcKWKMJGUXMuHZ09ncnuGInnpjo6JJORyqDr8+F1XblnMucZT
         ptWw==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@alien8.de header.s=dkim header.b=NlOTsPYk;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id u31si17785893pgm.352.2019.03.27.02.06.36;
        Wed, 27 Mar 2019 02:06:51 -0700 (PDT)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@alien8.de header.s=dkim header.b=NlOTsPYk;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1732664AbfC0JF4 (ORCPT <rfc822;patchstalker@gmail.com>
        + 99 others); Wed, 27 Mar 2019 05:05:56 -0400
Received: from mail.skyhub.de ([5.9.137.197]:52164 "EHLO mail.skyhub.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1726469AbfC0JFz (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 27 Mar 2019 05:05:55 -0400
Received: from zn.tnic (p200300EC2F098000329C23FFFEA6A903.dip0.t-ipconnect.de [IPv6:2003:ec:2f09:8000:329c:23ff:fea6:a903])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 29F5E1EC0B3D;
        Wed, 27 Mar 2019 10:05:54 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim;
        t=1553677554;
        h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
         to:to:cc:cc:mime-version:mime-version:content-type:content-type:
         content-transfer-encoding:in-reply-to:in-reply-to:  references:references;
        bh=9PChJgtM34ZbomqEZ8kyVfA1Pp+gvOK2R0JJ23U5L5Y=;
        b=NlOTsPYkRX8eGg5M6hF26V57furoJHQsGRK3ij7DJRQqvx1Z2uf1PWM7yTKj1JVpH6kR4L
        u5umxLmzFeHYD+PHsK6B0x2Uc92dYh/kNUxwdXvKTtJ2YlY3ehbuZ6HVrSIwyU/C6yBK+t
        6lw/Co/jvZGlCQm1lmuagPPmqN/DDcg=
Date:   Wed, 27 Mar 2019 10:05:56 +0100
From:   Borislav Petkov <bp@alien8.de>
To:     Matteo Croce <mcroce@redhat.com>
Cc:     x86@kernel.org, "H . Peter Anvin" <hpa@zytor.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>,
        lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] x86/realmode: don't leak kernel addresses
Message-ID: <20190327090556.GA32571@zn.tnic>
References: <20190324190504.29906-1-mcroce@redhat.com>
 <20190326161457.GN1867@zn.tnic>
 <CAGnkfhwtXdjaHFChFBMNiSnh+cpDRi=e20J0EZ039xWuRTcouQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <CAGnkfhwtXdjaHFChFBMNiSnh+cpDRi=e20J0EZ039xWuRTcouQ@mail.gmail.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Mar 26, 2019 at 09:36:48PM +0100, Matteo Croce wrote:
> Got it, sent a v3 with the printk removed.
> Anyway, I wonder if we can remove the 'size' argument and/or moving
> set_real_mode_mem() into realmode.h to have it inlined.
> Or maybe it's not worth it.

Sure, why not. Making the code simpler is always a GoodThing(tm). :)

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.