Received: by 2002:ac0:bc90:0:0:0:0:0 with SMTP id a16csp5125641img; Wed, 27 Mar 2019 02:35:01 -0700 (PDT) X-Google-Smtp-Source: APXvYqwugCgFX+jCZ7vit5c2wLoc2uEJqxMo1l++brUGKVt3wcNpk1ONUc2dJ24kESKVqW1+ePb7 X-Received: by 2002:a17:902:b788:: with SMTP id e8mr25695303pls.339.1553679301078; Wed, 27 Mar 2019 02:35:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553679301; cv=none; d=google.com; s=arc-20160816; b=ryPdjJUgd0l8A2K9+FeezxtAjJGXAXcuaDRHurOR+vuoG/7S1eGC2FiHu4ZV61d3Sf xUMCsU5BkHpwJUywnSKaWmjP1G/XvmhomNODm8HTSeORegAnQmEBcBSe0bkSgcr7rp7t 6hHiX62odc+RYOpA8LtffbYIAigJVk0T0xwaIRpxTQkgepGJrCmyYwz3gpGQrHncsgao fSMgtFK+psqh+B8qdkcgJUokwWmeZuQPki5kp7oAQN7N1O/PZZ2EYSHpGbfrMCA1HLjA J+M/Y9CJt65zzPJ8pDjhZ3noKGp/e3dEByJ0bVhd/HrGSDnnSZ+A7ykRwCUs5KPj3JIe CW/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:date:cc:to:from:subject:message-id; bh=XXq/1HmmGhT/wti3cs5NDbFEsn5CoAqn8V6tlNHDV+E=; b=kfjV7cD4XYvJXEt5Qvjk8apgGxZ9vr3mtEyDsuJrbnQZEn4d1wgw783fP0qH+NqXqb zh1A+7CLM+Od2BA1EWKgYklaHuTq3iEuKPtCL/ETTEYMrzLDsKPNcV5Ue3AQ4zztvJ6R hB31BmtRamaeUZk2kBMJElrbm+EFou7eC83OO7A4QViQ0FI48W4Wpoy8nt6JY993FONO XlGoEnM3Y10bUxZJ46MfzGvK3T6A0oFY2Z1R6lfZzZFo/BgcaiTI8nalj1cJfiOE3ycr uv41NFO2l6xFndptR17+0raHK+wqLp33Sw97Gij/SPo7U63odDW3cLpq89PQsaIQ2WT9 bnIg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z23si11930527plo.40.2019.03.27.02.34.45; Wed, 27 Mar 2019 02:35:01 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732380AbfC0JeF (ORCPT + 99 others); Wed, 27 Mar 2019 05:34:05 -0400 Received: from metis.ext.pengutronix.de ([85.220.165.71]:34353 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726237AbfC0JeF (ORCPT ); Wed, 27 Mar 2019 05:34:05 -0400 Received: from kresse.hi.pengutronix.de ([2001:67c:670:100:1d::2a]) by metis.ext.pengutronix.de with esmtp (Exim 4.89) (envelope-from ) id 1h94wX-0005Bg-Da; Wed, 27 Mar 2019 10:33:57 +0100 Message-ID: <1553679236.2561.27.camel@pengutronix.de> Subject: Re: [PATCH 2/2] arm64: dts: imx8qxp: Add EDMA0/EDMA1 nodes From: Lucas Stach To: Daniel Baluta , Aisheng Dong Cc: "mark.rutland@arm.com" , "devicetree@vger.kernel.org" , Peng Fan , "festevam@gmail.com" , Anson Huang , Teo Hall , Daniel Baluta , "s.hauer@pengutronix.de" , "linux-kernel@vger.kernel.org" , "robh+dt@kernel.org" , dl-linux-imx , "kernel@pengutronix.de" , "shawnguo@kernel.org" , "S.j. Wang" , "linux-arm-kernel@lists.infradead.org" Date: Wed, 27 Mar 2019 10:33:56 +0100 In-Reply-To: References: <20190326094239.5910-1-daniel.baluta@nxp.com> <20190326094239.5910-3-daniel.baluta@nxp.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6-1+deb9u1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::2a X-SA-Exim-Mail-From: l.stach@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Daniel, Am Mittwoch, den 27.03.2019, 10:51 +0200 schrieb Daniel Baluta: [...] > > > or > > "fsl,imx8qxp-edma", "fsl,imx8qm-edma"? > > One thing that it is not clear for me is why there are places > where we use two compatible strings? > > I understand the situation where are two distinct drivers, but is there > any other reason to add multiple compatible strings for a node in dts? We use 2 compatible string where there should not be any differences between the IP blocks of this SoC and a version the driver already supports. So if the eDMA driver already supports the software interface for "fsl,imx8qm-edma" and the IP block is compatible with this, we add this to the DT, so the we don't need any driver changes just to support a new SoC. But as you can never be sure if there are subtle differences in the IP block and/or SOC integration when adding the DT support, we also add a more specific compatible to the DT. If it turns out that there are software visible differences, we only need to adapt the driver to check for the more specific compatible to trigger the changed behavior, allowing to keep the DT stable. Regards, Lucas