Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.8\))
Subject: Re: CONFIG_DEBUG_VIRTUAL breaks boot on x86-32
From:   William Kucharski <william.kucharski@oracle.com>
In-Reply-To: <dca61136-db66-a89e-e79d-679ee2281d8d@linux.ee>
Date:   Wed, 27 Mar 2019 04:26:07 -0600
Cc:     Ralph Campbell <rcampbell@nvidia.com>,
        LKML <linux-kernel@vger.kernel.org>, linux-mm@kvack.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <4AF9E4BD-58F0-4D12-A495-6192978790B6@oracle.com>
References: <4d5ee3b0-6d47-a8df-a6b3-54b0fba66ed7@linux.ee>
 <A1B7F481-4BF6-4441-8019-AE088F8A8939@oracle.com>
 <f39477da-a1ef-e31e-a72d-8ea1d5755234@nvidia.com>
 <dca61136-db66-a89e-e79d-679ee2281d8d@linux.ee>
To:     Meelis Roos <mroos@linux.ee>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


The dmesg output you posted confirms that max_low_pfn is indeed 0x373fe, =
and it appears
that the value of phys_mem being checked mat be 0x3f401ff1, which =
translates to pfn 0x3f401,
at least if what's still in registers can be believed.

Since that is indeed greater than max_low_pfn, VIRTUAL_BUG_ON triggers:

    VIRTUAL_BUG_ON((phys_addr >> PAGE_SHIFT) > max_low_pfn);

Looking at the call stack of

    copy_strings_0x220
        __check_object_size+0xef

that looks to translate to this sequence:

copy_from_user(kaddr+offset, str, bytes_to_copy)
    check_copy_size(kaddr+offset, bytes_to_copy, FALSE)
        check_object_size(kaddr+offset, bytes_to_copy, FALSE)
            __check_object_size(kaddr+offset, bytes_to_copy, FALSE)
                check_heap_object(kaddr+offset, bytes_to_copy, FALSE)
                    virt_to_head_page(kaddr+offset)
                        virt_to_page(kaddr+offset)
                            pfn_to_page(kaddr+offset)
                                __pa(kaddr+offset)
                                    __phys_addr(kaddr+offset)

so it appears the address is "too high" for low memory at that point.


                                   =20