Received: by 2002:ac0:bc90:0:0:0:0:0 with SMTP id a16csp5379144img; Wed, 27 Mar 2019 07:29:08 -0700 (PDT) X-Google-Smtp-Source: APXvYqy+69PyMJ0jRJEVVPRhgpNW/nzYTwp1+xLnop5zIE8v7QxEK8cnVaxxpupCVSrLNqG2j0pn X-Received: by 2002:aa7:8c42:: with SMTP id e2mr6353508pfd.24.1553696948777; Wed, 27 Mar 2019 07:29:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553696948; cv=none; d=google.com; s=arc-20160816; b=G/LZM2UR8LiGk5SRTf6k2HrsdOb2vvpkK5RQFYFLNeQ47FgKS5zL4MrESHXIVjk+Eb MIC8PxiOIhKMjK9PjaDL6Eqd6sUbmS5GAZvjSWlzYr1VZI7aBJkKWr7J/m7XbgYqQ3fk Ad8ZUwT11DbpV/JmhrDMrOPEJ1TM2gVxrjukUi9PgOPWmnHnP743o5Dt0XID4kNgLPq6 N8St5/RCcnNZLbt9f/xSCFg91dn1r/tVbmB+cXh7ApgF9GpmD93f/WcDWT6qInjFnhM3 EEkfHTl2B5Sg7ZDzMyW4Bda7Bn8fz3cInM/fb4Z6EN2ct/LXjaCUogQ4+9fE+LHMkjyI UVRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=LfYX3k3FQF6OF3Qi1bKjpjlrDcO2JayAMt0mdRwYOHA=; b=HS4j/DYcReXQJ5tFSPw3gnF1Yr6jaZLTY3+S0ftXCE48ciaJKSOhTZQPtG8rEif6Qk dLf0XamuPYQR7rqDzJKD2sm1DNz3OKaXlgFyhx9V/9QFfImXJ2wpry6RYGHZhMtovZEN qaNJJLxN0BHcbMyYAqw5fshnS9WBfNCpubNSywHlro+1GL1U96GuGvhlgQuX0wzppdz+ AewIDyfAhjwSdtw7VBnAEJ3iq/EzDSFow2RxGnRrg2xpPd1JwRZWxbZ1KMsxtMeyymBV f59q127fV8p+FYZBY5lNakjPAZ8ycFPriQ+rRVkYSINA6vwAGlyc+IM9KxxrwEBy1yEC D6Ww== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h125si754944pgc.290.2019.03.27.07.28.53; Wed, 27 Mar 2019 07:29:08 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728177AbfC0O2I (ORCPT + 99 others); Wed, 27 Mar 2019 10:28:08 -0400 Received: from mx2.suse.de ([195.135.220.15]:48556 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726810AbfC0O2I (ORCPT ); Wed, 27 Mar 2019 10:28:08 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 57295ADC8; Wed, 27 Mar 2019 14:28:07 +0000 (UTC) Received: by unicorn.suse.cz (Postfix, from userid 1000) id F3CB9E1404; Wed, 27 Mar 2019 15:28:06 +0100 (CET) Date: Wed, 27 Mar 2019 15:28:06 +0100 From: Michal Kubecek To: Jiri Pirko Cc: David Miller , netdev@vger.kernel.org, Jakub Kicinski , Andrew Lunn , Florian Fainelli , John Linville , Stephen Hemminger , linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v5 00/22] ethtool netlink interface, part 1 Message-ID: <20190327142806.GT26076@unicorn.suse.cz> References: <20190327130928.GC14297@nanopsycho> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190327130928.GC14297@nanopsycho> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 27, 2019 at 02:09:28PM +0100, Jiri Pirko wrote: > Could you please perhaps split the patchset so it contains max ~15 patches? Would 1-17 still be acceptable? The thing is that patch 16 is the first where some "normal" notification (i.e. not EVENT one) is sent and patch 17 is the first implementation of a request modifying data. I believe having at least one example of both querying and setting data would help the review discussion. Or perhaps I could leave GET_INFO related patches (at least second and third) for later. Michal