Received: by 2002:ac0:bc90:0:0:0:0:0 with SMTP id a16csp5462664img; Wed, 27 Mar 2019 08:58:45 -0700 (PDT) X-Google-Smtp-Source: APXvYqxNEFkrJo0SazFZ9TU72XfeqiNCe2vmxVby5On0+jR9gtmJy7N6OAmHvovxlNWusvjfeEq3 X-Received: by 2002:a17:902:d710:: with SMTP id w16mr36795641ply.198.1553702325843; Wed, 27 Mar 2019 08:58:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553702325; cv=none; d=google.com; s=arc-20160816; b=vgQQ40H3rbktZlPmwge24K2jlb9RXYS1MVcIrfX7ZHAZhLIO1JsDhaHtxT8e6BNIff jnYVznCxRpOUR4U90AriC1jD5AIw8DH0wH8C03w6TgziBCzXergH1P4BrRtHTCw4Od+I gIRro9Y7YFfcWaSKDqHgTyfhf7sgG3AFli0I+9Er7JpEiuFGUv/qDWFcdKpBMkKr8B3T X5QQzZBSV8TkPL9LYgRUzxuS3fCzxyUVbM3WiGHuYr3zRJp0VS1u+D/GglJU1T5e69zR 7FhM7oywsgYS4/+c67O/hAlG+1lwxPwgymEMDXU86FYagXA2RO4/UH3Qhpq9y/So/WRW LNEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date; bh=VcXVyJkFAjPa/mcRfDmEUsYZoBSkgqHzopc04+IlT/o=; b=Cf5z/fX76FW5BqF+AI6wUVS41b81KWNVsYa+byptfSdbpPTKHJks0aMXayAThdXm7o qLktatNktdC59ddeoBcDddskhS6iRVfCUNlgP5QOyVW6zGDWBa4y6PC9W8+ieFBHPssW Rr7GBIOUFS3Qu/ygzFeEPMUGondPPmLC9mZzpeDQYbFTtRmFWViRDR7kIDOMJxby2cxU YMtKpn7wQRlwS3oEE+GCW255/7EO8+tzGSFfsFCwoR2C2lLQ5H4am5KnnM7VHJv9PZ2Q WBZyc8SIFO5fhQIUqyley7xs42FbjaUTq91hQydSRvpQfLwaonFDARr/V2Ge3nug3Yuv LxWA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e5si7627134pls.29.2019.03.27.08.58.30; Wed, 27 Mar 2019 08:58:45 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727405AbfC0P5x (ORCPT + 99 others); Wed, 27 Mar 2019 11:57:53 -0400 Received: from mail.kernel.org ([198.145.29.99]:57876 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726990AbfC0P5w (ORCPT ); Wed, 27 Mar 2019 11:57:52 -0400 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E480420700; Wed, 27 Mar 2019 15:57:50 +0000 (UTC) Date: Wed, 27 Mar 2019 11:57:49 -0400 From: Steven Rostedt To: Matthew Garrett Cc: jmorris@namei.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, dhowells@redhat.com, linux-api@vger.kernel.org, luto@kernel.org, Thomas Gleixner , Matthew Garrett , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org Subject: Re: [PATCH V31 19/25] x86/mmiotrace: Lock down the testmmiotrace module Message-ID: <20190327115749.5770a102@gandalf.local.home> In-Reply-To: <20190326182742.16950-20-matthewgarrett@google.com> References: <20190326182742.16950-1-matthewgarrett@google.com> <20190326182742.16950-20-matthewgarrett@google.com> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 26 Mar 2019 11:27:35 -0700 Matthew Garrett wrote: > From: David Howells > > The testmmiotrace module shouldn't be permitted when the kernel is locked > down as it can be used to arbitrarily read and write MMIO space. This is > a runtime check rather than buildtime in order to allow configurations > where the same kernel may be run in both locked down or permissive modes > depending on local policy. > Acked-by: Steven Rostedt (VMware) I'm curious. Should there be a mode to lockdown the tracefs directory too? As that can expose addresses. -- Steve > Suggested-by: Thomas Gleixner > Signed-off-by: David Howells Signed-off-by: Matthew Garrett > cc: Thomas Gleixner > cc: Steven Rostedt > cc: Ingo Molnar > cc: "H. Peter Anvin" > cc: x86@kernel.org > --- > arch/x86/mm/testmmiotrace.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/x86/mm/testmmiotrace.c b/arch/x86/mm/testmmiotrace.c > index f6ae6830b341..9e8ad665f354 100644 > --- a/arch/x86/mm/testmmiotrace.c > +++ b/arch/x86/mm/testmmiotrace.c > @@ -115,6 +115,9 @@ static int __init init(void) > { > unsigned long size = (read_far) ? (8 << 20) : (16 << 10); > > + if (kernel_is_locked_down("MMIO trace testing", LOCKDOWN_INTEGRITY)) > + return -EPERM; > + > if (mmio_address == 0) { > pr_err("you have to use the module argument mmio_address.\n"); > pr_err("DO NOT LOAD THIS MODULE UNLESS YOU REALLY KNOW WHAT YOU ARE DOING!\n");