Received: by 2002:ac0:bc90:0:0:0:0:0 with SMTP id a16csp5509350img; Wed, 27 Mar 2019 09:46:07 -0700 (PDT) X-Google-Smtp-Source: APXvYqxmJvpPgh/UwA1wLLduiqzyLz9ztRW67jGGwQ4kk/U8uo+S/4ep/whdmKMtwTdMDdu6d0RC X-Received: by 2002:a63:3fc8:: with SMTP id m191mr35195860pga.240.1553705167670; Wed, 27 Mar 2019 09:46:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553705167; cv=none; d=google.com; s=arc-20160816; b=Vp+nknioEPPKRxC+SXuQedbD5+DyepIZr/FTvLSCnZMWeeqYsohY+vsfpUtajslJpA OoJb+I9txLrylvXpfQQr7UHAQJ2nPqrKfhQqnTzMZAYhbUAMUTjpoHOZubudNLQA8cgw mZSr9atyKaQGpk90UH5bt3xCT0ECK4FoopJ3TuF9BVlVmIG73kO7XCDF4ioTgfxZC2Rb ELxlRr52nq5efNN8cyuLu06k06EQrOujDn3QQRwN/xRCepY0AFIhu63c2j+fI45w5ar/ 3HVflpv6SXMq1++y8vxzeSf0dQytdEm3iDrsQobqDGQPpkiNWe9/WfomQ4RZUXHfvR8d TaaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=jGwgbJbaYYN0+1S3SM6oWd4zxRcBxDzrBm7ce1zE9S8=; b=ozepWHHmIEnFgvIE40qrUTgOmr6hx1e2Iyq1KRYhc9epe0VFS31vXB9apUDwo63JzM FduHg5UdyUWu3FTN6vR0IAPiBCbDwuXsJVXTqZN9mlAIM6koIimgDwW8VfEJiO7ZSw8j RSDo+QmKT3bxe1T4tuPu7tOfxPFzPQUW/VSjJJTdEo0trhfkLvoxgfhMjXeGo7AgayHX bAt61wWn78CMAyacXucJulwFEQsOvSBtv3txk9pZecPjITjjRVQO7sC3ozZceUUJFZcl h298iEWL5SKkCHyEbiyaY9GLx0GAPc/uuf/Tc+cxM2TbxgIJp0H7sDQf/btVPytL7IO9 N7Gw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j134si19247111pgc.42.2019.03.27.09.45.51; Wed, 27 Mar 2019 09:46:07 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728787AbfC0Qnx (ORCPT + 99 others); Wed, 27 Mar 2019 12:43:53 -0400 Received: from mga12.intel.com ([192.55.52.136]:62434 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726740AbfC0Qnw (ORCPT ); Wed, 27 Mar 2019 12:43:52 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Mar 2019 09:43:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,277,1549958400"; d="scan'208";a="158912750" Received: from black.fi.intel.com (HELO black.fi.intel.com.) ([10.237.72.28]) by fmsmga001.fm.intel.com with ESMTP; 27 Mar 2019 09:43:48 -0700 From: Heikki Krogerus To: "Rafael J. Wysocki" Cc: Greg Kroah-Hartman , Andy Shevchenko , Chunfeng Yun , Biju Das , Hans de Goede , linux-acpi@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 3/3] usb: typec: mux: Use the "compatible" property instead of a boolean property Date: Wed, 27 Mar 2019 19:43:39 +0300 Message-Id: <20190327164339.31205-4-heikki.krogerus@linux.intel.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190327164339.31205-1-heikki.krogerus@linux.intel.com> References: <20190327164339.31205-1-heikki.krogerus@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Instead of searching for a boolean property, matching against the "compatible" property. Signed-off-by: Heikki Krogerus --- drivers/usb/typec/mux.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/usb/typec/mux.c b/drivers/usb/typec/mux.c index 2ce54f3fc79c..9462b90f1c09 100644 --- a/drivers/usb/typec/mux.c +++ b/drivers/usb/typec/mux.c @@ -32,11 +32,7 @@ static void *typec_switch_match(struct device_connection *con, int ep, return ERR_PTR(-EPROBE_DEFER); } - /* - * With OF graph the mux node must have a boolean device property named - * "orientation-switch". - */ - if (con->id && !fwnode_property_present(con->fwnode, con->id)) + if (con->id && !fwnode_is_compatible(con->fwnode, con->id)) return NULL; list_for_each_entry(sw, &switch_list, entry) @@ -148,7 +144,7 @@ static void *typec_mux_match(struct device_connection *con, int ep, void *data) /* Accessory Mode muxes */ if (!desc) { - match = fwnode_property_present(con->fwnode, "accessory"); + match = fwnode_is_compatible(con->fwnode, "accessory"); if (match) goto find_mux; return NULL; -- 2.20.1