Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 27 Mar 2019 16:49:14 +0000
From:   Stefan Hajnoczi <stefanha@redhat.com>
To:     Vitaly Mayatskikh <v.mayatskih@gmail.com>
Cc:     Michal Hocko <mhocko@suse.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] vhost: zero vhost_vsock memory on allocation
Message-ID: <20190327164914.GE27283@stefanha-x1.localdomain>
References: <1553648174-24913-1-git-send-email-v.mayatskih@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
        protocol="application/pgp-signature"; boundary="GxcwvYAGnODwn7V8"
Content-Disposition: inline
In-Reply-To: <1553648174-24913-1-git-send-email-v.mayatskih@gmail.com>
User-Agent: Mutt/1.11.3 (2019-02-01)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--GxcwvYAGnODwn7V8
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Mar 26, 2019 at 08:56:14PM -0400, Vitaly Mayatskikh wrote:
> This fixes OOPS when using under-initialized vhost_vsock object.
>=20
> The code had a combo of kzalloc plus vmalloc as a fallback
> initially, but it has been replaced by plain kvmalloc in
> commit 6c5ab6511f71 ("mm: support __GFP_REPEAT in kvmalloc_node for >32kB=
")
>=20
> OOPS is easy to reproduce with open/ioctl after trashing the RAM.

Which field was accessed before initialization?

I ask because the situation is now unclear since code remains that
assumes vsock is *not* zero-initialized:

  vsock->guest_cid =3D 0; /* no CID assigned yet */

  atomic_set(&vsock->queued_replies, 0);

If we're going to zalloc, let's get rid of explicit zero
initializations.  Or let's use kvmalloc() and fix the uninitialized
access.  Mixing both is confusing.

> Signed-off-by: Vitaly Mayatskikh <v.mayatskih@gmail.com>
> ---
>  drivers/vhost/vsock.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/vhost/vsock.c b/drivers/vhost/vsock.c
> index bb5fc0e..9e7cb13 100644
> --- a/drivers/vhost/vsock.c
> +++ b/drivers/vhost/vsock.c
> @@ -512,7 +512,7 @@ static int vhost_vsock_dev_open(struct inode *inode, =
struct file *file)
>  	/* This struct is large and allocation could fail, fall back to vmalloc
>  	 * if there is no other way.
>  	 */
> -	vsock =3D kvmalloc(sizeof(*vsock), GFP_KERNEL | __GFP_RETRY_MAYFAIL);
> +	vsock =3D kvzalloc(sizeof(*vsock), GFP_KERNEL | __GFP_RETRY_MAYFAIL);
>  	if (!vsock)
>  		return -ENOMEM;
> =20
> --=20
> 1.8.3.1
>=20

--GxcwvYAGnODwn7V8
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEcBAEBAgAGBQJcm6mKAAoJEJykq7OBq3PIfCIH/1ZudXBDTe+lVpYHGgiheqDK
TxlZYvjeRdWRIPv02vngsUXSAfpS1Wb9BopaE2m47TTQBzIYJ51bvQPXRim2cGmf
Y2O5DuRl3KggOCcelmzQjsJLnjY6fOgeSJrCBltVNGPLOhk1CXBywX99mvk1YHYS
1hKjZQMANQZcSv8gWypVxUEzC1XZVHL1+tSVMhumTEmCeMcouGMMWhC8XZuN05A+
+wxiPCFNeH1EWSokvBVKjUPJnvaauENO4Qk4/YSzk7TERsYTv3pH0b1UbWJ/K4Sm
FUodfBPJWkQknZpenbwduaA+/RQ+HxCrEGeor+87l8QFtzFHiaZ+EKuxgFyTWiw=
=a8tB
-----END PGP SIGNATURE-----

--GxcwvYAGnODwn7V8--