Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] net: ieee802154: fix missing checks for
 regmap_update_bits
To:     Kangjie Lu <kjlu@umn.edu>
Cc:     pakki001@umn.edu, Xue Liu <liuxuenetmail@gmail.com>,
        Alexander Aring <alex.aring@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        linux-wpan@vger.kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20190324231856.2664-1-kjlu@umn.edu>
From:   Stefan Schmidt <stefan@datenfreihafen.org>
Message-ID: <bc46d1b9-92eb-e1b7-aca6-28a743c59194@datenfreihafen.org>
Date:   Thu, 28 Mar 2019 02:15:38 +0900
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.4.0
MIME-Version: 1.0
In-Reply-To: <20190324231856.2664-1-kjlu@umn.edu>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hello.

On 25.03.19 08:18, Kangjie Lu wrote:
> regmap_update_bits could fail and deserves a check.
> 
> The patch adds the checks and if it fails, returns its error
> code upstream.
> 
> Signed-off-by: Kangjie Lu <kjlu@umn.edu>
> ---
>  drivers/net/ieee802154/mcr20a.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/net/ieee802154/mcr20a.c b/drivers/net/ieee802154/mcr20a.c
> index c589f5ae75bb..8bb53ec8d9cf 100644
> --- a/drivers/net/ieee802154/mcr20a.c
> +++ b/drivers/net/ieee802154/mcr20a.c
> @@ -533,6 +533,8 @@ mcr20a_start(struct ieee802154_hw *hw)
>  	dev_dbg(printdev(lp), "no slotted operation\n");
>  	ret = regmap_update_bits(lp->regmap_dar, DAR_PHY_CTRL1,
>  				 DAR_PHY_CTRL1_SLOTTED, 0x0);
> +	if (ret < 0)
> +		return ret;
>  
>  	/* enable irq */
>  	enable_irq(lp->spi->irq);
> @@ -540,11 +542,15 @@ mcr20a_start(struct ieee802154_hw *hw)
>  	/* Unmask SEQ interrupt */
>  	ret = regmap_update_bits(lp->regmap_dar, DAR_PHY_CTRL2,
>  				 DAR_PHY_CTRL2_SEQMSK, 0x0);
> +	if (ret < 0)
> +		return ret;
>  
>  	/* Start the RX sequence */
>  	dev_dbg(printdev(lp), "start the RX sequence\n");
>  	ret = regmap_update_bits(lp->regmap_dar, DAR_PHY_CTRL1,
>  				 DAR_PHY_CTRL1_XCVSEQ_MASK, MCR20A_XCVSEQ_RX);
> +	if (ret < 0)
> +		return ret;
>  
>  	return 0;
>  }
> 

This patch has been applied to the wpan tree and will be
part of the next pull request to net. Thanks!

regards
Stefan Schmidt