Received: by 2002:ac0:bc90:0:0:0:0:0 with SMTP id a16csp5561509img; Wed, 27 Mar 2019 10:43:34 -0700 (PDT) X-Google-Smtp-Source: APXvYqyF+Sn4es7kgmQL/jc+FEPHDUKwmKA33+14rYl3bnQxVzK4eqhTX0dLOFu+djywssQAbC0i X-Received: by 2002:a17:902:8d8b:: with SMTP id v11mr38890543plo.241.1553708614088; Wed, 27 Mar 2019 10:43:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553708614; cv=none; d=google.com; s=arc-20160816; b=WUfsQzbIxF8LePZs8VQ1t0yo4+GUt1KxtMtrfGsLfoKQ2CclZbiKSXF8KTGZ7qp92y hilxbhJ2HViraDlgM6DmZkArXBcs+aEGAAdk2lCTdoZtEz31WyuQ1K0Ujb/Z9IIMvcx8 STTMMjmBUBMVQOHgw1qQQV+YUkoU+vcb0DexeVGzqMOlQM65R9lgwHv2u+ddpAGUV+xc gxeBiq+9LvJZU9H0FGzuGJC/FYpjX0+tJy/xjkWSSJohwPyMh/aDM5Oihxd+EzHEtAbn Cy6oucidb7EG8/D6sqIgcouqodx1MxI5TQJIhLxNrhnzKcntuqqcjirCoJ9s0TA6Fm6h vGhw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=ZhukHlxTtepUFFhI/+26fbuf2j8cU5UZH4qojDumCm8=; b=xWjDhRNUQLk3wFeItJMTcO+zGIFP2aoAwYXWOeAb40yeB1X2seC323Yk7qOj7RCCw9 zDITlw9P1Ejec3PGBbEQ6P6WevspAGGG8NdbR74POHYIl9w7WY5VMqul5XbhsL92LlLA KIlN0VqBqTdT8Ao3/mUD9Q0Q5ib46PGNwrCbz2XAgfQ2IGoqAAWUo/Kd+HR18djaBQbD kN34Kcov590QEeyjio/IsodoBay+c2K/50fMAg9mrjvqfRm5yqFwM6x/d/ExGM3nQlXG 6M6ownL8UXeSmZBcgl6NfygBF3k2NPW7SLYfX5Nyi8ZHaTOxfQEW94UGdIsUjbkxxDB7 MG5g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=DU07es9H; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e65si18976234pfa.80.2019.03.27.10.43.18; Wed, 27 Mar 2019 10:43:34 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=DU07es9H; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728095AbfC0Rmc (ORCPT + 99 others); Wed, 27 Mar 2019 13:42:32 -0400 Received: from mail-io1-f67.google.com ([209.85.166.67]:40070 "EHLO mail-io1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727484AbfC0Rmb (ORCPT ); Wed, 27 Mar 2019 13:42:31 -0400 Received: by mail-io1-f67.google.com with SMTP id d201so14821643iof.7 for ; Wed, 27 Mar 2019 10:42:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ZhukHlxTtepUFFhI/+26fbuf2j8cU5UZH4qojDumCm8=; b=DU07es9HQmzjwQmyT6PpW6qRheFryy6e6kYKUbOlvFqL1ZnPDmPMVkJeRoR6B8bMgR wcW90pKlyUCiJRtehGdXcfOeIDOzYu+4+UJj+HeomyQfhAQzAfMRVwKTuotfhm3SCUWJ yr3yK8O0qEC5sXq/u0uYzd7t/lKIF0fQ7Lr0OBwc6aL6pJ8gQwLmZM/1lOudKWqr8glo a5rGkA7lvGOcnf9YvecTZ83meM0IXyZRwtZZjAR4ahZ0UgCtVNA9I87b7J5qDBCm3aXM SGzY4+JqgkngjOcU6SCupd5cJwpinUlOcPpVYjDUXz+apuFwM3g7QUKyzz7ZoS8PtERm 0eCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ZhukHlxTtepUFFhI/+26fbuf2j8cU5UZH4qojDumCm8=; b=RZXAdTXRN0TaYAYAzk4v10dKTY1BADIBb0g72giIlnYW9906AmWh5P0B21tqjjjNnh a8YaTxDwHL+x8GZcTowUcWH5Q8Cj92foEb+RhZWqCno77KKtLd7/wk/8XblyA1CpYAz2 iG6Y+SmYksRU8b8a3uk0+GYa0kQjJMSCdCN2HOUWMFiClY4FdYLnNsp57pogBom0NdrV 6BFX8WG6450y5TWVtvw1137MulAy9aMoQvmdd1Qa+7PrFb9R8EJvUvwFSVin9NiQeNhH 8oz6DpbqpMVBWwm3JpEI1VIomHAmUcSYRpNfB+zXSoeu3Q4qjBlw7kuHaROZbokc/Ek8 nYkw== X-Gm-Message-State: APjAAAWpItrzHhtVsZ3xShn6EcNPAw2py1GJDEr09wLtajAiTqr8Ta/g EN70nYwdKTfli1zwORvoXuSE/U8n+3zRAMdAfx5iNw== X-Received: by 2002:a6b:e509:: with SMTP id y9mr26200848ioc.169.1553708550687; Wed, 27 Mar 2019 10:42:30 -0700 (PDT) MIME-Version: 1.0 References: <20190326182742.16950-1-matthewgarrett@google.com> <20190326182742.16950-26-matthewgarrett@google.com> <20190327003057.GA27311@kroah.com> <20190327050615.GA548@kroah.com> <16124107-70D3-4CA0-9766-36FC6DC10128@amacapital.net> <20190327053342.GA17484@kroah.com> In-Reply-To: From: Matthew Garrett Date: Wed, 27 Mar 2019 10:42:18 -0700 Message-ID: Subject: Re: [PATCH V31 25/25] debugfs: Disable open() when kernel is locked down To: Andy Lutomirski Cc: Greg KH , James Morris , LSM List , LKML , David Howells , Linux API Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 27, 2019 at 10:40 AM Andy Lutomirski wrote: > As far as I'm concerned, preventing root from crashing the system > should not be a design goal of lockdown at all. And I think that the > "integrity" mode should be as non-annoying as possible, so I think we > should allow reading from debugfs. I have no horse in this game - I'm happy to bring back the previous approach for integrity mode and block reads entirely in confidentiality mode, but I'd rather not spend another release cycle arguing about it.