Received: by 2002:ac0:bc90:0:0:0:0:0 with SMTP id a16csp5578812img; Wed, 27 Mar 2019 11:03:45 -0700 (PDT) X-Google-Smtp-Source: APXvYqyaklARCQmpVKPzKWEBCsEeDKct4Tmgf1/9XZktjGgru6iCB4SzgJdAloyTueTFnVPTsT+H X-Received: by 2002:a17:902:2ac3:: with SMTP id j61mr38123513plb.112.1553709824975; Wed, 27 Mar 2019 11:03:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553709824; cv=none; d=google.com; s=arc-20160816; b=CVUkZ09WEVrE/tcTwgeCR7D2zjToi/p2WevTO9AR0HMrZ034sxUvgrvFtERSI2Hzoo zYMP0A1VkZScLfLS5ViOkaJU8iN8safJk9IqMtCpPoiQOxI1Nud9lvkp/GTEDE0cz+4q 1wpt9nL3Bw8ZemvjEoca6u2EmVE4IGwMXxKYBBw7sXIlVYkTfr+GDzCv8v5k1+GyQEjO 5pTnW/1N3E54x4l0J/qHUq+vzcp2BotULGSVwjnSd52llOOlqOV4283PlxF0XHGo0bM7 8f7Gj78GpcDBk1VOdpXg2zSlSoS+ur1uXOPCYpL9Zr0rSTgSeNSujVQ19qLJX/O+4aBr +mtg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Ak8okAEhzUfvcPv6gdd+11+S3UkRUnWwbr2z3FN33JI=; b=fYnl1ngJ6OXUNb+8zXLDtSi6iPXTQ8Spw87l8+3wwfO55+g1k1r2fR6AoT2QA3vH4z R7+v9Pcr7T3gYcx2SvAMqQwpQ81jPpLE0wCcCuJpqZ0gRJrfuz+PHqI6p9o5bKd6dTOg MNOyatBVvVYJl6SeD8oPNs9NsUwqpzYNQpoeUe6Y5LXl66J3e5RkOxIx8ihrH0SzIOPx vsyJq11lsG/1T+ETYqM1M95D+ggueB8mvNsGRiCobN5Pu072END3ovMCK3lgp/2RAECV KII1QH29IwIxWeEh82UghRtk8c+3GVVVeNM5CJNXp68CZVHp5aT337BSAhK9VusQyxoj f+Fw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=0+qhOEuK; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n25si18598683pgv.283.2019.03.27.11.03.29; Wed, 27 Mar 2019 11:03:44 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=0+qhOEuK; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730921AbfC0SCf (ORCPT + 99 others); Wed, 27 Mar 2019 14:02:35 -0400 Received: from mail.kernel.org ([198.145.29.99]:42444 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730845AbfC0SCc (ORCPT ); Wed, 27 Mar 2019 14:02:32 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2CCB221738; Wed, 27 Mar 2019 18:02:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553709752; bh=cHJOiQebblPNrctsB3rNVnuc4hMWpXEqbAdB8RDvLQg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=0+qhOEuKxe42Yc70i0H6Br06Hu6JvHrxBxNhIALsMRVW6o+vU8HHPrYjsbqWGS44L Uv5y2jHOCxbZ2TMuXL3mFf3edcBAVFcj/YWekianrYEflx8v6AxY4MWG5h+5gRNKsy vhc7DqIo9dL3yfG0e3bTJ7rPQu+E2rBeoe2axUs4= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Luc Van Oostenryck , Jens Axboe , Thomas Gleixner , Andrew Morton , Linus Torvalds , Sasha Levin Subject: [PATCH AUTOSEL 5.0 019/262] include/linux/relay.h: fix percpu annotation in struct rchan Date: Wed, 27 Mar 2019 13:57:54 -0400 Message-Id: <20190327180158.10245-19-sashal@kernel.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190327180158.10245-1-sashal@kernel.org> References: <20190327180158.10245-1-sashal@kernel.org> MIME-Version: 1.0 X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Luc Van Oostenryck [ Upstream commit 62461ac2e5b6520b6d65fc6d7d7b4b8df4b848d8 ] The percpu member of this structure is declared as: struct ... ** __percpu member; So its type is: __percpu pointer to pointer to struct ... But looking at how it's used, its type should be: pointer to __percpu pointer to struct ... and it should thus be declared as: struct ... * __percpu *member; So fix the placement of '__percpu' in the definition of this structures. This silents a few Sparse's warnings like: warning: incorrect type in initializer (different address spaces) expected void const [noderef] *__vpp_verify got struct sched_domain ** Link: http://lkml.kernel.org/r/20190118144902.79065-1-luc.vanoostenryck@gmail.com Fixes: 017c59c042d01 ("relay: Use per CPU constructs for the relay channel buffer pointers") Signed-off-by: Luc Van Oostenryck Cc: Jens Axboe Cc: Thomas Gleixner Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds Signed-off-by: Sasha Levin --- include/linux/relay.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/relay.h b/include/linux/relay.h index e1bdf01a86e2..c759f96e39c1 100644 --- a/include/linux/relay.h +++ b/include/linux/relay.h @@ -66,7 +66,7 @@ struct rchan struct kref kref; /* channel refcount */ void *private_data; /* for user-defined data */ size_t last_toobig; /* tried to log event > subbuf size */ - struct rchan_buf ** __percpu buf; /* per-cpu channel buffers */ + struct rchan_buf * __percpu *buf; /* per-cpu channel buffers */ int is_global; /* One global buffer ? */ struct list_head list; /* for channel list */ struct dentry *parent; /* parent dentry passed to open */ -- 2.19.1