Received: by 2002:ac0:bc90:0:0:0:0:0 with SMTP id a16csp5600772img; Wed, 27 Mar 2019 11:28:13 -0700 (PDT) X-Google-Smtp-Source: APXvYqzCPgyWb+vmE2tGqAekM3SHrR6jKzfQv2DGCYPPLiDr6gNG95LyYfh9wQzJz2/x6AzTtbIq X-Received: by 2002:a62:4351:: with SMTP id q78mr23800369pfa.86.1553711293783; Wed, 27 Mar 2019 11:28:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553711293; cv=none; d=google.com; s=arc-20160816; b=oXzQxfpfltYcZLab8gsUBFQNOAGQhsf1WvKADvSQ7cPElupI0Uj/nxY8Rkc79lnGps TgUS+uyYKaeZHN0XfFcIAeg7aVMihly7ulEGllpR6EAyV/JBZOqOOxQsBDR4wkr8RmMT FeavtWjrB1VfS1Nh8EVQYApr6pIMwvg5pWTUkD+kekHD4IsIDEO9au2vA5V0EgceRdrX 5O6fu/fjNKTLhBoyQr9BhBK2VD6F0qMbY8mknZpJwACJQsXEh+/glsVDPTkqI0Y8g/IB cF6J3ib25vPyemu0eG/eSxGw0eXb5pz8c/HN17OpZz6Z0T003ybRBPgGDY1bymWr/BF6 37sA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=dWjnnx/fjvMOGeKcOdso1gzJaNrQfy1/GfmSX2qlf+4=; b=Ei7WlL60HZJb/frD1yTlMYp4Gy0lssYoAJMtUWMxgTpPRHlMsEqLcqV5BKMUkpI93Q m8IwvVoj59sIf2iZ3W/kUXkF70Oru1gh4/bb7cVdW2Gtp3DD5iT44UqJt1twHe+WuhgA X26p1lCIDLFfl+8jrwK2kRKwu4OrLtmO1aELi0N7yxkn0dxt88JPuFNEYzkCcB0AarIU zKV9TZxc1biPpfCqc6S2/ytsQnNjmekkuhE/Yoi64nfU1YxaW90vSs+7Rgx8kuoYHn8A 9r5Yihtv6O+v8uHbkSe+ilqGab/3AtuL7IhyUr4SPtI2U4XNHgZ93JyYVbkfvmFZvJek mOKg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=vGd14K9Q; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i38si20364429plb.194.2019.03.27.11.27.58; Wed, 27 Mar 2019 11:28:13 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=vGd14K9Q; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391806AbfC0S1S (ORCPT + 99 others); Wed, 27 Mar 2019 14:27:18 -0400 Received: from mail.kernel.org ([198.145.29.99]:46560 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391749AbfC0S0n (ORCPT ); Wed, 27 Mar 2019 14:26:43 -0400 Received: from localhost (unknown [88.128.80.233]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C168020651; Wed, 27 Mar 2019 18:26:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553711203; bh=ZxG7biS6bXpKRpflwMEfW1R/XgZKXgkCqbd68fspG9s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=vGd14K9QvbqXhFP1weU0vh3ot6pYxUaKGdbcFoDjWbSDUPI2aCVOk5JY0rNlSHuqn gTFeQ/VVLrDn1pQ2FzJobtKLgoJDuMiDYZAFd1PPKgoXQg3ZMMZm931hIXsXXe45j3 5p/edlfW9HNaLFJj1x7VS5bbIHLWxklhl4hdSaz4= Date: Thu, 28 Mar 2019 00:02:04 +0900 From: Greg Kroah-Hartman To: Mathieu Malaterre Cc: trivial@kernel.org, Sarah Sharp , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] USB/xHCI: Remove returned value 'status' since never used Message-ID: <20190327150204.GA22617@kroah.com> References: <20190326201557.20388-1-malat@debian.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190326201557.20388-1-malat@debian.org> User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 26, 2019 at 09:15:57PM +0100, Mathieu Malaterre wrote: > The returned value in status has never been used since > commit 4296c70a5ec3 ("USB/xHCI: Enable USB 3.0 hub remote wakeup.") > So remove 'status' completely. > > Remove warning (W=1): > > drivers/usb/core/hub.c:3671:8: warning: variable 'status' set but not used [-Wunused-but-set-variable] > > Cc: Sarah Sharp > Signed-off-by: Mathieu Malaterre > --- > drivers/usb/core/hub.c | 13 ++++++------- > 1 file changed, 6 insertions(+), 7 deletions(-) Why do you have xhci in your subject line? Shouldn't it be "USB: hub:"? Please fix up, thanks. greg k-h