Received: by 2002:ac0:bc90:0:0:0:0:0 with SMTP id a16csp5601982img; Wed, 27 Mar 2019 11:29:47 -0700 (PDT) X-Google-Smtp-Source: APXvYqxYPE4AyCM/hoNrjP3W1vjV/fJdQZmizRbAhPK+i5GivmrixM+yLE4g0XJK35qP4jJxMS+e X-Received: by 2002:a65:64d5:: with SMTP id t21mr34958085pgv.266.1553711387843; Wed, 27 Mar 2019 11:29:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553711387; cv=none; d=google.com; s=arc-20160816; b=JzfLCmEhJzptQcQqeMoJP8D7FMqXP1bQVkSTcUz2klpEj198k4s0aapfAWbECqT+0R U2iQOY8dkdZ8OVB1z05NV+xCPK7EJ5ZDXsf2QdRtZUdNZkcJ2Y5vGaQEt/GUeWNiY1ID eCPco6epYUHxRJt/+TjNzFtJ8IqOkTlixWwVtxDkgEghQoyRIWF8E++8Mp3km+YW1GXi JChlDDnvp7PUSbtbs0stZ2Vl9HymsM2iefPiDzc4ySec34zAylI5wWVMQU8hk/3PRuMC NXpOJ16znwzaiHZ1tfcXKbMbmpVhJd/xtozCLYj98dfzGsfDzDS818AcK0lQ4FaOuNbP GO9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=pTG9qk2V5Nd8Yv/SabhEbP+M9n0q9g8nr46QjXLJrvg=; b=wUbUxmXrQx41x9hOuNx/sPKHKMUp3pPWAhxQSf5NA8OB6yJsyT1uNt8dI8nMSVepkH pICwdAQMGr/J9pn5LYNXsL4c4B0QXz/5WU2GfeI14Ebm+Ij5cwXxqA5bxSbuqJPTTztE a/auHmGn/vxbPUX/JM5sQPI+dXJSJxf8oUcgxecXpVcXJdO5adpRb6qbYAPHB0C+uPr8 Sx99z2604khiTGeBlxpjFKX3lFr44Rlr3iY+m30zYmPk+vw9rIAErePAfptDkormXrQ4 DpI3CFsYSJuQc4v2TazW9GxcyhimWBtzStJYhDMbt/NKngcSc7G1ijTXyrfCTZ7++aQH RUIA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="U+nuM/P9"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 32si19687111plb.278.2019.03.27.11.29.32; Wed, 27 Mar 2019 11:29:47 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="U+nuM/P9"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391904AbfC0S2g (ORCPT + 99 others); Wed, 27 Mar 2019 14:28:36 -0400 Received: from mail.kernel.org ([198.145.29.99]:48588 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391236AbfC0S2d (ORCPT ); Wed, 27 Mar 2019 14:28:33 -0400 Received: from localhost (unknown [88.128.80.233]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2F6A420651; Wed, 27 Mar 2019 18:28:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553711312; bh=pTG9qk2V5Nd8Yv/SabhEbP+M9n0q9g8nr46QjXLJrvg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=U+nuM/P9KnPJaAMrrUFhcgVzxMIGn3beynPQlB1SCJScypmlJU3yZE8/6qKVLcInD /UDG0MkKWbMxjjH4yqSB4wp4pHDyQeMurOvFfEXnedHOOF5677FQBe3I6wUuLcIZCK gqoDgNfKnFFwkDx/8TvjkgEqQCYzc7eOi9+aOQCs= Date: Thu, 28 Mar 2019 01:38:31 +0900 From: Greg KH To: Morris Ku Cc: lkml@metux.net, morris_ku@sunix.com, linux-kernel@vger.kernel.org, arnd@arndb.de Subject: Re: [PATCH] Respond:add support for SUNIX Multi-I/O board Message-ID: <20190327163831.GB11712@kroah.com> References: <20190315101059.25096-1-saumah@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190315101059.25096-1-saumah@gmail.com> User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 15, 2019 at 06:10:59PM +0800, Morris Ku wrote: > +driver support maximum 4 boards can be installed incombination > +(up to 32 serial port and 2 parallel port) > + > +And do we really need a global list of them ? (instead of just having > +all per-board / per-port data in a per-board / per-port driver instance) > + > + > i prefer to keep current format. No, this needs to be fixed, you can not use static arrays anymore for stuff like this. greg k-h