Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 27 Mar 2019 11:29:23 -0700 (PDT)
Message-Id: <20190327.112923.2284635623125598604.davem@davemloft.net>
To:     Kavyasree.Kotagiri@microchip.com
Cc:     andrew@lunn.ch, f.fainelli@gmail.com, hkallweit1@gmail.com,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        quentin.schulz@bootlin.com
Subject: Re: [PATCH v1 1/2] net: phy: mscc: add support for VSC8514 PHY
From:   David Miller <davem@davemloft.net>
In-Reply-To: <20190327095553.6234-1-kavyasree.kotagiri@microchip.com>
References: <20190327095553.6234-1-kavyasree.kotagiri@microchip.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

From: <Kavyasree.Kotagiri@microchip.com>
Date: Wed, 27 Mar 2019 09:56:13 +0000

> +static u32 vsc85xx_csr_ctrl_phy_read(struct phy_device *phydev,
> +				     u32 target, u32 reg)
> +{
> +	u32 val, val_l, val_h;
> +	unsigned long deadline;

Please order local variable declarations from longest to shortest
line, ie. reverse christmas tree.

> +static int vsc8514_config_init(struct phy_device *phydev)
> +{
> +	int ret, i;
> +	u16 val, addr;
> +	u32 reg;
> +	unsigned long deadline;
> +	struct vsc8531_private *vsc8531 = phydev->priv;

Likewise.