Received: by 2002:ac0:bc90:0:0:0:0:0 with SMTP id a16csp5603318img; Wed, 27 Mar 2019 11:31:16 -0700 (PDT) X-Google-Smtp-Source: APXvYqzsmsUKQOleN0nmVmIUcBJWxQ/vlDh3LISp51unEdsrGTcSET1iTfmeqNBH8OMbx+qrxwce X-Received: by 2002:a17:902:2927:: with SMTP id g36mr10434349plb.57.1553711476071; Wed, 27 Mar 2019 11:31:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553711476; cv=none; d=google.com; s=arc-20160816; b=Dg3iLolKQho2vpiCvWgwGEUcoc5DhP31N1jwPSyfhbXJKAxoY+UupJ+afyh9EKPE76 HrYqk41nvV5asYh3aO1HAoeumVbDGuYGhCublFztDNmNI2zr50hx14uKyKfBW3MFNrv6 8euN3Z4RkhOi93g/fTMDUAsrPacZPxtS43w8WT+FHj7wQMwimY8+WwxpQ1yntt48VkMW Klb8OIAhKzJRuTcjPM/3xmZtlPzOHcTEnimaGI6Coevu6kGp2nLb38nVFRpI2e6mf90a W1v2o4d6xbn9S0YULZlopiJsnuVdexibh0b+k/O9drJvpI2WBaGsJWTu20mh2xvCr7Fv 5BWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=6m7SAYAt2uZ9j+CY01mSl8GX1g0A+QykqZm2GJm4gEI=; b=wVEvA+3ALnVmIhgMROk90f2kcbGu+eMa/BeeBv4qCDYc8XEEEI60SXeogebqmxUK9y nti85sJ/8EnzXoc75rgFW+g0g6U92/S/lHJUt9TrQLI2ECzOkNRLQWQVEtHbtxmx9Rvb onIl+xne0aQ1Vt13hMyGylgIFZzroCAMKPFN+LD7bLZAhPD5N0B9abWlBQHFbAm0MRvf UeP5JnWZ2idI8Y4idsy9uusuo48SllK0ri/mT7E2JHEfghi4n/HUJG27tChv34KxwbWF 22CatXfck3FEeH/owfKM8Q70Ik9E+zvzoyInH5cFq7Dr/QlQ+DpTPIBYsZr5ytZV7XGB dm9Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=RU+UnlNJ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m5si18780151plt.12.2019.03.27.11.31.00; Wed, 27 Mar 2019 11:31:16 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=RU+UnlNJ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391835AbfC0S3r (ORCPT + 99 others); Wed, 27 Mar 2019 14:29:47 -0400 Received: from mail.kernel.org ([198.145.29.99]:50656 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404065AbfC0S3q (ORCPT ); Wed, 27 Mar 2019 14:29:46 -0400 Received: from localhost (unknown [88.128.80.233]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 038602177E; Wed, 27 Mar 2019 18:29:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553711385; bh=m9gATZnVYhH/fEiBV9NZqrCcBRrJT6ChP5qNC07drvI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RU+UnlNJWw2WOHWMBreX0j06GKIazrSwSvQBTCrmd8Yj0cQr9Sp/fI/wdFqIBB7wX Ie9iYd/06pUIHBS/auUghCpFMVHrDMuE4+gt8u5H72a56Hu/LGn7Z96ZMl54LoxSAi VcnJItog4ZAu+vpvxdzsb9hXDe5CPAtdtKURfmQI= Date: Thu, 28 Mar 2019 02:10:29 +0900 From: Greg KH To: Bo YU Cc: arnd@arndb.de, linux-kernel@vger.kernel.org, yuzibode@126.com Subject: Re: [PATCH] misc/fastrpc: add checked value for dma_set_mask Message-ID: <20190327171029.GA13738@kroah.com> References: <20190319020519.15209-1-tsu.yubo@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190319020519.15209-1-tsu.yubo@gmail.com> User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 18, 2019 at 10:05:19PM -0400, Bo YU wrote: > There be should check return value from dma_set_mask to throw some infos > if fail to set dma mask. > > Detected by CoverityScan, CID# 1443983: Error handling issues (CHECKED_RETURN) > > Fixes:f6f9279f2bf0 (misc: fastrpc: Add Qualcomm fastrpc basic driver model) > Signed-off-by: Bo YU > --- > drivers/misc/fastrpc.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) This patch no longer applies to my tree due to other fastrpc fixes being sent before your patch :( Please rebase and resend. thanks, greg k-h