Received: by 2002:ac0:bc90:0:0:0:0:0 with SMTP id a16csp5645627img; Wed, 27 Mar 2019 12:20:53 -0700 (PDT) X-Google-Smtp-Source: APXvYqzTX2LbW/ZtWzGwKVdndrpnwEBwb+BMqnx5z1F+FoofFOosn8XULvErorbMm+eUVWkYURDl X-Received: by 2002:a63:e845:: with SMTP id a5mr35662484pgk.246.1553714453537; Wed, 27 Mar 2019 12:20:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553714453; cv=none; d=google.com; s=arc-20160816; b=iR8Q992qj/iLmbbMqNauTdAUDWmsveJT8CCnuFZvCaGqq6oMksg3asBIS9JSRNB/Rd qKkCclbdH4lNckn75mZOa6wQ335uTfnZkIxpR5+VPZMlrM6MAUSI4fVJn7T113Cl5qjM g4awFxKdmrO2I+bkpSd+mZZpPRU7MVQ0x5zipGYb5BZc69mrGa9tFyUDyolhO6tGlmxi bZRN20oxse+njCJuicqupnvw4f9A26ENc3qTDeuzBsnh/RV3tx1GykHKv2ICRPV/VSwm aIuyudU/t19xj6zJb+DRl1zLidapqfINFZ2HhQCj37BHxkpBWNinO1Tj91rw54tKWcHz uRzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :message-id:in-reply-to:subject:cc:to:from:date; bh=EZju6LBvahJ5xTte1kDjwXu6ti+rfd8Mhkju3GQkpRU=; b=aSVhbv0zw/v/0zpcBiaNqQIotBLMw7Xwyc3pG4p2K5q7lx0xS74fs0oDbpk+VQ9Z6X HPuwVPEfOI3hP5hjxmuZcyt+lsrf8rTgqu9xvlgky72a5xZIqjcIv3EM9fMhzMJ2Bhxk IkUYNWYEWusAH56C6S1OcZe0c0ePuoO6NeTfWqOIQrrl3kbc6F43bznGyV4Ccgo1GB7v +PD7HlgarSpV1peZrymV95yhameOSKsSU8gDLK1TYBgQS86VmbkEwlrgDSDDsyp55VVO 1b+kh+UwNWCHx+mmrN//0DI9ukNPKlaCwltDzDmpKHVN7RBaL+Ku2B2Nl1RLQqgmgvnz tXIA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 31si20072961plg.364.2019.03.27.12.20.38; Wed, 27 Mar 2019 12:20:53 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388447AbfC0TUE (ORCPT + 99 others); Wed, 27 Mar 2019 15:20:04 -0400 Received: from Galois.linutronix.de ([146.0.238.70]:51586 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388208AbfC0TUD (ORCPT ); Wed, 27 Mar 2019 15:20:03 -0400 Received: from p5492e2fc.dip0.t-ipconnect.de ([84.146.226.252] helo=nanos) by Galois.linutronix.de with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1h9E5e-0007cz-0l; Wed, 27 Mar 2019 20:19:58 +0100 Date: Wed, 27 Mar 2019 20:19:57 +0100 (CET) From: Thomas Gleixner To: "Ghannam, Yazen" cc: "linux-edac@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "bp@suse.de" , "tony.luck@intel.com" , "x86@kernel.org" , "rafal@milecki.pl" , "clemej@gmail.com" Subject: Re: [PATCH v4 2/2] x86/MCE/AMD: Don't report L1 BTB MCA errors on some Family 17h models In-Reply-To: <20190325163410.171021-2-Yazen.Ghannam@amd.com> Message-ID: References: <20190325163410.171021-1-Yazen.Ghannam@amd.com> <20190325163410.171021-2-Yazen.Ghannam@amd.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 25 Mar 2019, Ghannam, Yazen wrote: > From: Yazen Ghannam > > AMD Family 17h Models 10h-2Fh may report a high number of L1 BTB MCA > errors under certain conditions. The errors are benign and can safely be > ignored. However, the high error rate may cause the MCA threshold > counter to overflow causing a high rate of thresholding interrupts. In > addition, users may see the errors reported through the AMD MCE decoder > module, even with the interrupt disabled, due to MCA polling. > > This error is reported through the Instruction Fetch bank. > > Clear the "Counter Present" bit in the Instruction Fetch bank's > MCA_MISC0 register. This will prevent enabling MCA thresholding on this > bank which will prevent the high interrupt rate due to this error. > > Define an AMD-specific function to filter these errors from the MCE > event pool. > > Rename filter function in EDAC/mce_amd to avoid a naming conflict. > > Cc: # 5.0.x: c95b323dcd35: x86/MCE/AMD: Turn off MC4_MISC thresholding on all family 0x15 models What is this supposed to tell us? > Cc: # 5.0.x: 30aa3d26edb0: x86/MCE/AMD: Carve out the MC4_MISC thresholding quirk > Cc: # 5.0.x: 9308fd407455: x86/MCE: Group AMD function prototypes in > Cc: # 5.0.x Confused. Thanks, tglx