Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 27 Mar 2019 19:31:15 +0000
From:   Mark Brown <broonie@kernel.org>
To:     Sasha Levin <sashal@kernel.org>
Cc:     linux-kernel@vger.kernel.org, stable@vger.kernel.org,
        Takashi Iwai <tiwai@suse.de>,
        Patrick Lai <plai@codeaurora.org>,
        Banajit Goswami <bgoswami@codeaurora.org>
Subject: Re: [PATCH AUTOSEL 5.0 107/262] ASoC: qcom: Fix of-node refcount
 unbalance in apq8016_sbc_parse_of()
Message-ID: <20190327193115.GB11404@sirena.org.uk>
References: <20190327180158.10245-1-sashal@kernel.org>
 <20190327180158.10245-107-sashal@kernel.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="O5XBE6gyVG5Rl6Rj"
Content-Disposition: inline
In-Reply-To: <20190327180158.10245-107-sashal@kernel.org>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--O5XBE6gyVG5Rl6Rj
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Mar 27, 2019 at 01:59:22PM -0400, Sasha Levin wrote:
> From: Takashi Iwai <tiwai@suse.de>
>=20
> [ Upstream commit 8d1667200850f8753c0265fa4bd25c9a6e5f94ce ]
>=20
> The apq8016 driver leaves the of-node refcount at aborting from the
> loop of for_each_child_of_node() in the error path.  Not only the
> iterator node of for_each_child_of_node(), the children nodes referred
> from it for codec and cpu have to be properly unreferenced.

Given that the device tree is entirely static on all platforms using FDT
I'm not convinced that it is sensible to backport any of the fixes for
references not being dropped that are more than one liners,
realistically nothing is ever going to notice the extra references but
there are things that will notice if we underflow references so there's
some risk we could break things somehow.  Seems like it's all risk for
zero benefit.

--O5XBE6gyVG5Rl6Rj
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAlybz4IACgkQJNaLcl1U
h9CR/Qf+IK1dAuZTewE12cGZTVrjxwfm2PU1rGE3uRQuGjgJALFdp02GF4wKOC/I
cZnzlL+k6Vy++7+TuInPAdr61tDNemUhW/yv7RM3alJFPrlLRTe12NG0uf5Wkieh
PE2PETkHvmMcQz48si8yZ66TDMhrNnlz5UdEJ2aNiJmLlpTga2IZluESXYbhYXoh
DCXMSgLfU8TgkW8CJbx0GoOIiXC9BNLaBeo3MLbg5jGsTQ9dxuJ3DqPwh22vrIR4
m2zrhHCgQ3DcSpEMBF9shEvr88+Tb99KKmGehphI9ZoNbb0Avi8iBy23TMzN75pu
BoJU87YnDd2eTBZWdJqTJHF5iJySwA==
=vUtI
-----END PGP SIGNATURE-----

--O5XBE6gyVG5Rl6Rj--