Received: by 2002:ac0:bc90:0:0:0:0:0 with SMTP id a16csp5664438img; Wed, 27 Mar 2019 12:44:25 -0700 (PDT) X-Google-Smtp-Source: APXvYqyscKG/0skQwa9JZjz54xO94+nrvLd2Aj87Kt3rLmLwwmMQupAoyHDfy3Sz83EJ8xpvCaMy X-Received: by 2002:a63:7843:: with SMTP id t64mr36351637pgc.178.1553715865570; Wed, 27 Mar 2019 12:44:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553715865; cv=none; d=google.com; s=arc-20160816; b=bGLtY+Ke6J2PFXcVJmSDarfaSQd/DxHPGPsBRdstRgotAzYzSfDWOPBEjbkB2IMbA1 jAor6lIVQeinIwB2VCN+LfQcP2CqYfWz6sP7OG99j7sDSoEvymsDiPvR2PEQilrdM49R d+r7mMWWlAZirtpokEFQDLsVJcCJEcZhnBgVBBXyBkMSXq0mU1rloYQb2vR1BR/I1ppC tf7BklvNJTwgN1M1yQXIR+usxOVhaaQSA/My9wf+DbXaBlEyEKZWphV6q0Cs+madJBrP gruEqQlzPtypBbj6w1EECxx7XDxcxhSXQokZbN8hncpVoau2vI36ygBog4WB8/LaymPt /eGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=dXTvW1BnWGPiEMTFxGgyvNnFdmU+KXr/Meh9i2Hrysw=; b=in+eiIuCQJv5Dvd9/rYIxNnOc3DgxfdbZugSpIx2PQseq5NigT0kUpEHl8C2lgUuPt DEeLbiTYnRclKahf1rnjkffqDcRu4EnfhuFLY7YoFdHZ2GyhjM6Vai2WPPwKp5a59CrH qLggi5G8pRrfwkadErtwFcYoP9yIW4qxIaerQCMyhjdlaezT4MU3K85OptYT5W8Rnubu j7N2FE4t93d61/BAopLZYqpi4Z1sJ+IwSy+dYOFtTGIGEexNiUUEwgQxuC819uzAcO9n ADXdgnHB+fRMX1bzm4AC9XKysJmSUUAzCjkGWlnfAeyB09TeViW6cGuh7JLxK0i/vDAo PHVw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=oAFwjt7W; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r17si18733967pfd.211.2019.03.27.12.44.09; Wed, 27 Mar 2019 12:44:25 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=oAFwjt7W; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728542AbfC0TmI (ORCPT + 99 others); Wed, 27 Mar 2019 15:42:08 -0400 Received: from mail-vk1-f193.google.com ([209.85.221.193]:44913 "EHLO mail-vk1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727537AbfC0TmI (ORCPT ); Wed, 27 Mar 2019 15:42:08 -0400 Received: by mail-vk1-f193.google.com with SMTP id q189so3962081vkq.11 for ; Wed, 27 Mar 2019 12:42:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=dXTvW1BnWGPiEMTFxGgyvNnFdmU+KXr/Meh9i2Hrysw=; b=oAFwjt7WQ4C/YIEWPmCRIoySCwSe64HzJdmCCWzS78KHJhMRPCOt4DKt0gm341JwTN xqbOBnlz7NAnoNb+duOp2A2hnRMO7VAnmovmG3tf0i2dIl2uxHqHm4FanVfmu5L8GwHx w98E/XCy6yQ2e80LXFvXRLrUY73Qh8q+DNYyk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dXTvW1BnWGPiEMTFxGgyvNnFdmU+KXr/Meh9i2Hrysw=; b=dDbkR/Dg+Bq/sP54yGT9cN98W2eWVEOOA9p7o75kpIDF6/fzJr9gPIC2VBbpO8n3H5 eTWocOH2hwL/iQeU5SoqVwzJcktJzCYhLltb8vIfPLyMJh8mQ9Xi+QepUd9pzVxVwsYw kwKepSdTw1FEnnPY647I80WI7eCAjSHfE3iTU6YFlL3b0AtKKFDoEeQCHYczTGocvZEW p1Iz4Fm4mTiHFtCkbzu8SLMAbS/TMSztI+tVWC3rySMgDrYeIAxuHJWrF2UROA2JAH6G sLlWiwQOmgdABGb2xmPgFV45w4KSW09vA85rtTE7/Erq+yEX4sZhupLgJgaB0XLVGqls i1WQ== X-Gm-Message-State: APjAAAVDLdukgvp32a9DekW8n0P2qMZOQTPGxQOkK1EVLsNjh+V1RZKn 3gGRJdI2e3DOHE/bE+3ina/BZpGs9RU= X-Received: by 2002:a1f:992:: with SMTP id 140mr22871656vkj.48.1553715726762; Wed, 27 Mar 2019 12:42:06 -0700 (PDT) Received: from mail-ua1-f43.google.com (mail-ua1-f43.google.com. [209.85.222.43]) by smtp.gmail.com with ESMTPSA id x2sm2113761vkx.3.2019.03.27.12.42.06 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 27 Mar 2019 12:42:06 -0700 (PDT) Received: by mail-ua1-f43.google.com with SMTP id s26so6024686uao.9 for ; Wed, 27 Mar 2019 12:42:06 -0700 (PDT) X-Received: by 2002:ab0:1ec6:: with SMTP id p6mr8004656uak.2.1553715417890; Wed, 27 Mar 2019 12:36:57 -0700 (PDT) MIME-Version: 1.0 References: <20190327162147.23198-1-christian@brauner.io> <20190327162147.23198-5-christian@brauner.io> In-Reply-To: <20190327162147.23198-5-christian@brauner.io> From: Kees Cook Date: Wed, 27 Mar 2019 12:36:46 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 4/4] tests: add pidfd_open() tests To: Christian Brauner Cc: Jann Horn , Konstantin Khlebnikov , Andy Lutomirski , David Howells , "Serge E. Hallyn" , "Eric W. Biederman" , Linux API , LKML , Arnd Bergmann , Alexey Dobriyan , Thomas Gleixner , Michael Kerrisk , bl0pbl33p@gmail.com, "Dmitry V. Levin" , Andrew Morton , Oleg Nesterov , nagarathnam.muthusamy@oracle.com, Aleksa Sarai , Al Viro , Joel Fernandes , Daniel Colascione Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 27, 2019 at 9:22 AM Christian Brauner wrote: > > This adds a simple test case for pidfd_open(). Thank you for the tests. :) It might be nice to see more extensive negative testing -- making sure pids aren't reachable from mismatched pid namespaces, etc, but this gets us basic regression testing. Also, you might save some copy/paste code using kselftest_harness.h's interfaces. -- Kees Cook