Received: by 2002:ac0:bc90:0:0:0:0:0 with SMTP id a16csp5707476img; Wed, 27 Mar 2019 13:39:29 -0700 (PDT) X-Google-Smtp-Source: APXvYqzzew6y974RpYzyGsE2Po79lugL9Z+Y/e/S/VrTumW5PvjHsf1tbJyBdv0nswRDaTecGgkN X-Received: by 2002:a62:26c1:: with SMTP id m184mr7226828pfm.102.1553719169049; Wed, 27 Mar 2019 13:39:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553719169; cv=none; d=google.com; s=arc-20160816; b=BRzuZD1yBAPrcr16sOpG8YRH5/iNB8N/+HtMyuI3Rw9Oj07MXClvAUhCXmJHJiAqrb ZW/C2oW5WbVmjKSBI1F5mUm1Zosw385wPQLCDOtGHLUZYl3adpU4fvSCltko1zLrnj/P ed45OpYw1/bkuZipvGV+RRJbwDrLtn8tsiu8Hldl8tScbqb+jksbb7hzhT5PQhoBzFMz 15EXBq2wvSemWP2RdzrO8VnsFiKZgM8nEvfcwNrWex11Q7GfEvPoo5Qrr4xikwLOcvsY /GErpuhcbXn5G4dxHRr6xq/dZHj+6yEgNgp7C87M2iR52AefwDxdZirLapCLEHfKrnco xliw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from; bh=ozDgxZC1EXH5bngFUHbNaGqzQsiNA50vaPpNqfa2zIU=; b=Ev893lUmlA+PhUfkaBFazzGLF/N1MZ58Wd9ANQDGeNx8Uke2cvxVcEh030GCWsh7Nz elEurP3LN96iPi25F2D2Hsst81xW4FfUjL8lKOkBE2qzmEc5FrQ8u6g0dHdNfZOE5mip vzF41uecrHiPTG8lZ0RxG/auyxptzEcpXl153F13bhnW/TT2EEVa51Tqqk5hUuw/cBxw aGYAgQLN3bIhlxOXpIwswZsTAj4CanM1IOaAD8CqEtEV9Ek0GySaYsyS+i+lKN3aOr6b b+MGz09SZpT6LA8Km1yrc+U9UeJNV633eVonYFffmQhoT7gDnJxfzQDqmocjG0iH0CxI FwFg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=iki.fi Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f124si6918721pgc.596.2019.03.27.13.39.13; Wed, 27 Mar 2019 13:39:29 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=iki.fi Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728790AbfC0Ufw (ORCPT + 99 others); Wed, 27 Mar 2019 16:35:52 -0400 Received: from emh06.mail.saunalahti.fi ([62.142.5.116]:55244 "EHLO emh06.mail.saunalahti.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726108AbfC0Ufw (ORCPT ); Wed, 27 Mar 2019 16:35:52 -0400 Received: from localhost.localdomain (85-76-9-223-nat.elisa-mobile.fi [85.76.9.223]) by emh06.mail.saunalahti.fi (Postfix) with ESMTP id 3E53B30087; Wed, 27 Mar 2019 22:35:49 +0200 (EET) From: Aaro Koskinen To: "David S. Miller" , Jose Abreu , Alexandre Torgue , Giuseppe Cavallaro , netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Aaro Koskinen Subject: [PATCH 0/6] net: stmmac: fix handling of oversized frames Date: Wed, 27 Mar 2019 22:35:34 +0200 Message-Id: <20190327203540.1884-1-aaro.koskinen@iki.fi> X-Mailer: git-send-email 2.17.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Aaro Koskinen Hi, I accidentally had MTU size mismatch (9000 vs. 1500) in my network, and I noticed I could kill a system using stmmac & 1500 MTU simply by pinging it with "ping -s 2000 ...". While testing a fix I encountered also some other issues that need fixing. I have tested these only with enhanced descriptors, so the normal descriptor changes need a careful review. A. Aaro Koskinen (6): net: stmmac: use correct DMA buffer size in the RX descriptor net: stmmac: ratelimit RX error logs net: stmmac: don't stop NAPI processing when dropping a packet net: stmmac: don't overwrite discard_frame status net: stmmac: fix dropping of multi-descriptor RX frames net: stmmac: don't log oversized frames .../net/ethernet/stmicro/stmmac/descs_com.h | 22 +++++++----- .../ethernet/stmicro/stmmac/dwmac4_descs.c | 2 +- .../ethernet/stmicro/stmmac/dwxgmac2_descs.c | 2 +- .../net/ethernet/stmicro/stmmac/enh_desc.c | 22 ++++++++---- drivers/net/ethernet/stmicro/stmmac/hwif.h | 2 +- .../net/ethernet/stmicro/stmmac/norm_desc.c | 12 ++++--- .../net/ethernet/stmicro/stmmac/stmmac_main.c | 34 +++++++++++-------- 7 files changed, 59 insertions(+), 37 deletions(-) -- 2.17.0