Received: by 2002:ac0:bc90:0:0:0:0:0 with SMTP id a16csp5777678img; Wed, 27 Mar 2019 15:18:35 -0700 (PDT) X-Google-Smtp-Source: APXvYqwsAruxf98E6/HE4G4ZXFFdjTK9wFuWQY5FL3WTCi8UjC3vmsHghVgnMPsfYgsSdkPOWLEi X-Received: by 2002:a17:902:bb0c:: with SMTP id l12mr39904701pls.108.1553725115232; Wed, 27 Mar 2019 15:18:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553725115; cv=none; d=google.com; s=arc-20160816; b=z07+23meQNIF4PRvKuXHkp2TrPJCY3hKHnBmzoc/vg+uaG711Wz54rD8JwXrmjsfwH z4/55FchSpmfO+/Yeb1+YOAqanEqbk23oQGZv9effjczwn3uRCCG+9Ko9el9YXo3YafC QyB3/KHAHwK2BaPCsykT+3kMl9PyzldZ9U35b1bsrQ02C2QJTWm+ZiZGnH6Gw4UeMOqa q/JcUWAD1Tkk1G/wAp1fOGTieAXAaLyIMHu+XVa8emjLJrWmzs1cUhKPrGUWprOBJNtk oslFO6FVpCZlUA7JXcom6Lj8tm/pEj1u8F47RV5opzcCMURW9bq0YJ+wjeXAGy0QFY3z ByOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=oRjzTZbcz/MALpl68ZoieZTZVzLex7W4YXGLbYPAW6Q=; b=TRcqbJHXrHuRwd0c1XCepJ1rsjTlu3EmcFHEDjwKcFe8Gz+Jwe0fP87wCznjqn6vXS gdkSbEcFpltk/b/cvhv5CO//RcGCSMJa48UJ/rShgKW7BZTUnPhhYn53mowqOoaoST/e qCo9a99szdMWzwniTLFNZYGCDvXN9qD3p2LewwgGftgwYeG0YlU5+sGNMBm08zoAzrFu 59g5LYgxwUs2ApD/3L8UJ001y9C6JCcxu1aTTKWtrutXQe0Z7UVJnAtDED19OK/jWpOU aBfcI5i84cbBm5IUOt9WhHZ2lc31F4HXx+m+UT1v1HviCy54O8NmR2OGqlIDkHPEjIu8 UTtQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t69si19606386pfa.7.2019.03.27.15.18.18; Wed, 27 Mar 2019 15:18:35 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727832AbfC0WRf (ORCPT + 99 others); Wed, 27 Mar 2019 18:17:35 -0400 Received: from sauhun.de ([88.99.104.3]:39446 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725972AbfC0WRe (ORCPT ); Wed, 27 Mar 2019 18:17:34 -0400 Received: from localhost (p5486CE6B.dip0.t-ipconnect.de [84.134.206.107]) by pokefinder.org (Postfix) with ESMTPSA id 132EB2E35A2; Wed, 27 Mar 2019 23:17:33 +0100 (CET) Date: Wed, 27 Mar 2019 23:17:32 +0100 From: Wolfram Sang To: Ray Jui Cc: Rob Herring , Mark Rutland , linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, Rayagonda Kokatanur , Shreesha Rajashekar Subject: Re: [PATCH v5 1/8] i2c: iproc: Extend I2C read up to 255 bytes Message-ID: <20190327221732.GB15396@kunai> References: <20190214175725.60462-1-ray.jui@broadcom.com> <20190214175725.60462-2-ray.jui@broadcom.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="v9Ux+11Zm5mwPlX6" Content-Disposition: inline In-Reply-To: <20190214175725.60462-2-ray.jui@broadcom.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --v9Ux+11Zm5mwPlX6 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline > + if (!((readl(iproc_i2c->base + > + M_FIFO_CTRL_OFFSET) >> > + M_FIFO_RX_CNT_SHIFT) & > + M_FIFO_RX_CNT_MASK)) Don't be too strict with the 80 char limit. I think the above is hardly readable... > + break; > + > + msg->buf[iproc_i2c->rx_bytes] = > + (readl(iproc_i2c->base + M_RX_OFFSET) >> > + M_RX_DATA_SHIFT) & M_RX_DATA_MASK; ... this here is MUCH better. Rest looks good. --v9Ux+11Zm5mwPlX6 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAlyb9nwACgkQFA3kzBSg KbYzdg//TqhPqqJ8jsf33y2YrdjFG4eYNsHy58/R6LsqUp47WsYfxCSK+pIqGFds w7Tr35HB0oOQCqxAMnsV0hJV1bdITMR3N5KpW2LPL4YHBOIfsdtwJShPjo/n7vJE XLCEWto8fyIxjFYu/VfIPpeFyMK0djtvnAr1aT0Hu7iJbNuqPtgK0Htu5YqJUAHF +KqsZtyIue8+16veAvEJ7jzQl7XcXkejpak1oOBrm69i3tvi5P0HK0wRTAninCZn v1GgOWnoP0iltCJpSDiZIRtEWcstGvx9vuHCu1DI9b/f7bk9F1Qh4V6Vwuot2JiF oG+J6UptJjoK90ZSBY4Z2yiDRU+qVYAwjskY2PLeG2AgMYP47LhZ7RDzfcNtJmiE fA+cwS3GhqIiFZbo0FPP1nKMvaJHr4xm0RDgPoTvmqxAUt5BwIMM2V8/ZnI8rlvW GVPoX9W2V4z5W8BF6/QXaaYk1QY6WLnTEgi31fofCbnYyxSre0MwvvtUzfiVdCr9 IKQKV4N1s4MDYk6nOQ6x+rGa0tmJrw2wP8UJBGD4vl/TtSrCHmd8IJAE9xF/A85v 7L0NpRIomYRXpeJRtm7mYsr8Nl/HY5nXGgK+eKScXanv7kV81P88dF+KrFDh2Ymg +tB0iOV1QGcCKxNEx0h73cs1nhTfQLL2lCZpz3d0XntkA1q2Ysg= =5U3k -----END PGP SIGNATURE----- --v9Ux+11Zm5mwPlX6--