Received: by 2002:ac0:bc90:0:0:0:0:0 with SMTP id a16csp49284img; Wed, 27 Mar 2019 16:39:38 -0700 (PDT) X-Google-Smtp-Source: APXvYqzGoKkWY1hQGLKbLIQFrZgxZQqk8Twms8xfKuxpG31rViMYPJNMN7Kp9s0BCsCrGbNA4M80 X-Received: by 2002:a17:902:e5:: with SMTP id a92mr39225783pla.326.1553729978904; Wed, 27 Mar 2019 16:39:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553729978; cv=none; d=google.com; s=arc-20160816; b=RGJENt/sGOqw7YFkgTVDJ6hKMqSzpWFICYPge48IDVkDrDUweEhb6gMk4H7p4f9NkC sf8htOxQBxr/at+ps3tguMh8kkHWLGHgyeeZGjm1ceXuBfaaxA5yHhkXcZSykzv9gN9w 4LVHOEsNGDFSh3AxwEsQbNlLOQzdjm/TyDWdrjvKjyeSlEN/G0AIDjc7x1tfq0H5jH4t uSMCpHnJJxLfb2ftMRa5JunohIlnoUh7gAX6fnlmTNR312GuCZ1II/abYDucoFzeq1Wt U/XEQ4YEewPkuBv4k+hbQXDEuNMS32TJCwyvb9bCbzsTC5KJEDyUPHVd/S6poI2Jx+/5 mRvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=E5Dvux6ocl2t0ptmnwpPqVvc51Kf5RxioNPXdEE2ueY=; b=bIVffS9+78011XYmO1ttavj8aMIvpe7Npujq8JBGaTJ7QFahcgCnEMgEnupxNF34Hr qX9Qi2n+pWAThU9MiF1UWTVJo8KI8QgnLYJ4kxDemEPv/h4GvDBaojA3nse1BFQosjER dbUwe90UyZyQMcxlU5t86mgAVRxr7JMw3yYTE1mNE5i653eDPWws1AQoVaccDkbXjz8g HlDD+Pm0Q6v/0BWczamP+wTLY/WK6EMGwsQPqECXX3dwltfMn9B9CmVqbSvQpNMIvUWB U4biNrId8hCykrxH0vWrH65lq/XimOazVhwsXER8X2CqIUkothXZrnD3vtQMWvovIZp+ 1uKw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=JGYWb7Qh; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id gn6si9301401plb.167.2019.03.27.16.39.08; Wed, 27 Mar 2019 16:39:38 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=JGYWb7Qh; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728360AbfC0Xgn (ORCPT + 99 others); Wed, 27 Mar 2019 19:36:43 -0400 Received: from mail-wm1-f65.google.com ([209.85.128.65]:37000 "EHLO mail-wm1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725601AbfC0Xgn (ORCPT ); Wed, 27 Mar 2019 19:36:43 -0400 Received: by mail-wm1-f65.google.com with SMTP id v14so1905486wmf.2 for ; Wed, 27 Mar 2019 16:36:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=E5Dvux6ocl2t0ptmnwpPqVvc51Kf5RxioNPXdEE2ueY=; b=JGYWb7QhbKU9WeDN8yMrhgCVGOfgvTPrusFe1WydTw8tYzLJk8uw/PjL9LeoARX3wH pLgE8dIfIpPNGHtH3EMHr7KsWr5AiD4uBIckeqIJZ2u+WHvJsooHiTqvrVGxbuB5mVqn lvrwUoLWZbr7G2Ip0cEL/EO9uFVXnYp6o5X6wzHIdQRk8ft7EPVV1PhD04K39kjYnRop seIJpGoex92U6HKkoMAe8+CgvLpZy+wAWL11SpzKIrfJhWfjuWh0ZKVONf27Dr5QtZeT 9+oi6TJXB8Vcib3nmKaWD3fn5zAm4gO8A+irJdYxDSLo1EbUgPTiE2fsKIWnN7uDuLxN AzlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=E5Dvux6ocl2t0ptmnwpPqVvc51Kf5RxioNPXdEE2ueY=; b=po1B2GMGzI/XroSZnTKfkDB7mo16f7dBaUgBGrbQVoOicvGQSzP6ElWyll/YhlYUuI W87+mkaAi7zjf8LbfrCfJOPydxaVPd6g1HRbfCN1G9g+5cGABGLrPqMsCbX83HZxr8jN R95aIqT2Ya3/faKywBVUBhSI1g3khQ3rW7fFK55poJaK0iV8bSak8S58+5krAVahq0to wlU4iDgd9wxE24RQa353qb6YMF81RsAQtCyFv6NdGaxvN9sTBs3p8fXhaNw4kNKpBSE8 oyGCwRljhZVOEUAywtpHCC8cD6JSxFXXzsXIKTryPybc40j4wDgScqdCAZq7vxTML3Lz 9ojw== X-Gm-Message-State: APjAAAW97ePWJo1BQMwBlbXS5WBsvv8asapK4hF/xWgKDZ4sT4P4b3qn pe4VTs4ByZdL0BAKHKC7UBhPJ/G2oZvEzXuj0QvqGA== X-Received: by 2002:a1c:4e19:: with SMTP id g25mr21187422wmh.9.1553729801307; Wed, 27 Mar 2019 16:36:41 -0700 (PDT) MIME-Version: 1.0 References: <20190307123254.348-1-omosnace@redhat.com> In-Reply-To: From: John Stultz Date: Wed, 27 Mar 2019 16:36:29 -0700 Message-ID: Subject: Re: [RFC PATCH ghak10 v6 0/2] audit: Log changes that can affect the system clock To: Paul Moore Cc: Ondrej Mosnacek , Miroslav Lichvar , Thomas Gleixner , Stephen Boyd , linux-audit@redhat.com, Richard Guy Briggs , Steve Grubb , lkml Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 25, 2019 at 7:50 AM Paul Moore wrote: > These patches look fine to me, but it would be really nice to get an > ACK from the time folks before I merge this into audit/next. Time > folks, I know you've looked at previous versions of this patchset, can > you give this a quick look to make sure everything is still okay from > your perspective? > Sorry for the slow response. I briefly looked it over and it seems simple enough, so don't really have any objections. Though I don't have as sharp an eye (or opinion :) as Thomas, so no promises he won't step in with an issue. I do want to make sure folks are careful with future changes to audit_log(), but that's my usual hand-wringing. thanks -john