Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
Date:   Thu, 28 Mar 2019 08:56:44 +0800
From:   Huang Shijie <sjhuang@iluvatar.ai>
To:     Steven Rostedt <rostedt@goodmis.org>
CC:     <mingo@redhat.com>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] trace/page_ref: print out the page migratetype name
Message-ID: <20190328005644.GA3250@hsj-Precision-5520>
References: <20190327050937.5395-1-sjhuang@iluvatar.ai>
 <20190327092422.3cf2c7a3@gandalf.local.home>
MIME-Version: 1.0
In-Reply-To: <20190327092422.3cf2c7a3@gandalf.local.home>
User-Agent: Mutt/1.9.4 (2018-02-28)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Mar 27, 2019 at 09:24:22AM -0400, Steven Rostedt wrote:
> On Wed, 27 Mar 2019 13:09:37 +0800
> Huang Shijie <sjhuang@iluvatar.ai> wrote:
> 
> > Print out the page migratetype name which is more readable.
> 
> Except that it breaks perf and trace-cmd, as they wont know what a
> migratetype_names array contains.
> 
> See how writeback does it. Which would be something like this for you.
> 
> /* enums need to be exported to user space */
Thanks for pointing this...

I did not notice that it will breaks the perf and trace-cmd.

So please just ignore this patch.

Thanks
Huang Shijie