Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <c732d470fe9ceec03b65cb92ea997e6db4e6385d.camel@perches.com>
Subject: Re: [PATCH v2] staging: rtl8723bs: core: fix line over 80
 characters warning
From:   Joe Perches <joe@perches.com>
To:     Anirudh Rayabharam <anirudh.rayabharam@gmail.com>,
        gregkh@linuxfoundation.org, hadess@hadess.net, hdegoede@redhat.com,
        Larry.Finger@lwfinger.net, dan.carpenter@oracle.com
Cc:     devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Date:   Wed, 27 Mar 2019 19:13:16 -0700
In-Reply-To: <20190327181836.GA37876@auvm>
References: <20190326182309.GA33380@auvm> <20190327181836.GA37876@auvm>
Content-Type: text/plain; charset="ISO-8859-1"
User-Agent: Evolution 3.30.1-1build1 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, 2019-03-27 at 23:49 +0530, Anirudh Rayabharam wrote:
> Checkpatch.pl complains that these lines are over 80 characters. Use the
> "psecuritypriv" pointer for consistency, remove unnecessary parantheses
> and fix the alignment.
> 
> This patch just cleans up a condition, it doesn't affect runtime.
[]
> diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c b/drivers/staging/rtl8723bs/core/rtw_ap.c
[]
> @@ -2336,8 +2336,8 @@ void rtw_ap_restore_network(struct adapter *padapter)
>  			Update_RA_Entry(padapter, psta);
>  			/* pairwise key */
>  			/* per sta pairwise key and settings */
> -			if ((padapter->securitypriv.dot11PrivacyAlgrthm == _TKIP_) ||
> -				(padapter->securitypriv.dot11PrivacyAlgrthm == _AES_)) {
> +			if (psecuritypriv->dot11PrivacyAlgrthm == _TKIP_ ||
> +			    psecuritypriv->dot11PrivacyAlgrthm == _AES_) {
>  				rtw_setstakey_cmd(padapter, psta, true, false);
>  			}

You could remove the unnecessary {} braces here too