Date: Sun, 28 Mar 2004 01:51:56 -0800
From: "David S. Miller" <davem@redhat.com>
To: uaca@alumni.uv.es
Cc: linux-net@vger.kernel.org, linux-kernel@vger.kernel.org,
       kuznet@ms2.inr.ac.ru
Subject: Re: [PATCH] PACKET_MMAP limit removal
Message-Id: <20040328015156.7c4a9bd7.davem@redhat.com>
In-Reply-To: <20040327184200.GA29991@pusa.informat.uv.es>
References: <20040322170520.GA3685@pusa.informat.uv.es>
	<20040327184200.GA29991@pusa.informat.uv.es>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 978
Lines: 28

On Sat, 27 Mar 2004 19:42:00 +0100
uaca@alumni.uv.es wrote:

> This patch also it removes the current limit on the number of frames
> PACKET_MMAP can hold. Currently the buffer can hold only
> 0.15 seconds at a 1 Gb/s in a 32 bit architecture, half
> this amount in a 64 bit machine.
>
> With this patch, PACKET_MMAP requires __less memory__
> to hold the buffer.
> 
> I have rearranged the most used members of struct packet_opt so they
> fit in a single cache line.
> 
> Any comment would be greatly appreciated

You're basically trading memory overhead for computational overhead.
And in this case I think that's fine.

I think your patch is fine and I'm going to apply it.
Can you cook up a 2.4.x version of this for me?

Thanks.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/