Received: by 2002:ac0:bc90:0:0:0:0:0 with SMTP id a16csp199848img; Wed, 27 Mar 2019 20:40:20 -0700 (PDT) X-Google-Smtp-Source: APXvYqxzKvdwaLpiepYwf25/wluD5GO1yPBRePPKYeALed5IUKHiOGrB0rEFclQ8sC72ftBBpnd8 X-Received: by 2002:a17:902:9a5:: with SMTP id 34mr40947460pln.287.1553744420279; Wed, 27 Mar 2019 20:40:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553744420; cv=none; d=google.com; s=arc-20160816; b=hNo+TYTTUBTA0NkX90ULjA8AZN8SRLt8jTqm7dfnO2tYMWJqb9/hC9Vq8mGt4rt/tK nqwO4HWUG/kUBO0gbqmuwAcA3CBBU7GM9g337rgPWyKofeX8Yl75O/lut0psSsoIAMTP nqmxMOJzeSqDR01dGyT+zThmByduW6NSkbMV67tyRjHfk3MlOQeiIdfYgqXkSbCARxLC vTnZxV1RTD/4oS5cvvDSo04TQzu6aOnWsnbpCAuMY/lE0T/c/7fX7pKRHFSgKHQ69KE1 U3c0UecCTTqGOTT15egpa6M/pauNCRDmxJFD1SKl8vSlJ+qkjZv3SLGBXKCGMvsaYSPF +Oiw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:date:cc:to:from:subject:message-id; bh=6txvgTB8uUqg2Wc1lhvdK7LnNkNfApeRyxgmSh4DVBs=; b=eSiniYmGxXlsqSmxUxF3KODEXR3lJNYAk8O1zaASGbVaHRWi4+s/HWaiRG8rzHtRml ThdBHxthKc9nkY7OJomyL4VbWH/cDduQKh59w41/UdVnThHuEFGL9FHGMKvKhMUen27O RPeuRq76egbWT4AYUOkXmqNd0NpqbU4m7MqNTfqh72R46GuI+wO6ILG/6wN7mYSxPEIF CTsMMuyGP8L9jynEXysUq4L2oMV+67Y9qe+yIPu7epvkkAr/ZG9nV8jJX6ZwPggh+vpC vVvrLIorzHGhs6l8MZtwXlucSwFUDztsbTGjbH5kuY65UKm1JMywqb+QKBBjkDUTYbl2 Xm2A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 89si2508593pld.265.2019.03.27.20.40.04; Wed, 27 Mar 2019 20:40:20 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728269AbfC1DiH (ORCPT + 99 others); Wed, 27 Mar 2019 23:38:07 -0400 Received: from mailgw02.mediatek.com ([210.61.82.184]:33167 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1727385AbfC1DiH (ORCPT ); Wed, 27 Mar 2019 23:38:07 -0400 X-UUID: 16a70dfe91944d9dac31e6b87659d0e6-20190328 X-UUID: 16a70dfe91944d9dac31e6b87659d0e6-20190328 Received: from mtkcas07.mediatek.inc [(172.21.101.84)] by mailgw02.mediatek.com (envelope-from ) (mhqrelay.mediatek.com ESMTP with TLS) with ESMTP id 1078060850; Thu, 28 Mar 2019 11:38:01 +0800 Received: from mtkcas09.mediatek.inc (172.21.101.178) by mtkmbs01n1.mediatek.inc (172.21.101.68) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 28 Mar 2019 11:37:59 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas09.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Thu, 28 Mar 2019 11:37:59 +0800 Message-ID: <1553744279.14682.10.camel@mtksdaap41> Subject: Re: [PATCH v2 05/25] drm/mediatek: split DISP_REG_CONFIG_DSI_SEL setting into another use case From: CK Hu To: CC: , , , , , , , , , , , Date: Thu, 28 Mar 2019 11:37:59 +0800 In-Reply-To: <1553667561-25447-6-git-send-email-yongqiang.niu@mediatek.com> References: <1553667561-25447-1-git-send-email-yongqiang.niu@mediatek.com> <1553667561-25447-6-git-send-email-yongqiang.niu@mediatek.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-MTK: N Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Yongqiang: On Wed, 2019-03-27 at 14:19 +0800, yongqiang.niu@mediatek.com wrote: > From: Yongqiang Niu > > Here is two modifition in this patch: > 1.bls->dpi0 and rdma1->dsi are differen usecase, > Split DISP_REG_CONFIG_DSI_SEL setting into anther usecase > 2.remove DISP_REG_CONFIG_DPI_SEL setting, DPI_SEL_IN_BLS is 0 and > this is same with hardware defautl setting, > > Signed-off-by: Yongqiang Niu > --- > drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp.c b/drivers/gpu/drm/mediatek/mtk_drm_ddp.c > index 495ebc5..80dc91f 100644 > --- a/drivers/gpu/drm/mediatek/mtk_drm_ddp.c > +++ b/drivers/gpu/drm/mediatek/mtk_drm_ddp.c > @@ -401,10 +401,9 @@ static void mtk_ddp_sout_sel(void __iomem *config_regs, > } else if (cur == DDP_COMPONENT_BLS && next == DDP_COMPONENT_DPI0) { > writel_relaxed(BLS_TO_DPI_RDMA1_TO_DSI, > config_regs + DISP_REG_CONFIG_OUT_SEL); > + } else if (cur == DDP_COMPONENT_RDMA1 && next == DDP_COMPONENT_DSI0) { > writel_relaxed(DSI_SEL_IN_RDMA, > config_regs + DISP_REG_CONFIG_DSI_SEL); > - writel_relaxed(DPI_SEL_IN_BLS, > - config_regs + DISP_REG_CONFIG_DPI_SEL); The original code is implemented by Bibby and I think MT2701 has some hardware limitation so the code works like this. Please make sure that your patch would make other SoC works. Regards, CK > } > } >