Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH net-next v5 21/22] ethtool: provide message level in
 GET_SETTINGS request
To:     Michal Kubecek <mkubecek@suse.cz>,
        David Miller <davem@davemloft.net>, netdev@vger.kernel.org
Cc:     Jakub Kicinski <jakub.kicinski@netronome.com>,
        Jiri Pirko <jiri@resnulli.us>, Andrew Lunn <andrew@lunn.ch>,
        John Linville <linville@tuxdriver.com>,
        Stephen Hemminger <stephen@networkplumber.org>,
        linux-kernel@vger.kernel.org
References: <cover.1553532199.git.mkubecek@suse.cz>
 <2eb71652408bf0cd97194069f68d264cf8070693.1553532199.git.mkubecek@suse.cz>
From:   Florian Fainelli <f.fainelli@gmail.com>
Openpgp: preference=signencrypt
Message-ID: <02fb81c1-506c-4116-d4b6-590e27871a00@gmail.com>
Date:   Wed, 27 Mar 2019 20:46:39 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.6.1
MIME-Version: 1.0
In-Reply-To: <2eb71652408bf0cd97194069f68d264cf8070693.1553532199.git.mkubecek@suse.cz>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 3/25/2019 10:08 AM, Michal Kubecek wrote:
> Add information about supported and enabled message levels to the
> GET_SETTINGS reply when ETH_SETTINGS_IM_DEBUG flag is set in the
> request.
> 
> Unlike in the ioctl interface, "message level" is called "message mask" as
> it is in fact interpreted as a bit mask. It is put into a nested attribute
> ETHA_SETTINGS_DEBUG to allow future extensions (e.g. an actual verbosity
> level).
> 
> Send notification in the same format as reply when message level is
> modified using the ioctl interface (ETHTOOL_SMSGLVL command).
> 
> Signed-off-by: Michal Kubecek <mkubecek@suse.cz>

Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
-- 
Florian