Received: by 2002:ac0:bc90:0:0:0:0:0 with SMTP id a16csp205069img; Wed, 27 Mar 2019 20:49:31 -0700 (PDT) X-Google-Smtp-Source: APXvYqwSF2FsfuKvdE+P66tbY1O7XPq3yyT0DgWcrSoORdGSTHj/WjpQyGQ48KqAWO8Mb1hogbj3 X-Received: by 2002:a63:6881:: with SMTP id d123mr37530526pgc.10.1553744971202; Wed, 27 Mar 2019 20:49:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553744971; cv=none; d=google.com; s=arc-20160816; b=LQ5lDDzqQjsIdcuEB5lxZ1c5jgIdDOh+WM0XT7tufwAATMahY+RFjCTA08lHY4KHm0 8WKmnvtoP0sDUL/99LNU1CsYpgrrJRTIMD2XdNQvQe+0Vvsqw5LFid9FxN6MO9zWLE68 inVGuXkaEjuNBUJ9eUctPVvDFRW1wbiac3t25PJo3y7km0x0/dL/0f1eQm2Uos/ua65l jLvsxhaFXqL4ETBvzpBi765SYIRVI3oR9jqQcmFzAiPw0itSg6RdGheokgKuJs6HdrCg ny2im5NozsEW6RFMbA7b4MUgr8Nc1+3qDZsbipHETXit4jgNrVbN1VAui9MKydxHwz1/ XFYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:openpgp:from:references:cc:to:subject:dkim-signature; bh=ccFezFN33u+ZDKzzfcQgVAx+T2jfJJF7pG5VljNcMgI=; b=sZ8VkVwTufe5uwG1AGXDfKirimCMihSkSfYjLQK6DaOTfplAwBqhM3fFPiFVY5CfnD 2sn5r7zympr1U/UKcqJsfSPk6tUC9kPBgBIRCO1VEKDOrb6ZNbFjxTOcQASQsDCgv8WO fDm/uV67cbzd7dKBhE3bmB2AUkeBQ+pXF/IdWpij5sbneVjwEsgf5pf+PBO2eaVa5vXv hDLQsvCpkC4ZBMIhmrbkPgyMPvwqsJzkdgdyD4NXhTY7kjTTel/XjZ63N7T6aNHUuBzo gqWVjlruK/pFeMkaqvRvFypydodFxA5PYVhHLOGSMJgW5ptq+Ljs3+vexO7h43KxX6Gf JXRA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=jfMVxekm; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l32si17928680pgm.130.2019.03.27.20.49.15; Wed, 27 Mar 2019 20:49:31 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=jfMVxekm; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728185AbfC1Dsj (ORCPT + 99 others); Wed, 27 Mar 2019 23:48:39 -0400 Received: from mail-pf1-f196.google.com ([209.85.210.196]:43199 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727146AbfC1Dsi (ORCPT ); Wed, 27 Mar 2019 23:48:38 -0400 Received: by mail-pf1-f196.google.com with SMTP id c8so10690281pfd.10; Wed, 27 Mar 2019 20:48:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:openpgp:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ccFezFN33u+ZDKzzfcQgVAx+T2jfJJF7pG5VljNcMgI=; b=jfMVxekmun88/r6Do7eNP28YredmZDJPaTNASDX28QLU6lJU2u+MhAXxz43kcpvWlt JDGV9fCcwzPu7FQ320mD+XBQH0pIlsCOZIY7nxnplHarqCp6Lg2leJb73QLkh7q9xSCI stVzmvbFXt+8tUciKet1SH9xqGfL90mMiGGQYiUx60EoTPDrx1xNiPQ+nI8gu8/zGBQj +sWKj9YVjHZ9pXO5GAw5oZLTYe2DUhgXRyBQ84VTh2HFjGPVgX8AYx//M6caIsFH/QrJ e+Yc/z7Q0sDoRYLbb7dzk4xPrgV39jn3G8N+tEe/T/a17xIAkBhArr9fZrWK9jpMlKMp yHlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ccFezFN33u+ZDKzzfcQgVAx+T2jfJJF7pG5VljNcMgI=; b=s5AafLQb6rgPc+8Q1hc62jtxSi1SGK6pVpNuii2IktPvS8RwcU/U6dZPcXO40EL87h WTv+/TSB02o+nOCEvgFm8ihQCPUjKMTbqeVu6WljNAQpCdjYFPqpWADNR21AYHIEemlh 4JEUBMw/xJBwS+ZwmTCgj0CkvgI+Yz1//6iIdX/XDC8isgWeOtv5wEB+rrSVIrNennnc eFUDWB9jVJIZp1UhxYFR09FWyZJWFisJzY9goSv251nyB4v6OMKMNx6qQatgUVMJQy/S ppcugb2oe9ZP8OGNfNQX/rn/KMZeGYaUzVGfCY8IvoPnFSsR1hVIraTjLn0JKdDH2zYp /8vQ== X-Gm-Message-State: APjAAAX6djwVDxt1CMsYrsNOvRb22SFnrxLUWTgc/S+lP9Mo//LU3rBf B+9iJXcgZ5BoXO4QVCrKdopxZjkG X-Received: by 2002:a63:dc50:: with SMTP id f16mr14191961pgj.396.1553744917942; Wed, 27 Mar 2019 20:48:37 -0700 (PDT) Received: from [192.168.1.3] (ip68-101-123-102.oc.oc.cox.net. [68.101.123.102]) by smtp.gmail.com with ESMTPSA id h13sm30774675pfn.114.2019.03.27.20.48.36 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 27 Mar 2019 20:48:36 -0700 (PDT) Subject: Re: [PATCH net-next v5 22/22] ethtool: set message level with SET_SETTINGS request To: Michal Kubecek , David Miller , netdev@vger.kernel.org Cc: Jakub Kicinski , Jiri Pirko , Andrew Lunn , John Linville , Stephen Hemminger , linux-kernel@vger.kernel.org References: <901fe605465ab8be78026ce2da21c45ea52ca3a3.1553532199.git.mkubecek@suse.cz> From: Florian Fainelli Openpgp: preference=signencrypt Message-ID: <8f62bd3b-68bb-e0ed-64aa-c0b8399127f9@gmail.com> Date: Wed, 27 Mar 2019 20:48:34 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <901fe605465ab8be78026ce2da21c45ea52ca3a3.1553532199.git.mkubecek@suse.cz> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/25/2019 10:09 AM, Michal Kubecek wrote: > Allow setting device message level using ETHA_SETTINGS_DEBUG nested > attribute. > > Unlike in ioctl interface "message level" is called "message mask" (as it > is in fact used as a bit mask) and put inside a nested attribute to allow > future extensions. > > Signed-off-by: Michal Kubecek Reviewed-by: Florian Fainelli -- Florian