Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 7BABB6072E
Subject: Re: [PATCH] tools/perf/util: Remove duplicate headers
To:     jagdsh.linux@gmail.com, peterz@infradead.org, mingo@redhat.com,
        acme@kernel.org, alexander.shishkin@linux.intel.com,
        jolsa@redhat.com, namhyung@kernel.org, ast@kernel.org,
        kafai@fb.com, songliubraving@fb.com, yhs@fb.com,
        yao.jin@linux.intel.com, eranian@google.com
Cc:     linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
        bpf@vger.kernel.org
References: <1553724446-40957-1-git-send-email-jagdsh.linux@gmail.com>
From:   Mukesh Ojha <mojha@codeaurora.org>
Message-ID: <599c35c3-88b8-f007-9eee-d7fddb1cb31b@codeaurora.org>
Date:   Thu, 28 Mar 2019 11:57:13 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.6.1
MIME-Version: 1.0
In-Reply-To: <1553724446-40957-1-git-send-email-jagdsh.linux@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 3/28/2019 3:37 AM, jagdsh.linux@gmail.com wrote:
> From: Jagadeesh Pagadala <jagdsh.linux@gmail.com>
>
> Remove duplicate headers which are included twice.
> Signed-off-by: Jagadeesh Pagadala <jagdsh.linux@gmail.com>

Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>

-Mukesh

> ---
>   tools/perf/util/annotate.c             | 1 -
>   tools/perf/util/data.c                 | 1 -
>   tools/perf/util/get_current_dir_name.c | 1 -
>   tools/perf/util/stat-display.c         | 1 -
>   4 files changed, 4 deletions(-)
>
> diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c
> index c8b0117..b1dd021 100644
> --- a/tools/perf/util/annotate.c
> +++ b/tools/perf/util/annotate.c
> @@ -36,7 +36,6 @@
>   #include <pthread.h>
>   #include <linux/bitops.h>
>   #include <linux/kernel.h>
> -#include <bpf/libbpf.h>
>   
>   /* FIXME: For the HE_COLORSET */
>   #include "ui/browser.h"
> diff --git a/tools/perf/util/data.c b/tools/perf/util/data.c
> index 6a64f71..509a41e 100644
> --- a/tools/perf/util/data.c
> +++ b/tools/perf/util/data.c
> @@ -8,7 +8,6 @@
>   #include <unistd.h>
>   #include <string.h>
>   #include <asm/bug.h>
> -#include <sys/types.h>
>   #include <dirent.h>
>   
>   #include "data.h"
> diff --git a/tools/perf/util/get_current_dir_name.c b/tools/perf/util/get_current_dir_name.c
> index 267aa60..ebb80cd 100644
> --- a/tools/perf/util/get_current_dir_name.c
> +++ b/tools/perf/util/get_current_dir_name.c
> @@ -5,7 +5,6 @@
>   #include "util.h"
>   #include <unistd.h>
>   #include <stdlib.h>
> -#include <stdlib.h>
>   
>   /* Android's 'bionic' library, for one, doesn't have this */
>   
> diff --git a/tools/perf/util/stat-display.c b/tools/perf/util/stat-display.c
> index 6d043c7..7b3a16c 100644
> --- a/tools/perf/util/stat-display.c
> +++ b/tools/perf/util/stat-display.c
> @@ -12,7 +12,6 @@
>   #include "string2.h"
>   #include "sane_ctype.h"
>   #include "cgroup.h"
> -#include <math.h>
>   #include <api/fs/fs.h>
>   
>   #define CNTR_NOT_SUPPORTED	"<not supported>"