Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 28 Mar 2019 09:02:33 +0100 (CET)
From:   Thomas Gleixner <tglx@linutronix.de>
To:     Wei Yang <richardw.yang@linux.intel.com>
cc:     x86@kernel.org, linux-kernel@vger.kernel.org,
        dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.or
Subject: Re: [PATCH 4/6] x86, mm: make split_mem_range() more easy to read
In-Reply-To: <20190328065117.GA6202@richard>
Message-ID: <alpine.DEB.2.21.1903280856470.1789@nanos.tec.linutronix.de>
References: <20190212021215.13247-1-richardw.yang@linux.intel.com> <20190212021215.13247-5-richardw.yang@linux.intel.com> <alpine.DEB.2.21.1903232345500.1798@nanos.tec.linutronix.de> <20190328065117.GA6202@richard>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Wei,

On Thu, 28 Mar 2019, Wei Yang wrote:

please trim your replies. It's annoying if one has to search the content in
the middle of a large useless quote.

> On Sun, Mar 24, 2019 at 03:29:04PM +0100, Thomas Gleixner wrote:
> >Wei,
> >-static int __meminit split_mem_range(struct map_range *mr, int nr_range,
> >-				     unsigned long start,
> >-				     unsigned long end)
> >-{
> >-	unsigned long start_pfn, end_pfn, limit_pfn;
> >-	unsigned long pfn;
> >-	int i;
> >+	if (!IS_ALIGNED(mr->end, mi->size)) {
> >+		/* Try to fit as much as possible */
> >+		len = round_down(mr->end - mr->start, mi->size);
> >+		if (!len)
> >+			return false;
> >+		mr->end = mr->start + len;
> >+	}
> > 
> >-	limit_pfn = PFN_DOWN(end);
> >+	/* Store the effective page size mask */
> >+	mr->page_size_mask = mi->mask;
> 
> I don't get the point here. Why store the effective page size mask just for
> the "middle" range.
> 
> The original behavior will set the "head" and "tail" range with a lower level
> page size mask.

What has this to do with the middle range? Nothing. This is the path where
the current map level (1g, 2m, 4k) is applied from mr->start to
mr->end. That's the effective mapping of this map_range entry. 

Thanks,

	tglx