Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 28 Mar 2019 10:16:39 +0100
From:   Jiri Pirko <jiri@resnulli.us>
To:     Michal Kubecek <mkubecek@suse.cz>
Cc:     Florian Fainelli <f.fainelli@gmail.com>,
        David Miller <davem@davemloft.net>, netdev@vger.kernel.org,
        Jakub Kicinski <jakub.kicinski@netronome.com>,
        Andrew Lunn <andrew@lunn.ch>,
        John Linville <linville@tuxdriver.com>,
        Stephen Hemminger <stephen@networkplumber.org>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v5 09/22] ethtool: implement EVENT notifications
Message-ID: <20190328091639.GK14297@nanopsycho>
References: <cover.1553532199.git.mkubecek@suse.cz>
 <971a93b567c81103716902cd1ad00946201f9710.1553532199.git.mkubecek@suse.cz>
 <20190327130428.GB14297@nanopsycho>
 <20190327141443.GS26076@unicorn.suse.cz>
 <a3d94fdf-964a-5a2c-3d96-74a0323af37e@gmail.com>
 <20190328064143.GX26076@unicorn.suse.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190328064143.GX26076@unicorn.suse.cz>
User-Agent: Mutt/1.11.3 (2019-02-01)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Thu, Mar 28, 2019 at 07:41:43AM CET, mkubecek@suse.cz wrote:
>On Wed, Mar 27, 2019 at 07:14:43PM -0700, Florian Fainelli wrote:
>> 
>> 
>> On 3/27/2019 7:14 AM, Michal Kubecek wrote:
>> > On Wed, Mar 27, 2019 at 02:04:28PM +0100, Jiri Pirko wrote:
>> >> Mon, Mar 25, 2019 at 06:08:21PM CET, mkubecek@suse.cz wrote:
>> >>> Three types of netlink notifications are introduced:
>> >>>
>> >>>  - ETHA_EVENT_NEWDEV to notify about newly registered network devices
>> >>>  - ETHA_EVENT_DELDEV to notify about unregistered network devices
>> >>>  - ETHA_EVENT_RENAMEDEV to notify about renamed network device
>> >>>
>> >>> The notifications are triggered by NETDEV_REGISTER, NETDEV_UNREGISTER and
>> >>> NETDEV_CHANGENAME notifiers.
>> >>>
>> >>> These notifications are intended for applications and daemons monitoring
>> >>> ethtool events to allow updating the list of existing devices without
>> >>> having to open another socket for rtnetlink.
>> >>
>> >> Wait. You duplicate events that are already going out through RTNETLINK.
>> >> App should open RTNETLINK in order to get those. Other apps are doing
>> >> that too. I don't think that duplications like this are desirable :/
>> > 
>> > Is there a way to filter or at least recognize these events when using
>> > rtnetlink? I couldn't find any. The only way seems to be getting every
>> > RTM_NEWLINK message (there can be quite a lot of those), always perform
>> > the lookup in my device list and recognize what happened - only to
>> > almost always find that nothing interesting. It is possible, sure, but
>> > I would really like to avoid it.
>> 
>> I am afraid you are right about this, would adding a filtering
>> capability specifically for this in rtnetlink be a better route?
>
>Maybe we could add new IFLA_EVENT_* values and use IFLA_EVENT to mark
>RTM_NEWLINK messages announcing "new device" and "device rename". That
>way, monitoring application would still need to parse all RTM_NEWLINK
>messages but it would be able to recognize which announce a change in
>device list without a lookup in its structures.

Hmm, that sounds good.

>
>Michal