Received: by 2002:a25:5b86:0:0:0:0:0 with SMTP id p128csp312349ybb; Thu, 28 Mar 2019 03:06:19 -0700 (PDT) X-Google-Smtp-Source: APXvYqzmSoqYG7kHXCG1BGqJysNNf5Y6XBUKuOcuGNaiX8z1MvQlpNaymMOR5/6UJRhV7QxZWR2O X-Received: by 2002:a63:5266:: with SMTP id s38mr39078955pgl.333.1553767579490; Thu, 28 Mar 2019 03:06:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553767579; cv=none; d=google.com; s=arc-20160816; b=hZU545hV9FqeKd7Tnp08VO9M8hi+WFd+XXOE3pd8QRQ4i8+aLW1MmLgZUJMR86pPSo 5eKmx2exjSo0KNxkZ8gF/QK0XuE5LiEp3iF5UzcUMEuakBGGKo07qkwWSNp4JJgGrdDB hzSa2aAVgdroV+iZ9gP2tg57zUB4iEbHlNVODOymmS2YOSSOI+VRM9NDHJEz9Ic0SAha zIVjv4l/YZhjwxgGAphkKd6lU/hdpXxA7usq5ScjhDShN7hGzoqPdSvbK4jhtw/XmVc9 h+y0UmTvd5QYpKFZYSNwvARhhnbGKsiniV5J6OX3nQ7sMqlyYdm7txjwDiVB77PO0QFu 07Ew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=phMghqdWbO4ZYb0Hlv3/dYLW3QAW8ojsWIgDS2hkAII=; b=WxwUbvOEsM7K8QoZkneDlYxvOucJW/DjSfrfaFfAvnngEcSja35XgDum20DQtER+IS 3Qb6fhLpPbWVt3oVabmmrlbjSapLiSPG0dwLAgZ9umJjYEiT/3oOWqMfjrSaPwXU8lfR DZklQSDV7462YJQRBYTWx5EXBqgTyCxDXnPC4zERee3KnnmVQDkKzjzKgho3YcfiqCN2 HW84hn1OLcingzA/m4i/HhxfwVdi7l372N/AA9PBWtN1HiNJU9/YtVPM7/lEfYI/4VlV 7P94q115ZKaLif7sWw5nUZ9nzibF+lcP2y+untHkzvM32J4PXNdWDxCSmnhKu7iAvx+b G6BA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g186si20305441pgc.586.2019.03.28.03.06.03; Thu, 28 Mar 2019 03:06:19 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726969AbfC1KFW (ORCPT + 99 others); Thu, 28 Mar 2019 06:05:22 -0400 Received: from Chamillionaire.breakpoint.cc ([146.0.238.67]:47102 "EHLO Chamillionaire.breakpoint.cc" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726094AbfC1KFW (ORCPT ); Thu, 28 Mar 2019 06:05:22 -0400 Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.89) (envelope-from ) id 1h9RuI-0004eI-C5; Thu, 28 Mar 2019 11:05:10 +0100 Date: Thu, 28 Mar 2019 11:05:10 +0100 From: Florian Westphal To: Alexander Potapenko Cc: pablo@netfilter.org, kadlec@blackhole.kfki.hu, fw@strlen.de, davem@davemloft.net, linux-kernel@vger.kernel.org, dvyukov@google.com, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org Subject: Re: [PATCH] netfilter: conntrack: initialize ct->timeout Message-ID: <20190328100510.g5zxthxm3ymsw6q5@breakpoint.cc> References: <20190328094720.25399-1-glider@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190328094720.25399-1-glider@google.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Alexander Potapenko wrote: > KMSAN started reporting an error when accessing ct->timeout for the > first time without initialization: > > BUG: KMSAN: uninit-value in __nf_ct_refresh_acct+0x1ae/0x470 net/netfilter/nf_conntrack_core.c:1765 > ... > dump_stack+0x173/0x1d0 lib/dump_stack.c:113 > kmsan_report+0x131/0x2a0 mm/kmsan/kmsan.c:624 > __msan_warning+0x7a/0xf0 mm/kmsan/kmsan_instr.c:310 > __nf_ct_refresh_acct+0x1ae/0x470 net/netfilter/nf_conntrack_core.c:1765 > nf_ct_refresh_acct ./include/net/netfilter/nf_conntrack.h:201 > nf_conntrack_udp_packet+0xb44/0x1040 net/netfilter/nf_conntrack_proto_udp.c:122 > nf_conntrack_handle_packet net/netfilter/nf_conntrack_core.c:1605 > nf_conntrack_in+0x1250/0x26c9 net/netfilter/nf_conntrack_core.c:1696 > ... > Uninit was created at: > kmsan_save_stack_with_flags mm/kmsan/kmsan.c:205 > kmsan_internal_poison_shadow+0x92/0x150 mm/kmsan/kmsan.c:159 > kmsan_kmalloc+0xa9/0x130 mm/kmsan/kmsan_hooks.c:173 > kmem_cache_alloc+0x554/0xb10 mm/slub.c:2789 > __nf_conntrack_alloc+0x16f/0x690 net/netfilter/nf_conntrack_core.c:1342 > init_conntrack+0x6cb/0x2490 net/netfilter/nf_conntrack_core.c:1421 Acked-by: Florian Westphal