Received: by 2002:a25:5b86:0:0:0:0:0 with SMTP id p128csp315565ybb; Thu, 28 Mar 2019 03:10:03 -0700 (PDT) X-Google-Smtp-Source: APXvYqzNwbEsZD41b3nBeOaQIQLFmzqY/E79oFp6I4cIlpcyLeBi/UhgV42yrLz3MLuKXeJVD3hf X-Received: by 2002:a62:6306:: with SMTP id x6mr39566807pfb.244.1553767803620; Thu, 28 Mar 2019 03:10:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553767803; cv=none; d=google.com; s=arc-20160816; b=OT0cGP9s5NYDT1OjByYM08z2NA0hzKutnUgxHHNWB9lIlcJOd2w2eprx/pAcezwEmP CYpoGFzkYwORwHqXkWR6VYe/ymv+3Ym6TeYDszkMNuaPAJuM45k7MHQAsCt2fKOrrh3t IbexsiHw8u6pdWYQhPN7QnSGxyTfkYSuiVeiBnOKEcVmRKFxehhm0WTf/qCp6cGNteai u/vZYDm2pZ5UHzlypGFDxMv7WO/o/5eSr8Mz2IwO2EN43YazgIDmVPHruh+i20++/5+q N38iuwAEyaYiB2Mya900sZ+CldpaDoQKenIJAvvsDj9sEV/ItGcDxCHAUhvBxj8fnX0k AGDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=ygdj7sfEXIezIks8ysLGRzZI/ymuFwbo53YDhoI4R50=; b=h9BV8LaJnVL/fTm0Mq+48yoKwROUcayDqEyyz259wygtoMznnc0ZzFFezCZEumem9Z TuAQywFCdNgsRYgie7bvqhUY/TAJcB/5mfnlV/oXo4e6wO1PSbkJQE12+RVByrWVHAng OUmnjJIXuqeTculFMPWmivil7q+4myk7GxIRGa1L1zjRnirzmFb2gK9QK+74n6TaOTOA YF20iVolQUfaetdCY44eCYB2YBj0hT/ZKJKfnXrDiV1vfzwIIfd1YfrP4ZoOfk8/+b7j D/1YT1OhCZBXA9Wlh6FbKlyuSW57EgPkx8bhuU62JzFt3driv09OsycWVbhX5QeBZPMs Zsow== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a12si5548599pls.209.2019.03.28.03.09.48; Thu, 28 Mar 2019 03:10:03 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726516AbfC1KI6 (ORCPT + 99 others); Thu, 28 Mar 2019 06:08:58 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:37365 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725846AbfC1KI6 (ORCPT ); Thu, 28 Mar 2019 06:08:58 -0400 Received: by atrey.karlin.mff.cuni.cz (Postfix, from userid 512) id 120DA806E6; Thu, 28 Mar 2019 11:08:48 +0100 (CET) Date: Thu, 28 Mar 2019 11:08:48 +0100 From: Pavel Machek To: Sasha Levin Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, John Johansen , linux-security-module@vger.kernel.org Subject: Re: [PATCH AUTOSEL 5.0 010/262] apparmor: fix double free when unpack of secmark rules fails Message-ID: <20190328100847.GC19456@atrey.karlin.mff.cuni.cz> References: <20190327180158.10245-1-sashal@kernel.org> <20190327180158.10245-10-sashal@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190327180158.10245-10-sashal@kernel.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > From: John Johansen > > [ Upstream commit d8dbb581d4f86a2ac669c056fc71a28ebeb367f4 ] > > if secmark rules fail to unpack a double free happens resulting in > the following oops > > Fixes: 9caafbe2b4cf ("apparmor: Parse secmark policy") > Reported-by: Alex Murray > Signed-off-by: John Johansen > Signed-off-by: Sasha Levin Acked-for-stable: Pavel Machek -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html