Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 7E217615E7
Subject: Re: [PATCH] drivers/fmc: remove unneeded NULL check
To:     Ding Xiang <dingxiang@cmss.chinamobile.com>, rubini@gnudd.com,
        linux-kernel@vger.kernel.org
References: <1553764997-26484-1-git-send-email-dingxiang@cmss.chinamobile.com>
From:   Mukesh Ojha <mojha@codeaurora.org>
Message-ID: <9a0194ef-2c45-3a29-2297-ee632779adb0@codeaurora.org>
Date:   Thu, 28 Mar 2019 15:52:39 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.6.1
MIME-Version: 1.0
In-Reply-To: <1553764997-26484-1-git-send-email-dingxiang@cmss.chinamobile.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 3/28/2019 2:53 PM, Ding Xiang wrote:
> The variable will check in debugfs_remove_recursive, so
> the NULL check here is not needed
>
> Signed-off-by: Ding Xiang <dingxiang@cmss.chinamobile.com>


Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>

-Mukesh

> ---
>   drivers/fmc/fmc-debug.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/fmc/fmc-debug.c b/drivers/fmc/fmc-debug.c
> index 3293072..ab868a3 100644
> --- a/drivers/fmc/fmc-debug.c
> +++ b/drivers/fmc/fmc-debug.c
> @@ -168,6 +168,5 @@ int fmc_debug_init(struct fmc_device *fmc)
>   
>   void fmc_debug_exit(struct fmc_device *fmc)
>   {
> -	if (fmc->dbg_dir)
> -		debugfs_remove_recursive(fmc->dbg_dir);
> +	debugfs_remove_recursive(fmc->dbg_dir);
>   }