Received: by 2002:a25:5b86:0:0:0:0:0 with SMTP id p128csp427626ybb; Thu, 28 Mar 2019 05:30:13 -0700 (PDT) X-Google-Smtp-Source: APXvYqxO8aSriG5c8z70p3KzpQOwwVp1RytaSDYLRQEd/iQeDrTyU+YdsJlFfZCtRTfgaI3g5Y19 X-Received: by 2002:a63:e050:: with SMTP id n16mr39388584pgj.210.1553776213598; Thu, 28 Mar 2019 05:30:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553776213; cv=none; d=google.com; s=arc-20160816; b=DPcG1dQicBCTkeO9rjj43Ax9Wxa0QRnbCeWM0cNOnSvILsh6JjXh1ZZj89ZiyBgC3O vThmm0bwWa5dO4EOt7rhx2vfM1PcSHYDI5Kt96DNrWRiKB6EtJyXj/UiOZlBclp2fAfR Ly4DWBtdR+TNTDQslrIB3fEuBAiSl5OnbANAtF+ESThYFeB8z8OAPtJnZ/IqPLpzTxyG OhvZX77RXAJFee5BSGOWbqxCQIndIzhOCicOfve20FtwKI8RsOp8jmrt1twxMyKlB2qr d7dagkcjUEvouteW8whgQWILL1KJKWwDuFX1biHgGElM79utL6KEYbHvjt9VcPyY8zrr C2GQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:organization:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=Vprbn9/uB3m4ni6PWwLuf89KR39qPiGmILL6cNQziiY=; b=hWrMxXcyHVv2j4eLwupBg8J70n0G5f3OLVQxf+3zWdXedY3WzxPXDpNHrQmPGweInV pG4+JQEVW81EAR81FHEBW5OmdkRJS0eXyvhGc0POK1pJzJd7FsyDreadVNZmq5YgVy9r kf/bFlItMyH0s4fV+SA7T6nY/cbqNvTRyI8yXd4+xYN/GR/x/8LyfxGVNt8dtGwF9SMq 0Asj76yX2NQFNBdB+CU/O8UfIkNIbynXhKc24JSIZGPuO+qMoHL0AT6jfaOiAcetB6j9 m3ZImhDwHXDpd8TJ20lBzJRbR2H5dMO5mIXYoCk/9zDJ4T2lw+zdiFEi2CAe4JX14LjL Dklg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z2si12387590pgp.239.2019.03.28.05.29.56; Thu, 28 Mar 2019 05:30:13 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726185AbfC1M2C (ORCPT + 99 others); Thu, 28 Mar 2019 08:28:02 -0400 Received: from mga17.intel.com ([192.55.52.151]:21411 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725939AbfC1M2C (ORCPT ); Thu, 28 Mar 2019 08:28:02 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Mar 2019 05:28:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,280,1549958400"; d="scan'208";a="126616710" Received: from jsakkine-mobl1.tm.intel.com (HELO localhost) ([10.237.50.182]) by orsmga007.jf.intel.com with ESMTP; 28 Mar 2019 05:27:57 -0700 Date: Thu, 28 Mar 2019 14:27:57 +0200 From: Jarkko Sakkinen To: Dan Williams Cc: linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org, James Morris , James Bottomley , Mimi Zohar , David Howells , "Serge E. Hallyn" , "open list:KEYS-TRUSTED" , open list Subject: Re: [PATCH v3] KEYS: trusted: allow trusted.ko to initialize w/o a TPM Message-ID: <20190328122757.GB7094@linux.intel.com> References: <20190326121158.13499-1-jarkko.sakkinen@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 27, 2019 at 10:15:50AM -0700, Dan Williams wrote: > On Tue, Mar 26, 2019 at 5:13 AM Jarkko Sakkinen > wrote: > > > > Allow trusted.ko to initialize w/o a TPM. This commit adds checks to the > > key type callbacks and exported functions to fail when a TPM is not > > available. > > > > Cc: James Morris > > Reported-by: Dan Williams > > Tested-by: Dan Williams > > Fixes: 240730437deb ("KEYS: trusted: explicitly use tpm_chip structure...") > > Signed-off-by: Jarkko Sakkinen > > --- > > v3: > > - remove unnecessary check for chip in init_trusted() > > v3 also tests ok here. Thank you. /Jarkko