Received: by 2002:a25:5b86:0:0:0:0:0 with SMTP id p128csp532554ybb; Thu, 28 Mar 2019 07:18:53 -0700 (PDT) X-Google-Smtp-Source: APXvYqyrqIY/QuUAKoaCZ0k76npf1Fvy0vEgcpD0ktO95qB7yS5Xf8Lq1l7KLGoJzHyhdgPhZg9z X-Received: by 2002:a62:cd8c:: with SMTP id o134mr40825730pfg.84.1553782733621; Thu, 28 Mar 2019 07:18:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553782733; cv=none; d=google.com; s=arc-20160816; b=IFGsVMWJR116rXwdCoMvRpzquX5tcxvhnkPgw3mzUp/eiOkEiABVZ175CQFi/rYV7x 1Aw/1nLpE2BlmPGHELklnm6VSyBbvYPRALpiV022f5NgtlnXjZXmnDzaifxU0NIH+/nz 0aV5WtSqH3ARDG92mol9dAciLNLJTj0xezMeXFy4wnbbTqWZQ/SNdT1cFWDTvi+fI0x1 rfjF2a5s/7NkNL62bkBi86yoWjyZqyn5zapeOWupxJR71pffv5b+VvYvHYZ/woabur9E 70SI++27uatUT5JHqUrfLQN0P//Fcf37eCmOa91h26d6A5HTaDzt7bFZBM161OAy/p4Q FCUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:content-disposition :mime-version:message-id:subject:cc:to:from:date:dkim-signature; bh=97fBova06FBtMVNalMuq00CqX3eX38Wr++PqStloLTE=; b=zQH2rk7Huc3lyhhzLL6yNyBx7aHLYG8HilKt6dpBd32yX1kMDYXhFXMVoLWOqGKzMx oaSxEZ7YI9RQVJuqctYlM/tMpYRfdMNWWGpI6ejpucpuvyiCxY332w94qo7Nsz8DqJaj J/0KgCTQzEAtQjJFeoWoG1GKj1yzWUHY9o85uEXYWy1D8fpt6/lbWgpfWJbyGOmo7G/c dES2hDlY+t8I9UYylaJd2symk2qpmr+W8A4W4cj/AP5HEGMZNrVvAYEvIMuxK7rQURh3 DYlsxpWx8MGA0NsNKpIBSMO1PB2MZgXGFlK075Zkx7fjPLRVb8DrNq3C14KY8gYeB6Yb Zbqg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=LVceLrCI; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w125si3330833pfw.137.2019.03.28.07.18.37; Thu, 28 Mar 2019 07:18:53 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=LVceLrCI; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726300AbfC1OSA (ORCPT + 99 others); Thu, 28 Mar 2019 10:18:00 -0400 Received: from aserp2130.oracle.com ([141.146.126.79]:46994 "EHLO aserp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726076AbfC1OR7 (ORCPT ); Thu, 28 Mar 2019 10:17:59 -0400 Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x2SE9Vj4038417; Thu, 28 Mar 2019 14:17:57 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : mime-version : content-type; s=corp-2018-07-02; bh=97fBova06FBtMVNalMuq00CqX3eX38Wr++PqStloLTE=; b=LVceLrCIfW+6AgQWp1/76H99Dd0B9zYBlk4pk3SMbvpeXKEPeyzUDmTptFPNeHUovH2a z3y26QkQTksOeHFYPUoT1SyZfPFFk9J3sFkonCaXVntlvKPiAsNXtZNwsHJbUBjJek5F KnnrVOvJkqWkl2ET/bJEeS+rKpo6MKEDfPXoQ99A8shiJMzKAdGzrEdsve2PC1Aato+w tjr6mcIAW7g581+gCi2JLsgPLBo7HxUVKkCnMfOPrtR8WArrT6B+WA3B8iZNN/Yvrv97 yycY/KHKRvngpwRpbeQ7llrOacgmwfFsOcIgXCRF/QfGlCknfLrGoVKO4b4BxZ4BaS5m Sw== Received: from aserv0021.oracle.com (aserv0021.oracle.com [141.146.126.233]) by aserp2130.oracle.com with ESMTP id 2re6g16vu5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 28 Mar 2019 14:17:57 +0000 Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserv0021.oracle.com (8.14.4/8.14.4) with ESMTP id x2SEHvwo021246 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 28 Mar 2019 14:17:57 GMT Received: from abhmp0003.oracle.com (abhmp0003.oracle.com [141.146.116.9]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id x2SEHvVT026233; Thu, 28 Mar 2019 14:17:57 GMT Received: from kadam (/41.202.241.10) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 28 Mar 2019 07:17:56 -0700 Date: Thu, 28 Mar 2019 17:17:42 +0300 From: Dan Carpenter To: Florian Fainelli Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH] vlynq: Fix uninitialized error code in probe() Message-ID: <20190328141742.GM32590@kadam> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Mailer: git-send-email haha only kidding User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9208 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=998 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1903280097 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The "result" variable isn't initialized on this error path. Fixes: 55e331cf7ebe ("drivers: add support for the TI VLYNQ bus") Signed-off-by: Dan Carpenter --- drivers/vlynq/vlynq.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/vlynq/vlynq.c b/drivers/vlynq/vlynq.c index c0227f9418eb..44d3485d1108 100644 --- a/drivers/vlynq/vlynq.c +++ b/drivers/vlynq/vlynq.c @@ -727,7 +727,8 @@ static int vlynq_probe(struct platform_device *pdev) dev->local_irq = dev->irq_end - dev->irq_start; dev->remote_irq = dev->local_irq - 1; - if (device_register(&dev->dev)) + result = device_register(&dev->dev); + if (result) goto fail_register; platform_set_drvdata(pdev, dev); -- 2.17.1