Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190328141652.wssqboyekxmp6tkw@yubo-2> <d870f83e-48fa-7372-7664-e268aa1acf6c@netronome.com>
In-Reply-To: <d870f83e-48fa-7372-7664-e268aa1acf6c@netronome.com>
From:   Bo YU <tsu.yubo@gmail.com>
Date:   Thu, 28 Mar 2019 22:38:15 +0800
Message-ID: <CAKq8=3LSoSq1CPUo=g8GQSsi0HC9s+ewWEcxKk6uhHARyP_phg@mail.gmail.com>
Subject: =?UTF-8?Q?Re=3A_=5BPATCH=5D_bpf=3A_bpftool=3A_convert_=E2=80=98const_char_=2A=E2=80=99?=
        =?UTF-8?Q?_type_into_=27char_=2A=27_in_assignment?=
To:     Quentin Monnet <quentin.monnet@netronome.com>
Cc:     Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Martin KaFai Lau <kafai@fb.com>, songliubraving@fb.com,
        Yonghong Song <yhs@fb.com>, jakub.kicinski@netronome.com,
        df@google.com, Netdev <netdev@vger.kernel.org>,
        bpf@vger.kernel.org, open list <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Mar 28, 2019 at 10:33 PM Quentin Monnet
<quentin.monnet@netronome.com> wrote:
>
> 2019-03-28 10:16 UTC-0400 ~ Bo YU <tsu.yubo@gmail.com>
> > When compiling with check flag: make -C tools/bpf/bpftool/
> > gcc will warning:
> >
> > jit_disasm.c:119:29: warning: assignment discards =E2=80=98const=E2=80=
=99 qualifier from
> > pointer target type [-Wdiscarded-qualifiers]
> >   info.disassembler_options =3D disassembler_options;
> >
> > So convert 'const char *' type into 'char *' to fix the warning.
> >
> > Fixes:3ddeac6705aba(tools: bpftool: use 4 context mode for the NFP disa=
sm)
> > Signed-off-by: Bo YU <tsu.yubo@gmail.com>
> > ---
> > tools/bpf/bpftool/jit_disasm.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/bpf/bpftool/jit_disasm.c
> > b/tools/bpf/bpftool/jit_disasm.c
> > index 3ef3093560ba..40b46e46454a 100644
> > --- a/tools/bpf/bpftool/jit_disasm.c
> > +++ b/tools/bpf/bpftool/jit_disasm.c
> > @@ -116,7 +116,7 @@ void disasm_print_insn(unsigned char *image, ssize_=
t
> > len, int opcodes,
> >     info.arch =3D bfd_get_arch(bfdf);
> >     info.mach =3D bfd_get_mach(bfdf);
> >     if (disassembler_options)
> > -        info.disassembler_options =3D disassembler_options;
> > +        info.disassembler_options =3D (char *)disassembler_options;
> >     info.buffer =3D image;
> >     info.buffer_length =3D len;
> >
>
>
> Hi, the warning does not show with latest versions of binutils, it was
> fixed with this (binutils) commit:
>
>     commit f995bbe8e62fdb5607acb1ee127240cfe50d2b8f
>     Author: Pedro Alves <palves@redhat.com>
>     Date:   Wed Apr 5 19:21:33 2017 +0100
>
>         -Wwrite-strings: Constify struct disassemble_info's
>                 disassembler_options field
>
> Distributions with recent binutils (Ubuntu 18.04, Fedora 29 at least)
> should not have this message. I thought about sending the same patch
> some time ago, but in the end Jakub and I decided that it may not be
> worth casting the const away to silence the warning just for older
> distributions. Daniel also shared the same opinion at the time (but that
> was off the mailing-list).
Ok, good to know it.
Thanks,
>
> Quentin