Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org D9DBA602FC
Subject: Re: [PATCH] MIPS: SGI-IP27: Fix use of unchecked pointer in
 shutdown_bridge_irq
To:     Thomas Bogendoerfer <tbogendoerfer@suse.de>,
        Ralf Baechle <ralf@linux-mips.org>,
        Paul Burton <paul.burton@mips.com>,
        James Hogan <jhogan@kernel.org>, linux-mips@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc:     Dan Carpenter <dan.carpenter@oracle.com>
References: <20190328133745.26506-1-tbogendoerfer@suse.de>
From:   Mukesh Ojha <mojha@codeaurora.org>
Message-ID: <1050e38e-c6e5-167e-fdf1-c60a3928ea72@codeaurora.org>
Date:   Thu, 28 Mar 2019 20:12:16 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.6.1
MIME-Version: 1.0
In-Reply-To: <20190328133745.26506-1-tbogendoerfer@suse.de>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 3/28/2019 7:07 PM, Thomas Bogendoerfer wrote:
> smatch complaint:
>
>      arch/mips/sgi-ip27/ip27-irq.c:123 shutdown_bridge_irq()
>      warn: variable dereferenced before check 'hd' (see line 121)
>
> Fix it by removing local variable and use hd->pin directly.
>
> Fixes: 69a07a41d908 ("MIPS: SGI-IP27: rework HUB interrupts")
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Thomas Bogendoerfer <tbogendoerfer@suse.de>


Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>

-Mukesh

> ---
>   arch/mips/sgi-ip27/ip27-irq.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/mips/sgi-ip27/ip27-irq.c b/arch/mips/sgi-ip27/ip27-irq.c
> index 710a59764b01..a32f843cdbe0 100644
> --- a/arch/mips/sgi-ip27/ip27-irq.c
> +++ b/arch/mips/sgi-ip27/ip27-irq.c
> @@ -118,7 +118,6 @@ static void shutdown_bridge_irq(struct irq_data *d)
>   {
>   	struct hub_irq_data *hd = irq_data_get_irq_chip_data(d);
>   	struct bridge_controller *bc;
> -	int pin = hd->pin;
>   
>   	if (!hd)
>   		return;
> @@ -126,7 +125,7 @@ static void shutdown_bridge_irq(struct irq_data *d)
>   	disable_hub_irq(d);
>   
>   	bc = hd->bc;
> -	bridge_clr(bc, b_int_enable, (1 << pin));
> +	bridge_clr(bc, b_int_enable, (1 << hd->pin));
>   	bridge_read(bc, b_wid_tflush);
>   }
>