Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <393f3fa45b3ddeb3f2394e0d1091021b00d9b829.camel@perches.com>
Subject: Re: [PATCH v3 34/36] thunderbolt: Make rest of the logging to
 happen at debug level
From:   Joe Perches <joe@perches.com>
To:     Mika Westerberg <mika.westerberg@linux.intel.com>,
        linux-kernel@vger.kernel.org
Cc:     Michael Jamet <michael.jamet@intel.com>,
        Yehezkel Bernat <YehezkelShB@gmail.com>,
        Andreas Noever <andreas.noever@gmail.com>,
        Lukas Wunner <lukas@wunner.de>,
        "David S . Miller" <davem@davemloft.net>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Christian Kellner <ckellner@redhat.com>,
        Mario.Limonciello@dell.com, netdev@vger.kernel.org
Date:   Thu, 28 Mar 2019 08:39:49 -0700
In-Reply-To: <20190328123633.42882-35-mika.westerberg@linux.intel.com>
References: <20190328123633.42882-1-mika.westerberg@linux.intel.com>
         <20190328123633.42882-35-mika.westerberg@linux.intel.com>
Content-Type: text/plain; charset="ISO-8859-1"
User-Agent: Evolution 3.30.1-1build1 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, 2019-03-28 at 15:36 +0300, Mika Westerberg wrote:
> Now that the driver can handle every possible tunnel types there is no
> point to log everything as info level so turn these to happen at debug
> level instead.

trivia:

> diff --git a/drivers/thunderbolt/path.c b/drivers/thunderbolt/path.c
[]
> @@ -503,8 +503,8 @@ int tb_path_activate(struct tb_path *path)
>  					    & out_mask;
>  		hop.unknown3 = 0;
>  
> -		tb_port_info(path->hops[i].in_port, "Writing hop %d, index %d",
> -			     i, path->hops[i].in_hop_index);
> +		tb_port_dbg(path->hops[i].in_port, "Writing hop %d, index %d",
> +			    i, path->hops[i].in_hop_index);

Appears to miss a '\n' termination