Received: by 2002:a25:5b86:0:0:0:0:0 with SMTP id p128csp660874ybb; Thu, 28 Mar 2019 09:38:59 -0700 (PDT) X-Google-Smtp-Source: APXvYqyECJrYHSziue1Oapmy3d/+2EVhbQ+7DH690BHvt92pxtUBNh0AWQ4Yd9ZCsCGYPKl00nxJ X-Received: by 2002:aa7:9116:: with SMTP id 22mr30504169pfh.165.1553791139736; Thu, 28 Mar 2019 09:38:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553791139; cv=none; d=google.com; s=arc-20160816; b=Y1kwEP7HlmT3fP1C6AKlQvStYU8hqEkYU3EyoUmM6sYu1iCH6CvFGOw0vtfsvgz0oj GQ59HO2YdYoQv3Km8U+hVLmrAOOt+RvwO3vrVtiEVbLyVDjlaqjGSgtxMICxDzxxr5pp +AOjGNQRvAv/WU9qK1oZNSFHuqkSUbf071TfDFkFQGZHuwS2nELFQZLtryCxnqbpA1db x8kbYIaxue44VjxpaBd0GwSNttlrGxJ2C1Ldq+AyRI970ITwrLdF2w55CGYvP+280DjM FERlsY2fPmZDHiDS+hO/fD49CB1xigIqTRbuw33Kj3osawj+Orp3bVAbLQNtnjyzxuA9 1LxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=5Rqi6tVc28O6Pn3Hdb1FJNM2EnhUMeHMWDyOPTJWIc4=; b=j6SOhV+2xJlYkUbZgnjiTt2eFpQma2OZcJvVD/QYlA0Bet6H9/u2R6uCvxzExA3fLg CQtmVn6Cyx5S1Ii7epZNF0wzaMXw2zC7z9AzhFKBJZvNjoueOZQYNiMwT5WIXNZLFQQD +ZFbQq39OOv7B0wmEYU8nIedc/9UxXD299Eq5PwE4NHr+OyxxSiL9GzbUwlyywjJ+acs 0LevtKXiB0ynXFFpLoiKBfCjO2TS1cGpQiPH69ibnczLzXL7n3386S0HTPO4zvjtaW9P 80IWxjXh0I8WZEwsM2WrXDuJ4LAHchwzJg+vcjQKK2daczxCHH85xkcVA6dQmuQcJlxD fFuA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=GfUGXorS; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d3si21326042pgd.147.2019.03.28.09.38.43; Thu, 28 Mar 2019 09:38:59 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=GfUGXorS; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726916AbfC1QiE (ORCPT + 99 others); Thu, 28 Mar 2019 12:38:04 -0400 Received: from mail-lj1-f193.google.com ([209.85.208.193]:44091 "EHLO mail-lj1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726488AbfC1QiD (ORCPT ); Thu, 28 Mar 2019 12:38:03 -0400 Received: by mail-lj1-f193.google.com with SMTP id h16so13772488ljg.11 for ; Thu, 28 Mar 2019 09:38:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=5Rqi6tVc28O6Pn3Hdb1FJNM2EnhUMeHMWDyOPTJWIc4=; b=GfUGXorS2wGNUIm6FTOUXfiNan6LFH3in17f5azB5ecQs7LeHsikjP8sQk/5HrZWO+ ZcykMVny3rR8BKEVtkIUoX4mopseCTzGnkCEFTXlBE7oNFj1ohh6VnIBjf3MHX9oAv0B fAg95ysge301stFhci7vpQ8j0RVmrz6vIX4glFYPw6PrfHj6rvNfZ4jUqjA6vYAnn4Or 3u6KHQ2OhfkG/AJSQsx4rqtA3AtPuCFPizeKap9vezI+FnEB4QfH+JujO0I6QfzAERG0 XdIRoOlRd2L48nHKlhy4/TFTgdrivVg8xsFXp3clKExNNJU4u/cBwJTmRMK9sPuby15t YVrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5Rqi6tVc28O6Pn3Hdb1FJNM2EnhUMeHMWDyOPTJWIc4=; b=Xza6/bZvsUXhKG8wKRjiL2BdHvjmaWCRZlCbeXAf7y67ZnnhDHPHE8AyQIxdrWNzO1 2nyIg7ptjOzw22SVgFO8ff7cbPbySiXUIi4y0sxQU0c7EWEt5lzHdVKJyciRfCzMkcaF gtogInkO38YNf4JiwrWW4//mMuKc6IQM45l+N6fwyIQvb/Vq7CCWAfNVeIcJjUtdLjN8 EB/pdvz1qtyXZuN2GQQKeVN29vw04EpHnJBnR7ABxNcs4ItvVxEmbshTLbWRncubZJO4 +Ga831VsnYKq+dNhPQs6f4XmjBr4mWbHkPebNsV0B0/G0I0KvAsGQvzXRo4JWi/zz1LG iw7Q== X-Gm-Message-State: APjAAAXvivgUzHd9gf3ku6fedCDMxGQW8Pp0wX/onlz70ZuvRyGzTf2p GZNDD/M7VPBEtmLryZqLVIbZL3caf/6Zao7D1pY+0w== X-Received: by 2002:a2e:b1c7:: with SMTP id e7mr1498402lja.107.1553791082299; Thu, 28 Mar 2019 09:38:02 -0700 (PDT) MIME-Version: 1.0 References: <20190322173052.23763-1-brgl@bgdev.pl> In-Reply-To: <20190322173052.23763-1-brgl@bgdev.pl> From: Linus Walleij Date: Thu, 28 Mar 2019 17:37:50 +0100 Message-ID: Subject: Re: [PATCH] gpio: mockup: fix debugfs read To: Bartosz Golaszewski Cc: "open list:GPIO SUBSYSTEM" , "linux-kernel@vger.kernel.org" , Bartosz Golaszewski Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 22, 2019 at 6:30 PM Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > The debugfs read callback must advance ppos or users using read() on > the file descriptor will never get the EOL. This wasn't spotted before > as I was using busybox cat for testing which uses sendfile() internally > and only noticed it now when switched to cat from coreutils. > > Fixes: 2a9e27408e12 ("gpio: mockup: rework debugfs interface") > Signed-off-by: Bartosz Golaszewski Patch applied for fixes. Sorry for slow application, I was in no-wifi-land for some days. Yours, Linus Walleij