Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190309015635.5401-1-manivannan.sadhasivam@linaro.org>
 <20190309015635.5401-2-manivannan.sadhasivam@linaro.org> <20190312122711.b2ibipico2dgavl7@holly.lan>
 <20190320065658.GA22381@Mani-XPS-13-9360> <20190320172956.lt4eq3vusq4traea@shell.armlinux.org.uk>
 <20190321111716.weqoderiyuicbktc@holly.lan>
In-Reply-To: <20190321111716.weqoderiyuicbktc@holly.lan>
From:   Linus Walleij <linus.walleij@linaro.org>
Date:   Thu, 28 Mar 2019 17:43:04 +0100
Message-ID: <CACRpkdZN2=qRQn2Je0uzPiuJ37+nAzboGfW+sFCb=dmzO4O_Zg@mail.gmail.com>
Subject: Re: [PATCH 1/2] amba: Take device out of reset before reading pid and
 cid values
To:     Daniel Thompson <daniel.thompson@linaro.org>
Cc:     Russell King - ARM Linux admin <linux@armlinux.org.uk>,
        Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
        Xu Wei <xuwei5@hisilicon.com>,
        Linux ARM <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Peter Griffin <peter.griffin@linaro.org>,
        Guodong Xu <guodong.xu@linaro.org>,
        Haojian Zhuang <haojian.zhuang@linaro.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Mar 21, 2019 at 12:17 PM Daniel Thompson
<daniel.thompson@linaro.org> wrote:
> On Wed, Mar 20, 2019 at 05:29:56PM +0000, Russell King - ARM Linux admin wrote:
> > On Wed, Mar 20, 2019 at 12:26:58PM +0530, Manivannan Sadhasivam wrote:

> > That said, if a reset line is shared between multiple devices, and a
> > driver wants to assert the reset line, it would disrupt the operation
> > of all those devices, so there would need to be some kind of
> > synchronisation between the drivers.
>
> That is what shared ownership of the reset line provides. When a line is
> shared a single driver does not have the authority to unilaterally
> assert reset because deasserts and asserts are counted and the line only
> goes high again when they balance.

This is what we want for this I'm pretty sure. Regulators have the same
thing with internal reference counting so that if you turn a shared regulator
on from several clients it just increases the refcount and it will not really
be turned off until the last consumer is disabling it.

Yours,
Linus Walleij