Received: by 2002:a25:5b86:0:0:0:0:0 with SMTP id p128csp680964ybb; Thu, 28 Mar 2019 10:04:11 -0700 (PDT) X-Google-Smtp-Source: APXvYqzTiWSmvsigioo8NkQ4I3ldsvodJkvXTUqiwh8WnNBQHCPjgurSyvIJ3AdBpiIWLpR540H7 X-Received: by 2002:a17:902:3:: with SMTP id 3mr44316553pla.114.1553792651364; Thu, 28 Mar 2019 10:04:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553792651; cv=none; d=google.com; s=arc-20160816; b=IS4IJ1BKkg1g28myr6ebYYTQYuV4zmW1l1s0bk8PEhvTt7Ckh1q/Uv8nLBNtUjWBgw yKUSmFYrLWIPxD15GH2gIAZ5tyX/qK+OHqpeqpP+59lzjdPqV9dTTp47Op9kMndppq4V S1LSLyeIU5j1OXYtKtEBL1JYm3+Sz4GXt/7arTGaOmeJ+LhIxenDW184K8Zx5paNCy3d MduybomikDhyiFqlwzx6e4QwWAq2Ny7+BTAdY8Y9JPEb/Dkm8ktCBuncSUVeCOLsQqiU D+NG84aUBy5IBZylbR2iD3+/7cMmafwtH2sGr/iQfO4oQaucB4L5PB6Crjcv4juEaAM4 Uj6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:openpgp:from:references:cc:to:subject :dkim-signature; bh=aKBMtYCWMERC9ihglTJPSw+HqaMOdU4DCovwOk+C7W8=; b=Q24R7vGUNeC59LZaqh/tVBD2ycUQNZa297r5uJnlG1oL+e7/R5G31sPyjr5F8KHGqI NcOhS64siLUQ1s6seuyLU0uq5Mu2GnfPmB0RpRLTif+LuiFGVomE02ncl5ZxOY4U7Pwe 6SXdbqL4UqODlwut3cq2lVJ9No2IvqmtSfZ4kMY9BdnxWpmTDoZU+TXD929UWS7bXhq7 s1Iu68ycLvsn4bn2j0DNZhb/63ziK0wdaTJHskBSjZO2NxRWKI8c8SVqheCkfFqT4njT SsiJOYJejs8wPVFPhK0JYozI3zptCHE8PYlemi941p38npNcLp+U2XMm+fp9AFy32l8W C8Ww== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=VoutD0k3; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n79si21507858pfb.133.2019.03.28.10.03.54; Thu, 28 Mar 2019 10:04:11 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=VoutD0k3; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727434AbfC1RBi (ORCPT + 99 others); Thu, 28 Mar 2019 13:01:38 -0400 Received: from mail-pl1-f196.google.com ([209.85.214.196]:35936 "EHLO mail-pl1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726098AbfC1RBh (ORCPT ); Thu, 28 Mar 2019 13:01:37 -0400 Received: by mail-pl1-f196.google.com with SMTP id k2so5238191plt.3; Thu, 28 Mar 2019 10:01:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:openpgp:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=aKBMtYCWMERC9ihglTJPSw+HqaMOdU4DCovwOk+C7W8=; b=VoutD0k3SZ9map3wKL/aafWPT/m9vi6AFai0fw3IH3eVuasvAWS33XgqfhOZl6+tbZ jrE1NRhc7+MqIyNZ1QmpRsiDDPGiyS1yPF3nxaRbhkL5G1rTD5Pr3iaRrUIevFf67XLa NZLxpSCwuP8c/3MNCWJICh6qzwLsuDtQw3FDQ/ppiGqHtBq09+kcnYDSuDXGGeLUyF2u SwmOFrgUGr27HeXIh+mCR1pmriVitkLQ4ttzmWcz/6iIZOlCspwaGPCg7yiW+qfz2IZM TfQbOnc8y7ElfocK4B85zWYnHvtzP9n7QEiNDcEunsPilKgRCP2ta96xvjkHwqpKk/io fpOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=aKBMtYCWMERC9ihglTJPSw+HqaMOdU4DCovwOk+C7W8=; b=QBn8D/VVaEEOE7KtcqJsX0iOzb56tryHITtgkzytM2iY0/rdCzIsIWmCcl5CI2F2VG WSLFFeCnYKTqxwiqGogmmWq4oEPnRS/NVbYE1v+p9e8N9sWfR86Cu1d4T4DXhASg8JJE BDrjgfXgxlz9mBq/Syg06DAOBbTXLNtTSZupq01cXU9t6/74QEe5m/RmoDcwGkDp8Mut 2tIk9bVEydpN9YITQS8zXIcu6Ya+Y4Ll1SJ+BXsWrCXtyOgEsr0NX7KSkLABVXETrfd4 Qp2WoTImSQp/64o7BuEWICGaoe+hI9MOjs33zQ68SYpj8ZKKFksQ//uqe7cORD1Yediv 29TA== X-Gm-Message-State: APjAAAVRQxwepfGy4cxw269U/+/wcN0/dCLCmKHTCMkNq0DBmedKw9PF f4NoM0Ja2UzAa3xFjZSgGb9puumN X-Received: by 2002:a17:902:3:: with SMTP id 3mr44302293pla.114.1553792496158; Thu, 28 Mar 2019 10:01:36 -0700 (PDT) Received: from [10.67.50.115] ([192.19.223.250]) by smtp.googlemail.com with ESMTPSA id a6sm21209322pfn.181.2019.03.28.10.01.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 28 Mar 2019 10:01:35 -0700 (PDT) Subject: Re: [PATCH] vlynq: Fix uninitialized error code in probe() To: Dan Carpenter , Andrew Morton Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org References: <20190328141742.GM32590@kadam> From: Florian Fainelli Openpgp: preference=signencrypt Autocrypt: addr=f.fainelli@gmail.com; prefer-encrypt=mutual; keydata= mQGiBEjPuBIRBACW9MxSJU9fvEOCTnRNqG/13rAGsj+vJqontvoDSNxRgmafP8d3nesnqPyR xGlkaOSDuu09rxuW+69Y2f1TzjFuGpBk4ysWOR85O2Nx8AJ6fYGCoeTbovrNlGT1M9obSFGQ X3IzRnWoqlfudjTO5TKoqkbOgpYqIo5n1QbEjCCwCwCg3DOH/4ug2AUUlcIT9/l3pGvoRJ0E AICDzi3l7pmC5IWn2n1mvP5247urtHFs/uusE827DDj3K8Upn2vYiOFMBhGsxAk6YKV6IP0d ZdWX6fqkJJlu9cSDvWtO1hXeHIfQIE/xcqvlRH783KrihLcsmnBqOiS6rJDO2x1eAgC8meAX SAgsrBhcgGl2Rl5gh/jkeA5ykwbxA/9u1eEuL70Qzt5APJmqVXR+kWvrqdBVPoUNy/tQ8mYc nzJJ63ng3tHhnwHXZOu8hL4nqwlYHRa9eeglXYhBqja4ZvIvCEqSmEukfivk+DlIgVoOAJbh qIWgvr3SIEuR6ayY3f5j0f2ejUMYlYYnKdiHXFlF9uXm1ELrb0YX4GMHz7QnRmxvcmlhbiBG YWluZWxsaSA8Zi5mYWluZWxsaUBnbWFpbC5jb20+iGYEExECACYCGyMGCwkIBwMCBBUCCAME FgIDAQIeAQIXgAUCVF/S8QUJHlwd3wAKCRBhV5kVtWN2DvCVAJ4u4/bPF4P3jxb4qEY8I2gS 6hG0gACffNWlqJ2T4wSSn+3o7CCZNd7SLSC5BA0ESM+4EhAQAL/o09boR9D3Vk1Tt7+gpYr3 WQ6hgYVON905q2ndEoA2J0dQxJNRw3snabHDDzQBAcqOvdi7YidfBVdKi0wxHhSuRBfuOppu pdXkb7zxuPQuSveCLqqZWRQ+Cc2QgF7SBqgznbe6Ngout5qXY5Dcagk9LqFNGhJQzUGHAsIs hap1f0B1PoUyUNeEInV98D8Xd/edM3mhO9nRpUXRK9Bvt4iEZUXGuVtZLT52nK6Wv2EZ1TiT OiqZlf1P+vxYLBx9eKmabPdm3yjalhY8yr1S1vL0gSA/C6W1o/TowdieF1rWN/MYHlkpyj9c Rpc281gAO0AP3V1G00YzBEdYyi0gaJbCEQnq8Vz1vDXFxHzyhgGz7umBsVKmYwZgA8DrrB0M oaP35wuGR3RJcaG30AnJpEDkBYHznI2apxdcuTPOHZyEilIRrBGzDwGtAhldzlBoBwE3Z3MY 31TOpACu1ZpNOMysZ6xiE35pWkwc0KYm4hJA5GFfmWSN6DniimW3pmdDIiw4Ifcx8b3mFrRO BbDIW13E51j9RjbO/nAaK9ndZ5LRO1B/8Fwat7bLzmsCiEXOJY7NNpIEpkoNoEUfCcZwmLrU +eOTPzaF6drw6ayewEi5yzPg3TAT6FV3oBsNg3xlwU0gPK3v6gYPX5w9+ovPZ1/qqNfOrbsE FRuiSVsZQ5s3AAMFD/9XjlnnVDh9GX/r/6hjmr4U9tEsM+VQXaVXqZuHKaSmojOLUCP/YVQo 7IiYaNssCS4FCPe4yrL4FJJfJAsbeyDykMN7wAnBcOkbZ9BPJPNCbqU6dowLOiy8AuTYQ48m vIyQ4Ijnb6GTrtxIUDQeOBNuQC/gyyx3nbL/lVlHbxr4tb6YkhkO6shjXhQh7nQb33FjGO4P WU11Nr9i/qoV8QCo12MQEo244RRA6VMud06y/E449rWZFSTwGqb0FS0seTcYNvxt8PB2izX+ HZA8SL54j479ubxhfuoTu5nXdtFYFj5Lj5x34LKPx7MpgAmj0H7SDhpFWF2FzcC1bjiW9mjW HaKaX23Awt97AqQZXegbfkJwX2Y53ufq8Np3e1542lh3/mpiGSilCsaTahEGrHK+lIusl6mz Joil+u3k01ofvJMK0ZdzGUZ/aPMZ16LofjFA+MNxWrZFrkYmiGdv+LG45zSlZyIvzSiG2lKy kuVag+IijCIom78P9jRtB1q1Q5lwZp2TLAJlz92DmFwBg1hyFzwDADjZ2nrDxKUiybXIgZp9 aU2d++ptEGCVJOfEW4qpWCCLPbOT7XBr+g/4H3qWbs3j/cDDq7LuVYIe+wchy/iXEJaQVeTC y5arMQorqTFWlEOgRA8OP47L9knl9i4xuR0euV6DChDrguup2aJVU4hPBBgRAgAPAhsMBQJU X9LxBQkeXB3fAAoJEGFXmRW1Y3YOj4UAn3nrFLPZekMeqX5aD/aq/dsbXSfyAKC45Go0YyxV HGuUuzv+GKZ6nsysJ7kCDQRXG8fwARAA6q/pqBi5PjHcOAUgk2/2LR5LjjesK50bCaD4JuNc YDhFR7Vs108diBtsho3w8WRd9viOqDrhLJTroVckkk74OY8r+3t1E0Dd4wHWHQZsAeUvOwDM PQMqTUBFuMi6ydzTZpFA2wBR9x6ofl8Ax+zaGBcFrRlQnhsuXLnM1uuvS39+pmzIjasZBP2H UPk5ifigXcpelKmj6iskP3c8QN6x6GjUSmYx+xUfs/GNVSU1XOZn61wgPDbgINJd/THGdqiO iJxCLuTMqlSsmh1+E1dSdfYkCb93R/0ZHvMKWlAx7MnaFgBfsG8FqNtZu3PCLfizyVYYjXbV WO1A23riZKqwrSJAATo5iTS65BuYxrFsFNPrf7TitM8E76BEBZk0OZBvZxMuOs6Z1qI8YKVK UrHVGFq3NbuPWCdRul9SX3VfOunr9Gv0GABnJ0ET+K7nspax0xqq7zgnM71QEaiaH17IFYGS sG34V7Wo3vyQzsk7qLf9Ajno0DhJ+VX43g8+AjxOMNVrGCt9RNXSBVpyv2AMTlWCdJ5KI6V4 KEzWM4HJm7QlNKE6RPoBxJVbSQLPd9St3h7mxLcne4l7NK9eNgNnneT7QZL8fL//s9K8Ns1W t60uQNYvbhKDG7+/yLcmJgjF74XkGvxCmTA1rW2bsUriM533nG9gAOUFQjURkwI8jvMAEQEA AYkCaAQYEQIACQUCVxvH8AIbAgIpCRBhV5kVtWN2DsFdIAQZAQIABgUCVxvH8AAKCRCH0Jac RAcHBIkHD/9nmfog7X2ZXMzL9ktT++7x+W/QBrSTCTmq8PK+69+INN1ZDOrY8uz6htfTLV9+ e2W6G8/7zIvODuHk7r+yQ585XbplgP0V5Xc8iBHdBgXbqnY5zBrcH+Q/oQ2STalEvaGHqNoD UGyLQ/fiKoLZTPMur57Fy1c9rTuKiSdMgnT0FPfWVDfpR2Ds0gpqWePlRuRGOoCln5GnREA/ 2MW2rWf+CO9kbIR+66j8b4RUJqIK3dWn9xbENh/aqxfonGTCZQ2zC4sLd25DQA4w1itPo+f5 V/SQxuhnlQkTOCdJ7b/mby/pNRz1lsLkjnXueLILj7gNjwTabZXYtL16z24qkDTI1x3g98R/ xunb3/fQwR8FY5/zRvXJq5us/nLvIvOmVwZFkwXc+AF+LSIajqQz9XbXeIP/BDjlBNXRZNdo dVuSU51ENcMcilPr2EUnqEAqeczsCGpnvRCLfVQeSZr2L9N4svNhhfPOEscYhhpHTh0VPyxI pPBNKq+byuYPMyk3nj814NKhImK0O4gTyCK9b+gZAVvQcYAXvSouCnTZeJRrNHJFTgTgu6E0 caxTGgc5zzQHeX67eMzrGomG3ZnIxmd1sAbgvJUDaD2GrYlulfwGWwWyTNbWRvMighVdPkSF 6XFgQaosWxkV0OELLy2N485YrTr2Uq64VKyxpncLh50e2RnyAJ9Za0Dx0yyp44iD1OvHtkEI M5kY0ACeNhCZJvZ5g4C2Lc9fcTHu8jxmEkI= Message-ID: Date: Thu, 28 Mar 2019 10:01:33 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <20190328141742.GM32590@kadam> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/28/19 7:17 AM, Dan Carpenter wrote: > The "result" variable isn't initialized on this error path. > > Fixes: 55e331cf7ebe ("drivers: add support for the TI VLYNQ bus") > Signed-off-by: Dan Carpenter Acked-by: Florian Fainelli Andrew can you pick this up the same you have you done that before? > --- > drivers/vlynq/vlynq.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/vlynq/vlynq.c b/drivers/vlynq/vlynq.c > index c0227f9418eb..44d3485d1108 100644 > --- a/drivers/vlynq/vlynq.c > +++ b/drivers/vlynq/vlynq.c > @@ -727,7 +727,8 @@ static int vlynq_probe(struct platform_device *pdev) > dev->local_irq = dev->irq_end - dev->irq_start; > dev->remote_irq = dev->local_irq - 1; > > - if (device_register(&dev->dev)) > + result = device_register(&dev->dev); > + if (result) > goto fail_register; > platform_set_drvdata(pdev, dev); > > -- Florian