Received: by 2002:a25:5b86:0:0:0:0:0 with SMTP id p128csp685668ybb; Thu, 28 Mar 2019 10:08:49 -0700 (PDT) X-Google-Smtp-Source: APXvYqwTM6tQHoiQ9He6uMTj01UN8NbQNcCFd7kOzxfLDpgoCxob8nuO/ZcJpxPw4PXQERtBXGAV X-Received: by 2002:a65:4846:: with SMTP id i6mr8627414pgs.132.1553792928954; Thu, 28 Mar 2019 10:08:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553792928; cv=none; d=google.com; s=arc-20160816; b=ptyyVlwmA4sy6OEr5J3H8t33mJ6TRxl/SfzjQ9iOykTUETKDdUjvNWdf0CTN1DgbS8 jI4AdOswRD3fzAEKoGgjaVO2rokqySd+j7I5c8eqXzjxAoUw2fYED8l1EHEaCx1fZMeU /0OnDS07OzDCIhtxcHfx/Y4gpD+YtRrSDsugaqkhpMoGEbNBzgsszw32pFRD5Ln3GWt9 D/GtEdb8vFdmBOQRF2+10QIDiW+EgZUQUzbXdG81+k/bVFfcv2KXYV5A4d7HHn4ih0NH GowJmKn0U+wg6vyPuLVbku4OmugINNRnXtRI2eyHju8afFiBW3ti5OBxXzFxstY1c5zC AT0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=uRLMmlCtxjK43/f+Dv/wuEqUOC5RktobzhD5YwYe8/4=; b=K5g0MDF7+2W3AsAeGEOt8kL+A9ydJJtqA/DVlM1iu2iPJPeixXTC4OSJYAmXUmCuMf 6IRMxXDbUJblRlrL0zUk6WHEq7iX/yEpceUQd7df4Jn/+YrOss5lvXktn1ScMmuxHAtN iiXwvbatcjBkzutr/4M3W1VpANkdU16ej2pF2A4z0slLPcAgNrglKhR21c2HsHv2WH/w skO4v61BncXCZYZpIDbdCMTjM2UlcDet1VxkeAPgbllo4bFKF+Vb8EmVzf5b70MBdjfR 7VLKV1ybOxgWAa56T7KF7gYexyBIlhQJ4SMQAAC4/uln7wfmtsBbAsafC8Fxku+Wsv5q 9NbQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=QPKPoHl9; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i1si17077090pgb.322.2019.03.28.10.08.33; Thu, 28 Mar 2019 10:08:48 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=QPKPoHl9; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727426AbfC1RGf (ORCPT + 99 others); Thu, 28 Mar 2019 13:06:35 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:36128 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725816AbfC1RGe (ORCPT ); Thu, 28 Mar 2019 13:06:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=uRLMmlCtxjK43/f+Dv/wuEqUOC5RktobzhD5YwYe8/4=; b=QPKPoHl9etGIR208j04fzT/zO yk7IIl/vAYHKo+or5sCDFOfMEmoI4Hl6GL5XqPVD1yBt0wCuBeA0x8n/q3FxW9By7MPZNgwbLeA2/ F/zulW5SQpXtD7VXdVYbSo2Qt2cu1DtVvkAWJurJQ5KC98Tjr591VzYM9SH5CwBAYtrf+qgs0nDJb AYZxhdXRfNfbOPLI5nga/nPYpzfR9fmIaYGPfSRzY4rw2Aqk5ozVLY3xVr3h9zPar1fgETSD4qIIG rjPSkdMymib3UK4CUA2yFikh01UmB9oqCBbSojuylgF8GKsE5PPbHvFnAikuiwJDKZxbIruDT4QuC +DptLIU5w==; Received: from hch by bombadil.infradead.org with local (Exim 4.90_1 #2 (Red Hat Linux)) id 1h9YU2-000268-Tf; Thu, 28 Mar 2019 17:06:30 +0000 Date: Thu, 28 Mar 2019 10:06:30 -0700 From: Christoph Hellwig To: David Kozub Cc: Jens Axboe , Jonathan Derrick , Scott Bauer , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Jonas Rabenstein Subject: Re: [PATCH 13/16] block: sed-opal: use named Opal tokens instead of integer literals Message-ID: <20190328170630.GE27845@infradead.org> References: <1550103368-4605-1-git-send-email-zub@linux.fjfi.cvut.cz> <1550103368-4605-14-git-send-email-zub@linux.fjfi.cvut.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1550103368-4605-14-git-send-email-zub@linux.fjfi.cvut.cz> User-Agent: Mutt/1.9.2 (2017-12-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 14, 2019 at 01:16:05AM +0100, David Kozub wrote: > Replace integer literals by Opal tokens defined in opal_proto.h where > possible. > > Signed-off-by: David Kozub Looks good, Reviewed-by: Christoph Hellwig